Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-12 Thread Bart Van Assche
On 05/07/14 19:19, Sagi Grimberg wrote: P.S, can we consider also skip scsi_cmnd SEND completions? Currently SRP asks for completion but never really arm the CQ (only for the first time). Hello Sagi, Can you clarify this further ? Removing the IB_SEND_SIGNALED flag from send requests is not

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-08 Thread Bart Van Assche
On 05/07/14 19:19, Sagi Grimberg wrote: On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +pool = srp_create_fr_pool(dev-dev, dev-pd, + SRP_MDESC_PER_POOL, max_pages_per_mr); 1024 FRMRs per connection?! we use 1024 FMRs for all

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-08 Thread Sagi Grimberg
On 5/8/2014 3:38 PM, Bart Van Assche wrote: On 05/07/14 19:19, Sagi Grimberg wrote: On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +pool = srp_create_fr_pool(dev-dev, dev-pd, + SRP_MDESC_PER_POOL, max_pages_per_mr); 1024 FRMRs

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-08 Thread Bart Van Assche
On 05/08/14 17:16, Sagi Grimberg wrote: On 5/8/2014 3:38 PM, Bart Van Assche wrote: On 05/07/14 19:19, Sagi Grimberg wrote: On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +pool = srp_create_fr_pool(dev-dev, dev-pd, +

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-08 Thread Sagi Grimberg
On 5/8/2014 7:00 PM, Bart Van Assche wrote: On 05/08/14 17:16, Sagi Grimberg wrote: On 5/8/2014 3:38 PM, Bart Van Assche wrote: On 05/07/14 19:19, Sagi Grimberg wrote: On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +pool =

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Bart Van Assche
On 05/07/14 13:34, Sagi Grimberg wrote: +module_param(prefer_fr, bool, 0444); +MODULE_PARM_DESC(prefer_fr, + Whether to use FR if both FMR and FR are supported); Will it be better to make it a per-target attribute? Hello Sagi, The only reason I introduced this kernel module

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +module_param(prefer_fr, bool, 0444); +MODULE_PARM_DESC(prefer_fr, + Whether to use FR if both FMR and FR are supported); Will it be better to make it a per-target attribute? Hello Sagi, The only

[PATCH 9/9] IB/srp: Add fast registration support

2014-05-06 Thread Bart Van Assche
Certain HCA types (e.g. Connect-IB) and certain configurations (e.g. ConnectX VF) support FR but not FMR. Hence add FR support. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Roland Dreier rol...@purestorage.com Cc: David Dillow d...@thedillows.org Cc: Sagi Grimberg sa...@mellanox.com Cc: