Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-22 Thread Matan Barak
On Sun, Nov 22, 2015 at 12:15 PM, Christoph Hellwig wrote: > Hi Matan, > > IB_CQ_FLAGS_TIMESTAMP_COMPLETION is _only_ used in the uverbs interface. > Currently this is used only for uverbs interface. The reason for that is that we've only pushed completion timestamping for user-space support. How

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-22 Thread Christoph Hellwig
Hi Matan, IB_CQ_FLAGS_TIMESTAMP_COMPLETION is _only_ used in the uverbs interface. But other than that userspace ABIs really must go to the UAPI headers, otherwise they will be broken sooner or later. RDMA is an unfortunate oddball under the kernel subsystems that's been ignoring the rule for no

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-22 Thread Matan Barak
On Thu, Nov 19, 2015 at 4:54 PM, Christoph Hellwig wrote: >> +enum { >> + CQ_CREATE_FLAGS_SUPPORTED = IB_CQ_FLAGS_TIMESTAMP_COMPLETION >> +}; > > > How does userspace know the value of IB_CQ_FLAGS_TIMESTAMP_COMPLETION? > > It's not defined in any UAPI header. Currently, a lot of flags are def

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-19 Thread Christoph Hellwig
> +enum { > + CQ_CREATE_FLAGS_SUPPORTED = IB_CQ_FLAGS_TIMESTAMP_COMPLETION > +}; How does userspace know the value of IB_CQ_FLAGS_TIMESTAMP_COMPLETION? It's not defined in any UAPI header. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to ma

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-10 Thread Matan Barak
On Tue, Nov 10, 2015 at 1:24 AM, Jason Gunthorpe wrote: > On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: >> @@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) >> (1ull << IB_USER_VERBS_CMD_CREATE_XSRQ) | >> (1ull << IB_USER_

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-10 Thread Matan Barak
On Tue, Nov 10, 2015 at 1:22 AM, Jason Gunthorpe wrote: > On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: >> In order to create a CQ that supports timestamp, mlx5 needs to >> support the extended create CQ command with the timestamp flag. >> >> Signed-off-by: Matan Barak >> drivers/

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-09 Thread Jason Gunthorpe
On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: > @@ -1385,7 +1385,8 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) > (1ull << IB_USER_VERBS_CMD_CREATE_XSRQ) | > (1ull << IB_USER_VERBS_CMD_OPEN_QP); > dev->ib_dev.uverbs_ex_cmd_mask = >

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-09 Thread Jason Gunthorpe
On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: > In order to create a CQ that supports timestamp, mlx5 needs to > support the extended create CQ command with the timestamp flag. > > Signed-off-by: Matan Barak > drivers/infiniband/hw/mlx5/cq.c | 7 +++ > drivers/infiniband/hw/

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-09 Thread Eli Cohen
On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: > In order to create a CQ that supports timestamp, mlx5 needs to > support the extended create CQ command with the timestamp flag. > > Signed-off-by: Matan Barak Acked-by: Eli Cohen -- To unsubscribe from this list: send the line "uns

Re: [PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-09 Thread Eli Cohen
On Mon, Nov 09, 2015 at 06:30:54PM +0200, Matan Barak wrote: > In order to create a CQ that supports timestamp, mlx5 needs to > support the extended create CQ command with the timestamp flag. > i> Signed-off-by: Matan Barak Acked-by: Eli Cohen -- To unsubscribe from this list: send the line "un

[PATCH for-next 1/4] IB/mlx5: Add create_cq extended command

2015-11-09 Thread Matan Barak
In order to create a CQ that supports timestamp, mlx5 needs to support the extended create CQ command with the timestamp flag. Signed-off-by: Matan Barak --- drivers/infiniband/hw/mlx5/cq.c | 7 +++ drivers/infiniband/hw/mlx5/main.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-)