Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 9/11/2012 4:43 PM, Roland Dreier wrote: > On Tue, Sep 11, 2012 at 1:34 PM, Doug Ledford wrote: >> Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver >> uses them, and both QLogic/Intel drivers have their own internal pkey >> table implementation. So, it isn't so much uppe

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Roland Dreier
On Tue, Sep 11, 2012 at 1:34 PM, Doug Ledford wrote: > Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver > uses them, and both QLogic/Intel drivers have their own internal pkey > table implementation. So, it isn't so much upper layer as it is drivers. rdmacm is an upper-le

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 9/11/2012 3:07 PM, Roland Dreier wrote: > On Tue, Sep 11, 2012 at 10:12 AM, Doug Ledford wrote: >> As a second note, I would like to know why Intel (previously QLogic) >> does not use these functions in their driver and what it would take to >> get all drivers to use the functions. Do we need

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Roland Dreier
On Tue, Sep 11, 2012 at 10:12 AM, Doug Ledford wrote: > As a second note, I would like to know why Intel (previously QLogic) > does not use these functions in their driver and what it would take to > get all drivers to use the functions. Do we need to add more to them? > In my opinion these shoul

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: > When port pkey table potentially contains both full and partial > membership copies for the same pkey, we need a function to find > the exact (16-bit) pkey index. > > This is particularly necessary when the master forwards QP1 MADS > sent by guests.

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 8/3/2012 4:40 AM, Jack Morgenstein wrote: > When port pkey table potentially contains both full and partial > membership copies for the same pkey, we need a function to find > the exact (16-bit) pkey index. The code on this patch is fine, just see my previous email about the function naming...

[PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-08-03 Thread Jack Morgenstein
When port pkey table potentially contains both full and partial membership copies for the same pkey, we need a function to find the exact (16-bit) pkey index. This is particularly necessary when the master forwards QP1 MADS sent by guests. If the guest has sent the MAD with a limited membership p