Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-30 Thread Matan Barak
On 12/30/2015 8:04 AM, Or Gerlitz wrote: Hi Matan, I see these two smatch complaints on code added with this series, can you please take a look? drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn: variable dereferenced before check 'src_addr' (see line 500)

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-30 Thread Matan Barak
On 12/30/2015 1:05 PM, Or Gerlitz wrote: On 12/30/2015 12:48 PM, Matan Barak wrote: On 12/30/2015 8:04 AM, Or Gerlitz wrote: Hi Matan, I see these two smatch complaints on code added with this series, can you please take a look? drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route()

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-30 Thread Or Gerlitz
On 12/30/2015 12:48 PM, Matan Barak wrote: On 12/30/2015 8:04 AM, Or Gerlitz wrote: Hi Matan, I see these two smatch complaints on code added with this series, can you please take a look? drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn: variable dereferenced before check

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-29 Thread Or Gerlitz
Hi Matan, I see these two smatch complaints on code added with this series, can you please take a look? drivers/infiniband/core/addr.c:503 rdma_resolve_ip_route() warn: variable dereferenced before check 'src_addr' (see line 500) drivers/infiniband/core/cma_configfs.c:172 make_cma_ports()

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Doug Ledford
On 12/23/2015 07:56 AM, Matan Barak wrote: > Hi Doug, > This patch is applied on the "Change per-entry locks in GID cache to > table lock" series which was sent to the mailing list. The "Change per-entry locks..." patchset emails are missing from my mail folder (another casualty of that mail

Re: [PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Doug Ledford
On 12/23/2015 07:56 AM, Matan Barak wrote: > Hi Doug, > > This series adds the support for RoCE v2. In order to support RoCE v2, > we add gid_type attribute to every GID. When the RoCE GID management > populates the GID table, it duplicates each GID with all supported types. > This gives the user

[PATCH for-next V3 00/11] Add RoCE v2 support

2015-12-23 Thread Matan Barak
Hi Doug, This series adds the support for RoCE v2. In order to support RoCE v2, we add gid_type attribute to every GID. When the RoCE GID management populates the GID table, it duplicates each GID with all supported types. This gives the user the ability to communicate over each supported type.