Re: [PATCH net-next 1/5] RDMA/cxgb4: Cleanup Filter related macros/register defines

2014-11-21 Thread Hariprasad S
On Thu, Nov 20, 2014 at 23:55:54 -0800, Joe Perches wrote: > On Fri, 2014-11-21 at 12:52 +0530, Hariprasad Shenai wrote: > > This patch cleanups all filter related macros/register defines that are > > defined > > in t4fw_api.h and the affected files. > > Is there any real value in the FW_FILTER_W

Re: [PATCH net-next 1/5] RDMA/cxgb4: Cleanup Filter related macros/register defines

2014-11-21 Thread Joe Perches
On Fri, 2014-11-21 at 12:52 +0530, Hariprasad Shenai wrote: > This patch cleanups all filter related macros/register defines that are > defined > in t4fw_api.h and the affected files. Is there any real value in the FW_FILTER_WR_ prefix? Does it need to be so long? Perhaps it'd be nicer to read i

[PATCH net-next 1/5] RDMA/cxgb4: Cleanup Filter related macros/register defines

2014-11-20 Thread Hariprasad Shenai
This patch cleanups all filter related macros/register defines that are defined in t4fw_api.h and the affected files. Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/cm.c| 14 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 68 ++-- drivers/net/ethernet/