Re: [PATCH v3 12/26] xprtrdma: Port to new memory registration API

2015-10-09 Thread Sagi Grimberg
out_list_err: - rc = PTR_ERR(f->fr_pgl); + rc = -ENOMEM; dprintk("RPC: %s: ib_alloc_fast_reg_page_list status %i\n”, Should you update this debugging message? Yes I will. + n = ib_map_mr_sg(mr, frmr->sg, frmr->sg_nents, PAGE_SIZE); + if (unlikely(n !=

Re: [PATCH v3 12/26] xprtrdma: Port to new memory registration API

2015-10-08 Thread Or Gerlitz
On Thu, Oct 8, 2015 at 10:50 AM, Sagi Grimberg wrote: > Instead of maintaining a fastreg page list, keep an sg table > and convert an array of pages to a sg list. Then call ib_map_mr_sg > and construct ib_reg_wr. > > Note that the next step would be to have NFS work with sg lists > as it maps well

Re: [PATCH v3 12/26] xprtrdma: Port to new memory registration API

2015-10-08 Thread Chuck Lever
> On Oct 8, 2015, at 3:50 AM, Sagi Grimberg wrote: > > Instead of maintaining a fastreg page list, keep an sg table > and convert an array of pages to a sg list. Then call ib_map_mr_sg > and construct ib_reg_wr. > > Note that the next step would be to have NFS work with sg lists > as it maps we

Re: [PATCH v3 12/26] xprtrdma: Port to new memory registration API

2015-10-08 Thread Anna Schumaker
Hi Sagi, On 10/08/2015 03:50 AM, Sagi Grimberg wrote: > Instead of maintaining a fastreg page list, keep an sg table > and convert an array of pages to a sg list. Then call ib_map_mr_sg > and construct ib_reg_wr. > > Note that the next step would be to have NFS work with sg lists > as it maps wel

[PATCH v3 12/26] xprtrdma: Port to new memory registration API

2015-10-08 Thread Sagi Grimberg
Instead of maintaining a fastreg page list, keep an sg table and convert an array of pages to a sg list. Then call ib_map_mr_sg and construct ib_reg_wr. Note that the next step would be to have NFS work with sg lists as it maps well to sk_frags (see comment from hch http://marc.info/?l=linux-rdma&