+ *blh = unlikely(halign 64) ? 1 : 0;
This idiom of (boolean condition) ? 1 : 0 looks odd to me... doesn't
(halign 64) already evaluate to 1 or 0 anyway? Does the unlikely()
actually affect code generation here?
True, (halign 64) is the same and is cleaner. As for the
On Sun, Oct 04, 2009 at 10:12:16AM +0200, Or Gerlitz wrote:
Also, this patch will cause IB_DEVICE_UD_TSO to be set only of FW versions
that set MLX4_DEV_CAP_FLAG_BLH; e.g. FW version 2.6.000 and higher.
warning to users having an older firmware installed?
I am not sure this deserves a warning
On Wed, Oct 07, 2009 at 03:45:16PM -0700, Roland Dreier wrote:
+ *blh = unlikely(halign 64) ? 1 : 0;
This idiom of (boolean condition) ? 1 : 0 looks odd to me... doesn't
(halign 64) already evaluate to 1 or 0 anyway? Does the unlikely()
actually affect code generation here?
True,
Eli Cohen wrote:
Current code has a limitation as for the size of an LSO header not allowed to
cross a 64 byte boundary. This patch removes this limitation by setting the WQE
RR for large headers thus allowing LSO headers of any size. The extra buffer
reserved for MLX4_IB_QP_LSO QPs has been
