Re: [RFC PATCH] Set HopLimit based on off subnet Re: SRP issues with OpenSM 3.3.3

2009-12-20 Thread Sasha Khapyorsky
On 18:18 Thu 17 Dec , Ira Weiny wrote: It might be faster but it would mean a bigger change. It looks like having the dgid or p_pr structures in some internal opensm structure to carry that information along would be best but that is a lot of work. Actually now dgid parameter is never

Re: [RFC PATCH] Set HopLimit based on off subnet Re: SRP issues with OpenSM 3.3.3

2009-12-18 Thread Hal Rosenstock
On Thu, Dec 17, 2009 at 9:18 PM, Ira Weiny wei...@llnl.gov wrote: On Wed, 16 Dec 2009 08:29:43 -0500 Hal Rosenstock hal.rosenst...@gmail.com wrote: On Tue, Dec 15, 2009 at 9:55 PM, Ira Weiny wei...@llnl.gov wrote: [snip] diff --git a/opensm/opensm/osm_sa_path_record.c

Re: [RFC PATCH] Set HopLimit based on off subnet Re: SRP issues with OpenSM 3.3.3

2009-12-17 Thread Ira Weiny
On Wed, 16 Dec 2009 08:29:43 -0500 Hal Rosenstock hal.rosenst...@gmail.com wrote: On Tue, Dec 15, 2009 at 9:55 PM, Ira Weiny wei...@llnl.gov wrote: [snip] diff --git a/opensm/opensm/osm_sa_path_record.c b/opensm/opensm/osm_sa_path_record.c index be0cd71..1fa83a1 100644 ---

Re: [RFC PATCH] Set HopLimit based on off subnet Re: SRP issues with OpenSM 3.3.3

2009-12-16 Thread Hal Rosenstock
On Tue, Dec 15, 2009 at 9:55 PM, Ira Weiny wei...@llnl.gov wrote: On Tue, 15 Dec 2009 12:59:11 -0500 Hal Rosenstock hal.rosenst...@gmail.com wrote: On Tue, Dec 15, 2009 at 12:18 PM, Ira Weiny wei...@llnl.gov wrote: [snip] The follow on would be that if they specify a DGID in the

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Hal Rosenstock
Ira, On Mon, Dec 14, 2009 at 7:43 PM, Ira Weiny wei...@llnl.gov wrote: Sasha, Hal, I have found that the following patch caused our SRP connected storage to break. What is causing the SRP target to fail ? Is it a non zero hop limit returned in the SA PathRecord ? patch:

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Sasha Khapyorsky
Hi Ira, On 16:43 Mon 14 Dec , Ira Weiny wrote: I have found that the following patch caused our SRP connected storage to break. patch: 3d20f82edd3246879063b77721d0bcef927bdc48 opensm/osm_sa_path_record.c: separate router guid resolution code Move off subnet

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Sasha Khapyorsky
On 10:16 Tue 15 Dec , Hal Rosenstock wrote: patch: 3d20f82edd3246879063b77721d0bcef927bdc48    opensm/osm_sa_path_record.c: separate router guid resolution code    Move off subnet destination (router address) resolution code to separate    function to improve readability.    

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Ira Weiny
On Tue, 15 Dec 2009 10:16:42 -0500 Hal Rosenstock hal.rosenst...@gmail.com wrote: Ira, On Mon, Dec 14, 2009 at 7:43 PM, Ira Weiny wei...@llnl.gov wrote: Sasha, Hal, I have found that the following patch caused our SRP connected storage to break. What is causing the SRP target to

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Jason Gunthorpe
On Tue, Dec 15, 2009 at 09:18:19AM -0800, Ira Weiny wrote: On Tue, 15 Dec 2009 10:15:32 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: However, I don't understand the comment Only set HopLimit if going through a router? This is from '#ifdef ROUTER_EXP' days -

Re: SRP issues with OpenSM 3.3.3

2009-12-15 Thread Hal Rosenstock
On Tue, Dec 15, 2009 at 12:09 PM, Ira Weiny wei...@llnl.gov wrote: On Tue, 15 Dec 2009 10:16:42 -0500 Hal Rosenstock hal.rosenst...@gmail.com wrote: Ira, On Mon, Dec 14, 2009 at 7:43 PM, Ira Weiny wei...@llnl.gov wrote: Sasha, Hal, I have found that the following patch caused our SRP

SRP issues with OpenSM 3.3.3

2009-12-14 Thread Ira Weiny
Sasha, Hal, I have found that the following patch caused our SRP connected storage to break. patch: 3d20f82edd3246879063b77721d0bcef927bdc48 opensm/osm_sa_path_record.c: separate router guid resolution code Move off subnet destination (router address) resolution code to separate