Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-07-31 Thread Doug Ledford
On 07/31/2015 04:18 PM, Jason Gunthorpe wrote: > On Fri, Jul 31, 2015 at 01:41:39PM -0400, Doug Ledford wrote: >> Please be more specific here. What are you objecting to? Are you >> objecting to a flush_workqueue from a release() context? Because I >> don'

Re: [PATCH 0/3] IB/srp patches for Linux kernel v4.3

2015-08-01 Thread Doug Ledford
r-version-and-release-date.patch Got 'em, thanks! -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-01 Thread Doug Ledford
I've pulled in the series for 4.3. I've included patch #9, but that's on the understanding that if it can't be fixed before the initial pull request, I'll drop it at that time. I have the resources to test this, so I can work on it, and that factors into my path forward

Re: [PATCH v4 17/50] IB/hfi1: add PSM driver control/data path

2015-08-01 Thread Doug Ledford
On 07/31/2015 03:31 AM, Christoph Hellwig wrote: > On Thu, Jul 30, 2015 at 05:42:16PM -0400, Doug Ledford wrote: >> I have no problem with this code. That Al finds the user space ABI for >> this driver to be bizarre is neither here nor there to me. Sure, this >> file does no

Re: [PATCH v4 00/50] Add OPA gen1 driver

2015-08-01 Thread Doug Ledford
at the library can be written with soft-roce's needs in mind as well as the Intel driver's needs, then I'll let the hfi1 driver out of staging before that task is complete and we'll just get to the library when we have all of the stake holders in place and can actually work on all

Re: [PATCH V2] IB/sa: Restrict SA Netlink to admin users

2015-08-12 Thread Doug Ledford
e rather than ns_capable > > Doug, > > As per the thread with the V1 patch we are looking to merge this into a v9 of > Kaikes series once we do some more testing with the netlink_bind and > namespaces. > > So you can safely ignore both v1 and this patch. Ok. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [RFC] split struct ib_send_wr

2015-08-12 Thread Doug Ledford
ing their TODO list. In any case, I don't expect to have stuff from the RDMA core in staging for an extended amount of time. But right now there is, and for the way I'm using the staging area, *I* care if your patch breaks the drivers that are there. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [RFC] split struct ib_send_wr

2015-08-13 Thread Doug Ledford
ect way. > > Doug: was your mail a request to fix up the two de-staged drivers? > I'm happy to do that if you're fine with the patch in general. amso1100 > should be trivial anyway, while ipath is a mess, just like the new intel > driver with the third copy of the soft i

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-14 Thread Doug Ledford
On 08/11/2015 04:50 PM, Bart Van Assche wrote: > On 08/01/2015 01:05 PM, Doug Ledford wrote: >> On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: >>> On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: >>> >>>> With only patches 1/12 and 8/12 appl

Re: [PATCH] IB: Add additional info on CNP

2015-08-14 Thread Doug Ledford
is Dalessandro > Signed-off-by: Mike Marciniszyn Added to my hfi1-v4 branch -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly

2015-08-14 Thread Doug Ledford
Van Assche > Cc: Sagi Grimberg Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/mlx4: Fix memory leaks related to updating GIDs

2015-08-14 Thread Doug Ledford
; Fixes: fa417f7b520e ("IB/mlx4: Add support for IBoE") > Signed-off-by: Bart Van Assche > Cc: Eli Cohen > Cc: sta...@vger.kernel.org # v2.6.37 Thanks, I've picked this up. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] RDMA/ipath: Do not build ipath driver without infiniband subsystem

2015-08-14 Thread Doug Ledford
a broken build. > > Reviewed-by: Mike Marciniszyn > Signed-off-by: Dennis Dalessandro Picked up, thanks. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] RDMA/amso1100: Do not build amso1100 without infiniband subsystem

2015-08-14 Thread Doug Ledford
cked up, thanks. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v3] IB/srp: Do not create an all physical insecure rkey by default

2015-08-14 Thread Doug Ledford
iginal patchset, skipped this one, grabbed the 8 patch series from Bart and tacked it onto the branch with your other 11 patches. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/hfi1: Add Infiniband dependency to Kconfig

2015-08-14 Thread Doug Ledford
e Marciniszyn > Signed-off-by: Jubin John Picked up, thanks. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V1 1/3] IB/core: Access to one past end of array in _gid_table_setup_one

2015-08-14 Thread Doug Ledford
On 08/03/2015 09:09 AM, Matan Barak wrote: > The error flow of _gid_table_setup_one accessed table[port] when > port was 1-based instead of 0-based. > > Squash-into: 'IB/core: Add RoCE GID table management' > Signed-off-by: Matan Barak Squashed as requ

Re: [PATCH for-next V1 3/3] IB/core: Fix possible deadlock in write_gid

2015-08-14 Thread Doug Ledford
> Squash-into: 'IB/core: Add RoCE GID table management' > Signed-off-by: Matan Barak Squashed as requested. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/srp: Stop the scsi_eh_ and scsi_tmf_ threads if login fails

2015-08-14 Thread Doug Ledford
Krotov > Fixes: fb49c8bbaae7 ("Remove an extraneous scsi_host_put() from an error > path") > Signed-off-by: Bart Van Assche > Cc: Sagi Grimberg > Cc: Sebastian Parschauer > Cc: #v3.19 Thanks, added to the srp branch. -- Doug Ledford GPG KeyID: 0E57

Re: [PATCH for-next V1 2/3] IB/core: RoCE GID management separate cleanup and release

2015-08-14 Thread Doug Ledford
n Gunthorpe I reworded the commit message some, but the patch was good and makes sense. I've inserted it into the GID series and, as expected, it caused failures in the original "IB/core: Add RoCE GID table management" patch. However, the fixups for those failures seem

Re: [PATCH for-next V1 2/3] IB/core: RoCE GID management separate cleanup and release

2015-08-14 Thread Doug Ledford
> Squash-into: 'IB/core: Add RoCE GID table management' > Signed-off-by: Matan Barak I squashed this after applying Jason's follow-up patch first in the series and fixes up the conflicts. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v3 01/12] IB/core: Guarantee that a local_dma_lkey is available

2015-08-14 Thread Doug Ledford
Steve Wise > > I hit this bug as well. > > Reviewed-by: Ira Weiny > Tested-by: Ira Weiny I've pulled the v2 of this patch and replaced it with this one. Thanks. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v4 01/12] IB/core: Guarantee that a local_dma_lkey is available

2015-08-14 Thread Doug Ledford
a local use all physical memory MR associated > with the new PD. > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Sagi Grimberg > Acked-by: Christoph Hellwig > Reviewed-by: Steve Wise > Reviewed-by: Ira Weiny > Tested-by: Ira Weiny ...and then I switched it

Re: [PATCH] IB/core: Make ib_dealloc_pd return void

2015-08-14 Thread Doug Ledford
ror. And it's not out of the question (or even unlikely) that shifts in how people do transfer engines might result in lost allocations and this warning popping up. It serves as a final check on the ULP, and to me that has value. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v1 00/22] iser patches for 4.3

2015-08-14 Thread Doug Ledford
206 > drivers/infiniband/ulp/iser/iser_initiator.c | 34 +- > drivers/infiniband/ulp/iser/iser_memory.c| 480 > +++---- > drivers/infiniband/ulp/iser/iser_verbs.c | 328 ++ > 5 files changed, 645 insertions(+), 492 deletions(-) > I've pulled these in as a replacement for the v0 patches. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/ucma: Fix theoretical user triggered use-after-free

2015-08-14 Thread Doug Ledford
;> >> Fix it by latching the ref at 0. Once it goes to 0 mc and ctx cannot >> leave the mutex(mut) protection. >> >> The other atomic_inc in ucma_get_ctx is OK because mutex(mut) protects >> it from racing with ucma_destroy_id. >> >> Signed-off-by: Jason Gu

Re: [PATCH] IB/hfi1: Support ib_alloc_mr verb

2015-08-14 Thread Doug Ledford
On 08/07/2015 10:51 AM, Mike Marciniszyn wrote: > Ported from upstream qib commit > 68c02e232b8a ("qib: Support ib_alloc_mr verb") > > Tested-by: Jubin John > Reviewed-by: Jubin John > Signed-off-by: Mike Marciniszyn Added to the hfi1 branch. -- Doug Ledf

Re: [PATCH] svcrdma: limit FRMR page list lengths to device max

2015-08-14 Thread Doug Ledford
MEM_REG, num_sg); > if (IS_ERR(mr)) > goto err_free_frmr; > > pl = ib_alloc_fast_reg_page_list(xprt->sc_cm_id->device, > - RPCSVC_MAXPAGES); > + num_sg); > if (IS_ERR(pl)) > goto err_free_mr; > > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2] IB/hfi1: remove two files from /sys/class/infiniband

2015-08-14 Thread Doug Ledford
On 08/07/2015 12:30 PM, Mike Marciniszyn wrote: > From: Sadanand Warrier > > "version" and "localbus_info" are removed from the > hfi1 sysfs directory. > > Reviewed-by: Mike Marciniszyn > Signed-off-by: Sadanand Warrier Added to the hfi1 branch, than

Re: [PATCH] IB/mlx4: Fix possible incorrect cq completions flushing in internal error state

2015-08-14 Thread Doug Ledford
ns which includes ones which were not correctly set. > > Fixes: 35f05dabf95a (IB/mlx4: Reset flow support for IB kernel ULPs) > Signed-off-by: Ariel Nahum > Signed-off-by: Sagi Grimberg > Cc: Yishai Hadas Applied, thanks. -- Doug Ledford GPG KeyID: 0E572FD

Re: [PATCH v2] IB/hfi1: Remove inline from trace functions

2015-08-14 Thread Doug Ledford
Dalessandro This has been added to the hfi1 branch. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] RDMA/cma: fix IPv6 address resolution

2015-08-14 Thread Doug Ledford
e case when we have access >> to both the source IPv6 address and destination IPv6 address, we have to >> deal with this further up the stack. So detect this failure case in >> cma_bind_addr, and set bound_dev_if to the destination address scope id >> to correct it. >>

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-14 Thread Doug Ledford
On 08/14/2015 12:20 PM, Bart Van Assche wrote: > On 08/14/2015 06:36 AM, Doug Ledford wrote: >> On 08/11/2015 04:50 PM, Bart Van Assche wrote: >>> On 08/01/2015 01:05 PM, Doug Ledford wrote: >>>> On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: >>>>> O

Re: [PATCH] IB/core: Make ib_dealloc_pd return void

2015-08-14 Thread Doug Ledford
> On Aug 14, 2015, at 10:27 PM, Jason Gunthorpe > wrote: > > On Fri, Aug 14, 2015 at 09:05:07PM -0400, Doug Ledford wrote: > >> I'm not sure I like this patch. I have my concerns that this will >> make debugging and catching problems more difficult. > [..]

Re: [PATCH for-next V2 4/4] IB/core: RoCE GID management separate cleanup and release

2015-08-15 Thread Doug Ledford
device->cache.pkey_cache[p] = NULL; For instance this goes away entirely by using kzalloc(). The rest looked ok. I have to fixup the ordering changes between sysfs and cache to make the v1 patch match the v2 patch. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V2 4/4] IB/core: RoCE GID management separate cleanup and release

2015-08-16 Thread Doug Ledford
On 08/16/2015 04:19 AM, Matan Barak wrote: > > > On 8/15/2015 5:14 PM, Doug Ledford wrote: >> On 08/06/2015 01:14 PM, Matan Barak wrote: >>> Separate the cleanup and release IB cache functions. >>> The cleanup function delete all GIDs and unregister the eve

Re: [PATCH for-next V2 4/4] IB/core: RoCE GID management separate cleanup and release

2015-08-16 Thread Doug Ledford
On 08/16/2015 12:24 PM, Doug Ledford wrote: > On 08/16/2015 04:19 AM, Matan Barak wrote: >> >> >> On 8/15/2015 5:14 PM, Doug Ledford wrote: >>> On 08/06/2015 01:14 PM, Matan Barak wrote: >>>> Separate the cleanup and release IB cache functions. >

[PULL REQUEST] please pull rdma.git

2015-08-17 Thread Doug Ledford
iw_cxgb4 Hariprasad S (1): iw_cxgb4: gracefully handle unknown CQE status errors drivers/infiniband/hw/cxgb4/cq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) — Doug Ledford GPG Key ID: 0E572FDD

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
ause it’s >50,000 lines of code, so repeated patch submissions to the mailing list were absolutely painful, but it has work that needs done as a result of review comments, and one item of work in particular (converting it to use an RDMA transfer engine library) will take a lot o

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-08-18 Thread Doug Ledford
I haven’t sent any pull requests for this yet. My github repo is in 0day testing, but my k.o repo is the one in linux-next testing and I haven’t pushed this to k.o as of yet. > Doug, can you respond to why staging and get this patch into your repo? I can certainly add this to the hfi1 branch in my tree. I answered why I put this in staging in my previous email. — Doug Ledford GPG Key ID: 0E572FDD signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
> On Aug 18, 2015, at 4:11 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 10:00:39AM -0700, Doug Ledford wrote: >> >>> On Aug 18, 2015, at 9:50 AM, Greg KH wrote: >>> >>> On Tue, Aug 18, 2015 at 04:29:50PM +, Marciniszyn, Mike wrote: >>>

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
> On Aug 18, 2015, at 7:49 PM, Greg KH wrote: > > On Tue, Aug 18, 2015 at 06:24:40PM -0700, Doug Ledford wrote: >> >> >>> Are >>> you going to be responsible for all of the patches sent to it and you >>> just want me to ignore them, or will you

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-08-18 Thread Doug Ledford
gt;> the maintainer entry for the directory and redirect it to linux-rdma, >> and delete it when this work has passed. > > That sounds like a good plan to me. I’ll rebase my tree and fix it up. — Doug Ledford GPG Key ID: 0E572FDD signature.asc Description: Message signed with OpenPGP using GPGMail

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Doug Ledford
spin_lock_irq(&priv->lock); > + ipoib_mcast_join(dev, mcast); > } else if (!delay_until || > time_before(mcast->delay_until, delay_until)) > delay_until = mcast->delay_until; > @@ -616,9 +631,9 @@ out: > init_completion(&mcast->done); > set_bit(IPOIB_MCAST_FLAG_BUSY, &mcast->flags); > } > - spin_unlock_irq(&priv->lock); > if (mcast) > - ipoib_mcast_join(dev, mcast, create); > + ipoib_mcast_join(dev, mcast); > + spin_unlock_irq(&priv->lock); > } > > int ipoib_mcast_start_thread(struct net_device *dev) > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Doug Ledford
On 08/25/2015 02:22 PM, Jason Gunthorpe wrote: > On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: >> On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: >>> Even though we don't expect the group to be created by the SM we >>> sill need to provide all t

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-26 Thread Doug Ledford
On 08/25/2015 03:49 PM, Jason Gunthorpe wrote: > On Tue, Aug 25, 2015 at 02:35:27PM -0400, Doug Ledford wrote: >> On 08/25/2015 02:22 PM, Jason Gunthorpe wrote: >>> On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: >>>> On 08/21/2015 07:34 PM, Jason Gunt

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-26 Thread Doug Ledford
On 08/26/2015 12:18 PM, Jason Gunthorpe wrote: > On Wed, Aug 26, 2015 at 09:37:50AM -0400, Doug Ledford wrote: > >>> Sure looks like these two race: >>> >>> if (test_and_set_bit(IPOIB_MCAST_FLAG_ATTACHED, >>> &mcast->flags)).. >>

Re: [patch] IB/core: off by one in error handling

2015-08-28 Thread Doug Ledford
;> +for (port = 0; port < ib_dev->phys_port_cnt; port++) >> free_gid_table(ib_dev, port, table[port]); >> >> kfree(table); > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [patch] IB/core: missing curly braces in ib_find_gid()

2015-08-28 Thread Doug Ledford
x27;) >> Signed-off-by: Dan Carpenter >> > > Reviewed-by: Ira Weiny I've picked this patch up (earlier today), so I missed your reviewed-by: tag. Added. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

mlx4 problems with 4.2-rc8

2015-08-28 Thread Doug Ledford
gning an EQ to \xfff\xffb6Z6 \xff88\x\x\xff84\xffa20\xff81\x\x\x\x [ 78.243732] mlx4_en: mlx4_roce: Failed activating Rx CQ [ 78.319027] mlx4_en: mlx4_roce: Failed starting port:2 The interface in question is unusable. --

Re: [patch] IB/core: missing curly braces in ib_find_gid()

2015-08-30 Thread Doug Ledford
On 08/30/2015 12:59 AM, Or Gerlitz wrote: > On Fri, Aug 28, 2015 at 9:02 PM, Doug Ledford wrote: >> On 08/28/2015 09:10 PM, ira.weiny wrote: >>> On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote: >>>> Smatch says that, based on the indenting, we should

Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-08-30 Thread Doug Ledford
IB/cma: Use found net_dev for passive connections") > > same here, Doug, Same as the last email, I have the commit ID now, and I fixed up the commit message. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: mlx4 problems with 4.2-rc8

2015-08-30 Thread Doug Ledford
On 08/29/2015 09:13 PM, Or Gerlitz wrote: > On Fri, Aug 28, 2015 at 10:27 PM, Doug Ledford wrote: >> I'm seeing this with rc8 on a dual port mlx4 adapter set to IB/Eth mode: > > mmm, both Amir and myself are just finishing vacations... so WB notes > are not always lovely

Re: mlx4 problems with 4.2-rc8

2015-08-31 Thread Doug Ledford
On 08/31/2015 03:09 AM, Matan Barak wrote: > > > On 8/31/2015 1:38 AM, Doug Ledford wrote: >> On 08/29/2015 09:13 PM, Or Gerlitz wrote: >>> On Fri, Aug 28, 2015 at 10:27 PM, Doug Ledford >>> wrote: >>>> I'm seeing this with rc8 on a dual port

Re: mlx4 problems with 4.2-rc8

2015-08-31 Thread Doug Ledford
On 08/31/2015 04:21 PM, Or Gerlitz wrote: > On Mon, Aug 31, 2015 at 4:02 PM, Doug Ledford wrote: >> On 08/31/2015 03:09 AM, Matan Barak wrote: > >>> Actually, it looks like the dump stack we've got before [1] was fixed. >>> This happens when the mlx4 drive

Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-08-31 Thread Doug Ledford
pt for this issue. > > Let me know which branch I should base these changes off of. Base if off of the k.o/for-4.3. That's where it will go. I'll just end up applying this to the top of the stack. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: shrink struct ib_send_wr V3

2015-08-31 Thread Doug Ledford
cleanup branch. > > I do not plan to resend the series until the merge window for 4.4 > is open. Doug, any chance you could pick up the first patch in the > series for 4.3-rc? It's marked for stable as well. Yes, I can do that. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: mlx4 problems with 4.2-rc8

2015-09-01 Thread Doug Ledford
I needed to move it from a RHEL kernel to an upstream kernel to isolate a different issue, and hence I ran across this problem. My more common test machines would have never seen the issue I reported. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
rt > IB host channel adapter (model QHT7140), > The ipath driver was moved to staging/rdma/ipath and has proper protection against being built without the InfiniBand subsystem. Where are you seeing this tree? I'm curious because I no longer have this driver in this location in my

Re: [PATCH] staging: ipath: fix build failure

2015-09-01 Thread Doug Ledford
On 09/01/2015 12:54 PM, Jim Davis wrote: > On Tue, Sep 1, 2015 at 7:52 AM, Doug Ledford wrote: >> On 09/01/2015 09:01 AM, Sudip Mukherjee wrote: >>> building of ipath depends on infiniband. And if ipath is selected and >>> infiniband is not then build fails with:

Re: [GIT PULL] pull request v2: linux-firmware: Add Intel OPA hfi1 firmware

2015-09-02 Thread Doug Ledford
On 08/24/2015 11:28 AM, ira.weiny wrote: > git://github.com/weiny2/linux-firmware.git master-hfi1-firmware-v2 Should this go through me or though the linux-firmware tree? -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [GIT PULL] pull request v2: linux-firmware: Add Intel OPA hfi1 firmware

2015-09-03 Thread Doug Ledford
mainly intended for firmware for which we have source and which can be rebuilt, but my information on that may be out of date), but this is for the linux-firmware tree. I have no git access to that repo, so it's not something I can commit. I'm not sure who takes care of that. -- Doug L

Re: [patch] IB/core: missing curly braces in ib_find_gid()

2015-09-03 Thread Doug Ledford
t; +NULL, index)) { > *port_num = port; > return 0; > + } > } > > for (i = 0; i < device->port_immutable[port].gid

Re: [patch] IB/core: off by one in error handling

2015-09-03 Thread Doug Ledford
2,7 +582,7 @@ static int _gid_table_setup_one(struct ib_device *ib_dev) > return 0; > > rollback_table_setup: > - for (port = 1; port <= ib_dev->phys_port_cnt; port++) > + for (port = 0; port < ib_dev->phys_port_cnt; port++) > free_gid_table(

Re: [PATCH] MAINTAINERS: Add maintainer section for hfi1

2015-09-03 Thread Doug Ledford
fi1 > + > STARFIRE/DURALAN NETWORK DRIVER > M: Ion Badulescu > S: Odd Fixes > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] Kconfig: add temporary PCI dependency

2015-09-03 Thread Doug Ledford
;& INFINIBAND && PCI > default m > ---help--- > This is a low-level driver for Intel OPA Gen1 adapter. > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] staging/hfi1: replace indent spaces with tabs

2015-09-03 Thread Doug Ledford
const struct opa_mad *in_mad, > + struct opa_mad *out_mad, size_t *out_mad_size, > + u16 *out_mad_pkey_index) > { > int ret; > int pkey_idx; > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-09-03 Thread Doug Ledford
t; id_priv = cma_find_listener(bind_list, cm_id, ib_event, &req, *net_dev); > + if (IS_ERR(id_priv)) { > + dev_put(*net_dev); > + *net_dev = NULL; > + } > > return id_priv; > } > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] infiniband:cxgb4:Fix if statement check in the function pick_local_ip6adddrs

2015-09-03 Thread Doug Ledford
FA_F_TENTATIVE)) { > + if (!get_lladdr(dev->rdev.lldi.ports[0], &addr, IFA_F_TENTATIVE)) { > memcpy(la6->sin6_addr.s6_addr, &addr, 16); > memcpy(ra6->sin6_addr.s6_addr, &addr, 16); > return 0; > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: shrink struct ib_send_wr V3

2015-09-03 Thread Doug Ledford
On 08/31/2015 08:24 PM, Doug Ledford wrote: > On 08/31/2015 12:11 PM, Christoph Hellwig wrote: >> On Sun, Aug 30, 2015 at 06:31:35PM +0300, Sagi Grimberg wrote: >>>> - patch 2 now explicitly replaces the weird overloading in the mlx5 >>>> driver wit

Re: [PATCH] IB/mlx5: avoid destroying a NULL mr in reg_user_mr error flow

2015-09-03 Thread Doug Ledford
roy. >> >> Remove the clean_mr() call and the incorrect comment above it. >> >> Fixes: b4cfe447d47b ("IB/mlx5: Implement on demand paging by adding >> support for MMU notifiers") >> Cc: Eli Cohen >> Signed-off-by: Haggai Eran Thanks, applied

Re: [PATCH v1] mlx5: Fix incorrect wc pkey_index assignment for GSI messages

2015-09-03 Thread Doug Ledford
t; MLX5_MAX_UMR_SHIFT) > > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c > index 9380d2d..8c51ea3 100644 > --- a/drivers/infiniband/hw/mlx5/qp.c > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -76,11 +76,6 @@ static int is_qp0(enum ib_qp_type qp_typ

Re: [PATCH] IB/hfi1: Add CSRs for CONFIG_SDMA_VERBOSITY

2015-09-03 Thread Doug Ledford
HED_CNT)); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/hfi1: Add PSM2 user space header to header_install

2015-09-03 Thread Doug Ledford
a_netlink.h > header-y += rdma_user_cm.h > +header-y += hfi/ > diff --git a/include/uapi/rdma/hfi/Kbuild b/include/uapi/rdma/hfi/Kbuild > new file mode 100644 > index ..ef23c294fc71 > --- /dev/null > +++ b/include/uapi/rdma/hfi/Kbuild > @@ -0,0 +1,2 @@ > +# UAPI

Re: [PATCH 1/2] IB/core: Remove unnecessary defines from ib_mad.h

2015-09-03 Thread Doug Ledford
(1 << 5) > -#define IB_NOTICE_REPRESS_BAD_PKEY (1 << 6) > -#define IB_NOTICE_REPRESS_BAD_QKEY (1 << 7) > - > -/* > * Generic trap/notice other local changes flags (trap 144). > */ > #define IB_NOTICE_TRAP_LSE_CHG 0x04/* Link Speed Enable > changed */ > Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH V2 2/2] IB/core: Move SM class defines from ib_mad.h to ib_smi.h

2015-09-03 Thread Doug Ledford
b347005fb ("IB/core: Add core header changes needed for OPA") > Reviewed-by: Hal Rosenstock > Signed-off-by: Ira Weiny > > --- > Changes from V1: > Fix Nits from Hal Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/srp: Fix possible use-after-free

2015-09-03 Thread Doug Ledford
On 08/12/2015 02:31 AM, Sagi Grimberg wrote: > > Looks better, I'll resubmit. For some reason I don't have the email for the v1 of this patchset in my mail. It must have gotten accidentally deleted. In any case, v1 was applied. -- Doug Ledford GPG

Re: [PATCH] RDMA/cma: fix IPv6 address resolution

2015-09-03 Thread Doug Ledford
p; > IPV6_ADDR_LINKLOCAL) > + id->route.addr.dev_addr.bound_dev_if = > dst_addr6->sin6_scope_id; > } else if (dst_addr->sa_family == AF_IB) { > ((struct sockaddr_ib *) src_addr)->sib_pkey = > ((struct sockaddr_ib *) dst_addr)->sib_pkey; > Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2] xprtrdma: take HCA driver refcount at client

2015-09-03 Thread Doug Ledford
(rc) { > dprintk("RPC: %s: rdma_create_qp failed %i\n", > __func__, rc); > - rdma_destroy_id(id); > + rpcrdma_destroy_id(id); > rc = -ENETUNREACH; > goto out; > } > @@ -845,7 +867,7 @@ retry: > write_unlock(&ia->ri_qplock); > > rdma_destroy_qp(old); > - rdma_destroy_id(old); > + rpcrdma_destroy_id(old); > } else { > dprintk("RPC: %s: connecting...\n", __func__); > rc = rdma_create_qp(ia->ri_id, ia->ri_pd, &ep->rep_attr); > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH v2] xprtrdma: take HCA driver refcount at client

2015-09-03 Thread Doug Ledford
On 09/03/2015 04:24 PM, Anna Schumaker wrote: > Hi Doug, > > On 09/03/2015 04:11 PM, Doug Ledford wrote: >> On 07/30/2015 07:00 AM, Devesh Sharma wrote: >>> Thanks Chuck Lever for the valuable feedback and suggestions. >>> >>> This is a rework of t

Re: [GIT PULL] pull request v2: linux-firmware: Add Intel OPA hfi1 firmware

2015-09-03 Thread Doug Ledford
me look over > the license text and then I'll be right with you. > > (linux-firmware@ isn't a list because of vger rules about attachment > size and such, it just goes to dwmw2, ben hutchings and myself.) > > cheers, --Kyle Thanks Kyle :-) -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH] IB/ipoib: CSUM support in connected mode

2015-09-03 Thread Doug Ledford
gt; modifies the wire format, how it modifies the wire format, and also > which feedback (if any) has been received so far from the IETF. There hasn't been any follow up on this patch in the last month. Yuval, is there still progress being made? -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Doug Ledford
On 08/27/2015 07:33 PM, Jason Gunthorpe wrote: > On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: > >> That still takes us back to the fact that the locking changes are >> unneeded. I'm not opposed to them, but as you mentioned in your first >> email, th

Re: [PATCH 2/2] IB/ipoib: Suppress warning for send only join failures

2015-09-03 Thread Doug Ledford
> to 224.0.0.22, and then a warning level kmessage like this: > > ib0: sendonly multicast join failed for > ff12:401b::::::0016, status -22 > > If there is no IP router listening to IGMP. > > Signed-off-by: Jason Gunthorpe Thanks, applied. --

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Doug Ledford
On 09/03/2015 05:23 PM, Jason Gunthorpe wrote: > On Thu, Sep 03, 2015 at 05:17:31PM -0400, Doug Ledford wrote: >> On 08/27/2015 07:33 PM, Jason Gunthorpe wrote: >>> On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: >>> >>>> That still takes us ba

Re: [PATCH] infiniband:Fix error checking in the function ocrdma_dereg_mr

2015-09-04 Thread Doug Ledford
t;device); > + int ret = 0; > > - (void) ocrdma_mbx_dealloc_lkey(dev, mr->hwmr.fr_mr, mr->hwmr.lkey); > + ret = ocrdma_mbx_dealloc_lkey(dev, mr->hwmr.fr_mr, mr->hwmr.lkey); > + if (ret) > + return ret; > > ocrdma_free_mr_p

Re: [PATCH v1 0/3] libibverbs: On-demand paging support

2015-09-04 Thread Doug Ledford
src/cmd.c | 147 > ++++++ > src/libibverbs.map| 2 + > 10 files changed, 420 insertions(+), 94 deletions(-) > create mode 100644 man/ibv_query_device_ex.3 > -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP digital signature

[PATCH libibverbs] Fix create/destroy flow API

2015-09-04 Thread Doug Ledford
way as to preserve both back and forward compatibility. Fixes: 389de6a6ef4e (Add receive flow steering support) Signed-off-by: Doug Ledford --- include/infiniband/verbs.h | 25 +++-- src/device.c | 22 +- 2 files changed, 24 insertions(+), 23

Re: [PATCH v1 0/3] libibverbs: On-demand paging support

2015-09-04 Thread Doug Ledford
On 09/04/2015 04:42 PM, Jason Gunthorpe wrote: > On Fri, Sep 04, 2015 at 04:23:05PM -0400, Doug Ledford wrote: >> On 09/03/2015 10:56 AM, Haggai Eran wrote: >>> This series adds userspace support for on-demand paging. The first patch >>> adds >>> support fo

Re: [PATCH libibverbs] Fix create/destroy flow API

2015-09-04 Thread Doug Ledford
On 09/04/2015 05:32 PM, Jason Gunthorpe wrote: > On Fri, Sep 04, 2015 at 05:17:38PM -0400, Doug Ledford wrote: >> +/* >> + * In order to maintain backward/forward binary compatibility >> + * with libmlx4-1.0.6, which has the or

Re: [PATCH libibverbs] Fix create/destroy flow API

2015-09-04 Thread Doug Ledford
On 09/04/2015 05:51 PM, Doug Ledford wrote: > On 09/04/2015 05:32 PM, Jason Gunthorpe wrote: >> On Fri, Sep 04, 2015 at 05:17:38PM -0400, Doug Ledford wrote: >>> + /* >>> +* In order to maintain backward/forward binary compatibility >>&g

Re: [PATCH libibverbs] Add support for TX/RX checksum offload

2015-09-04 Thread Doug Ledford
data in given gather list as inline data > in a send WQE. Valid only for Send and RDMA Write. The L_Key will not be > checked. > ++.TP > ++.B IBV_SEND_IP_CSUM \fR Offload the IPv4 and TCP/UDP checksum calculation. > ++Valid only for QPs with Transport Service Type \fBIBV_QPT_UD\

Re: [PATCH v1 0/3] libibverbs: On-demand paging support

2015-09-04 Thread Doug Ledford
vice_attr_ex struct. > > Eli Cohen (1): > Add support for extended query device capabilities > > Haggai Eran (1): > Add on-demand paging support > > Majd Dibbiny (1): > libibverbs/examples: Support odp in rc_pingpong Hi Haggai, Series applied, thanks. --

Re: [PATCH v1 0/3] libibverbs: On-demand paging support

2015-09-05 Thread Doug Ledford
> On Sep 5, 2015, at 1:27 PM, Or Gerlitz wrote: > > On Sat, Sep 5, 2015 at 2:43 AM, Doug Ledford wrote: >> Series applied, thanks. > > Doug, a user-space related note, in LPC you made a comment that the > user space RoCE UD patches are broken with libnl3, well, tal

[PULL REQUEST] Please pull rdma.git

2015-09-08 Thread Doug Ledford
needed for OPA Doug Ledford (3): Staging: Add staging/rdma directory and update MAINTAINERS IB/core: Remove needless bracketization IB/ipoib: Clean up send-only multicast joins Guy Shapiro (1): IB/ipoib: Return IPoIB devices matching connection parameters Haggai Eran (14)

Re: [PULL REQUEST] Please pull rdma.git

2015-09-08 Thread Doug Ledford
On 09/08/2015 08:21 PM, Linus Torvalds wrote: > On Tue, Sep 8, 2015 at 9:24 AM, Doug Ledford wrote: >> >> Matan Barak (5): >> net: Add info for NETDEV_CHANGEUPPER event > > Why the hell is this coming in through the infiniband tree? Especially > with the n

Re: [PULL REQUEST] Please pull rdma.git

2015-09-08 Thread Doug Ledford
t count of how many conflicts > I've resolved in just this merge window. I do it all the time. But > this one made me just go "Eww". > > The rebase and the complete lack of communication here just makes me angry. As mentioned in my previous email, the rebase is because Ste

Re: [PULL REQUEST] Please pull rdma.git

2015-09-08 Thread Doug Ledford
On 09/08/2015 11:08 PM, Linus Torvalds wrote: > On Tue, Sep 8, 2015 at 7:50 PM, Doug Ledford wrote: >> >> Because the tree isn't buildable, let alone testable, without it. > > You're missing the ENTIRE POINT. > >> Well, I expected it to be handled wit

Re: [PULL REQUEST] Please pull rdma.git

2015-09-09 Thread Doug Ledford
Side note: it's very annoying to have Time Warner Cable decide to take your internet down in the middle of writing a reply :-/ On 09/08/2015 11:33 PM, Linus Torvalds wrote: > On Tue, Sep 8, 2015 at 8:08 PM, Doug Ledford wrote: >> >> With a comment that said "I can car

Re: [PATCH libibverbs] Add support for TX/RX checksum offload

2015-09-09 Thread Doug Ledford
On 09/05/2015 03:59 PM, Or Gerlitz wrote: > On Sat, Sep 5, 2015 at 2:41 AM, Doug Ledford wrote: >> On 08/17/2015 11:50 AM, Bodong Wang wrote: >>> Add a device capability flag IBV_DEVICE_IP_CSUM to denote IPv4 checksum >>> offload support. Devices should set this flag if

<    1   2   3   4   5   6   7   8   >