[PATCH V2 7/9] ib/pma: add include file for IBA performance counters definitions

2011-07-05 Thread Or Gerlitz
Move the various definitions and mad structures needed for software implementation of IBA PM agent from the ipath and qib drivers into a single include file, which in turn could be used by more consumers. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il --- Roland, this adds a section which

Re: [PATCH V1 7/9] ib/pma: add include file for IBA performance counters definitions

2011-07-07 Thread Or Gerlitz
Roland Dreier wrote: I can rereview the patch intoto if this is needed. If you wouldn't mind, that would be great. I would like to get a solution for qib in the tree but as I said I don't like stealing reserved bits, and I'm not confident I know the tradeoffs here. Roland, MiKe Reading

opensm logs can go anywhere in size?

2011-07-07 Thread Or Gerlitz
Hi Alex, I just noted that opensm logs can go anywhere in size when one of my nodes had no space left on device after the opensm log level was raised... I see that the rpm provided with RHEL6 is setting an /etc/logrotate.d/opensm entry which is a copy of ./scripts/opensm.logrotate from the

[PATCH V1 4/9] mlx4: align current extended capabilities to use the flags field

2011-07-07 Thread Or Gerlitz
the extended device cap flags field instead of a field per extended capability. Initial patch done by Eli Cohen e...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il changes from v0: fixed sparse warnings --- drivers/net/mlx4/en_ethtool.c |9 + drivers/net/mlx4

Re: [RFC 0/9] Change the copyright info.

2011-07-10 Thread Or Gerlitz
Justin P. Mattock wrote: Below you will find a set of patches, that update the copyright info from Sun Microsystems to Oracle. should make changes.. Please let me know if I missed anything and/or You have sent these patches last year, and the approach was rejected (e.g see

Re: IBoE updates - GID change event / network flow counters (was: [PATCH 7/9] ib/pma: add include file for IBA perf counters)

2011-07-16 Thread Or Gerlitz
On Mon, Jun 20, 2011 at 9:18 PM, Roland Dreier rol...@kernel.org wrote: Or Gerlitz ogerl...@mellanox.com wrote: Roland, My patch series went through Sean's review (and passed... patch 7/9 needed fixes and I posted V1 for it) any more feedback you need to accept them or you just want to go

[PATCH 0/7] IBoE user space support

2011-07-19 Thread Or Gerlitz
Roland, the enclosed patch series enhances the user space IB stack to support IBoE. This work is based on earlier patches done by Eli Cohen e...@mellanox.co.il and posted during August/2010 see some pointers below. One notable change from the previous post, is keeping the UD related resolution

[PATCH 1/7] libibverbs: Add link layer field port attribute

2011-07-19 Thread Or Gerlitz
their IB code path. The solution was suggested by: Roland Dreier rol...@purestorage.com and Jason Gunthorpe jguntho...@obsidianresearch.com Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e...@mellanox.co.il --- include/infiniband/verbs.h | 21 + man

[PATCH 2/7] libibverbs: change kernel API to accept link layer

2011-07-19 Thread Or Gerlitz
-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e...@mellanox.co.il --- include/infiniband/kern-abi.h |3 ++- src/cmd.c |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/infiniband/kern-abi.h b/include/infiniband/kern-abi.h index

[PATCH 3/7] libibverbs: add GID change event

2011-07-19 Thread Or Gerlitz
Add IB GID change event which is generated by the kernel IBoE stack when the HW driver updates the GID table. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e...@mellanox.co.il --- examples/asyncwatch.c |2 ++ include/infiniband/verbs.h |3 ++- man

[PATCH 4/7] libibverbs: Update examples for IBoE

2011-07-19 Thread Or Gerlitz
Since IBoE requires usage of GRH, update ibv_*_pinpong examples to accept GIDs. GIDs are given as an index to the local port's table and are exchanged between the client and the server through the socket connection. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e

[PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Or Gerlitz
Modify libmlx4 to support IBoE, where the only user space piece to handle is the creation of UD address handles - the L2 Ethernet attributes have to be resolved from the DGID. Derived from work by Eli Cohen e...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.h

[PATCH 6/7] libmlx4: add IBoE UD/VLANs support

2011-07-19 Thread Or Gerlitz
Add VLANs support for the UD address handle creation flow, where the vlan id is taken from the destination GID and the and vlan priority from the IB SL specified by the application. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/mlx4.h |1 + src/qp.c|1 + src/verbs.c |9

[PATCH 7/7] libmlx4: align the list of ConnectX devices supported with the kernel

2011-07-19 Thread Or Gerlitz
align the list of ConnectX devices supported by the library to be the same as the mlx4 driver from the upstream kernel Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- Roland, these two simple awk/cut commands can be used to actually validate the claim made by the change log... $ grep

Re: [PATCH 3/7] libibverbs: add GID change event

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: You also need to update ibv_event_type_str sure, will do that. Has a kernel patch that reserves/uses the corresponding ID been accepted yet? yes, its in Roland's for-next branch BTW, this has value for straight IB, hopefully it

Re: [PATCH 4/7] libibverbs: Update examples for IBoE

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Since IBoE requires usage of GRH, update ibv_*_pinpong examples to accept GIDs. GIDs are given as an index to the local port's table and are exchanged between the client and the server through the socket connection. Since these examples

Re: [PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Or Gerlitz wrote: Jason, as the change log explains, under Ethernet link type the code (see mlx4_resolve_grh_to_l2) goes and extracts the Ethernet L2 info (mac and vlan, look on the last patch) from the GID. Looking at the control flow

Re: [PATCH 1/7] libibverbs: Add link layer field port attribute

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Or Gerlitz wrote: What zeros the field in the current library? + port_attr-link_layer = IBV_LINK_LAYER_UNSPECIFIED; + port_attr-pad = 0; Or -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body

Re: [PATCH 1/7] libibverbs: Add link layer field port attribute

2011-07-20 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: The commit comment states the goal is to have new apps see IBV_LINK_LAYER_UNSPECIFIED for all possible combinations of old stuff underneath. [...] The problem is with the userspace ABI out of libibverbs. Current libibverbs does not

Re: [PATCH 1/7] libibverbs: Add link layer field port attribute

2011-07-20 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Or Gerlitz wrote: Jason Gunthorpe jguntho...@obsidianresearch.com wrote: +#define ibv_query_port(context, port_num, port_attr) \ +       ___ibv_query_port(context, port_num, port_attr) + So we are okay now, correct? Looks like! Sorry

Re: [PATCH 1/7] libibverbs: Add link layer field port attribute

2011-07-20 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Yes, that was the only important thing I saw. I assume Roland was happy with the #define trick for compatibility last time it came up? yes, that's correct. Looking at the diff, maybe re-shuffle the order of the #define trick so it is

[PATCH V1 1/7] libibverbs: Add link layer field port attribute

2011-07-20 Thread Or Gerlitz
their IB code path. The solution was suggested by: Roland Dreier rol...@purestorage.com and Jason Gunthorpe jguntho...@obsidianresearch.com Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e...@mellanox.co.il --- changes from V0: - applied feedback from Jason, made

[PATCH V1 3/7] libibverbs: add GID change event

2011-07-20 Thread Or Gerlitz
Add IB GID change event which is generated by the kernel IBoE stack when the HW driver updates the GID table. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il Signed-off-by: Eli Cohen e...@mellanox.co.il --- changes from V0: - applied feedback from Jason, added entry to ibv_event_type_str

Re: [PATCH 0/7] IBoE user space support

2011-07-20 Thread Or Gerlitz
Or Gerlitz ogerl...@mellanox.com wrote: the enclosed patch series enhances the user space IB stack to support IBoE. [PATCH 1/7] libibverbs: Add link layer field port attribute [PATCH 2/7] libibverbs: change kernel API to accept link layer [PATCH 3/7] libibverbs: add GID change event [PATCH

[PATCH 1/2 for-3.1] ib/iser: fix wrong mask when sizeof (dma_addr_t) sizeof (unsigned long)

2011-08-01 Thread Or Gerlitz
. This resolves a crash in iser_sg_to_page_vec on this system. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il --- diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h index 342cbc1..db6f3ce 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.h +++ b/drivers

[PATCH 2/2 for-3.1] ib/iser: support iSCSI PDU padding

2011-08-01 Thread Or Gerlitz
RFC3270 mandates that iSCSI PDUs are padded to the closest integer number of four byte words. Enhance the iser code to support that on both the TX/RX flows. Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il --- diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser

Re: [PATCH 0/7] IBoE user space support

2011-09-05 Thread Or Gerlitz
On Wed, Jul 20, 2011 at 10:43 PM, Or Gerlitz or.gerl...@gmail.com wrote: the enclosed patch series enhances the user space IB stack to support IBoE. [PATCH 1/7] libibverbs: Add link layer field port attribute [PATCH 2/7] libibverbs: change kernel API to accept link layer [PATCH 3/7] libibverbs

Re: [PATCH 0/7] IBoE user space support

2011-09-06 Thread Or Gerlitz
All the IBoE userspace patches should be applied and pushed out. Let me know if I missed anything. Yes, thanks, I see them now, I just didn't notice an explicit ack from you over the list which made me think there's not there yet, sure, I'll test with clones of your trees and let you know. Or.

Re: [PATCH 0/20 v2] rdma: Add XRC support

2011-09-14 Thread Or Gerlitz
On 9/15/2011 1:01 AM, Roland Dreier wrote: Sorry, haven't been very productive, partially due to patchwork being down (along with the rest of kernel.org). So not much to report... Roland, Sean was saying (SB) that he has them on the ofa git, so in case you have a local clone, maybe you can

Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Or Gerlitz
Hal Rosenstock hal.rosenst...@gmail.com wrote: Hefty, Sean sean.he...@intel.com wrote: That's was an issue with the wire protocol format, correct? Right. Why carry that same concept into a software interface?  It seems complex. So as not to break existing verbs apps by inventing new

Re: [PATCH/RFC] mlx4_core: Clean up error flow in mlx4_register_mac()

2011-09-21 Thread Or Gerlitz
On 9/20/2011 10:53 AM, Roland Dreier wrote: Fix a leak of entry if radix_tree_insert() fails. Also, reduce the indentation and make the flow easier to read Looks fine to me Acked-by: Or Gerlitz ogerl...@mellanox.com Yevgeny? Or. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH for-3.2 v2 1/5] ib/core: Add extended link speeds

2011-10-08 Thread Or Gerlitz
On Wed, Oct 5, 2011 at 8:40 PM, Hefty, Sean sean.he...@intel.com wrote: The following extended speeds are introduced: FDR-10  - is a proprietary link speed which is 10.3125 Gbps at 64/66 encoding rather FDR     - represents the IBA extended speed: 14.0625 Gbps. EDR     - represents the IBA

Re: [PATCH for-3.2 v2 1/5] ib/core: Add extended link speeds

2011-10-08 Thread Or Gerlitz
On Sat, Oct 8, 2011 at 10:40 PM, Or Gerlitz or.gerl...@gmail.com wrote: I was under the misconception that the top (Linus) mainline kernel is under hold as of the kernel.org being down, upto two days ago when I noted that the first github hit for Linux is Linus tree which is @ -rc9, anyway

[PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-10 Thread Or Gerlitz
Enable the maximum size (128) supported by the device for the shadow vlans table, without a module param to override it. This table is only used by the IBoE control plane for setting a vlan index into an RC/UC QP context or UD Address Handle. Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-10-10 Thread Or Gerlitz
issue a PMA classportinfo query towards the HW driver, and if extended counters are supported, expose new sysfs entries which allow to read them. Signed-off-by: Vu Pham v...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- --- drivers/infiniband/core/sysfs.c | 100

[PATCH 5/5] ib/mlx4: added support for extended PMA counters under IBoE

2011-10-10 Thread Or Gerlitz
With the HW counters being 64bit ones, use the existing IBoE PMA counters to support also extended counters. Signed-off-by: Vu Pham v...@mellanox.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/mad.c | 49 - 1 files changed

Re: [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-11 Thread Or Gerlitz
On 10/10/2011 7:00 PM, Roland Dreier wrote: Can we really do this? Doesn't this break anyone who has this option configured in modprobe.conf? This is one reason why I hate adding module parameters -- you can't just delete them later like this Yes, I now understand even better why you hate

Re: [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-11 Thread Or Gerlitz
On Tue, Oct 11, 2011 at 7:28 PM, Roland Dreier rol...@kernel.org wrote: No, I think we need to switch to ignoring the parameter and printing a warning if someone sets it, and then we can remove it in a year or so. no problem, I don't think I will be able to send such patch before Sunday, so in

[PATCH V1 3/5] net/mlx4_core: deprecate module param controlling the vlan table size

2011-10-16 Thread Or Gerlitz
Enable the maximum size (128) supported by the device for the shadow vlans table, igonring the module param which could override it. This table is only used by the IBoE control plane for setting a vlan index into an RC/UC QP context or UD Address Handle. Signed-off-by: Or Gerlitz ogerl

Re: [PATCH 3/5] net/mlx4_core: remove module param controlling the vlan table size

2011-10-16 Thread Or Gerlitz
On 10/11/2011 7:28 PM, Roland Dreier wrote: No, I think we need to switch to ignoring the parameter and printing a warning if someone sets it, and then we can remove it in a year or so done, I sent you V1 of patch 3/5 which fixes that, any other comment for the rest of the series? Or. --

Re: [PATCH] rdma/core: Really export ib_open_qp() to user space

2011-10-16 Thread Or Gerlitz
On 10/14/2011 10:22 PM, Hefty, Sean wrote: Just an update: the issues that I was seeing were caused by missing patches in my libraries (one in libmlx4 and the other in the ofed compatibility layer). The XRC patches in for-next are testing out fine for me, though it would be good if someone

Re: [PATCH] rdma/core: Really export ib_open_qp() to user space

2011-10-17 Thread Or Gerlitz
Hefty, Sean sean.he...@intel.com wrote:  The rdma_xclient / rdma_xserver tests are a place for those.  They support RC and XRC, so they're in the master branch for the RC support.  I have extensions for them in a private branch which aren't quite ready yet. again, and just to make sure I

Re: rdma: 3.1.0-rc9 breaks UD

2011-10-17 Thread Or Gerlitz
On Fri, Oct 14, 2011 at 4:02 PM, Christoph Lameter c...@gentwo.org wrote: Running ibv_ud_pingpong and ibc_uc_pingpong between two hosts. One with OFED 1.5.3.1 (Ubuntu LTS 10.04) and another on linux 3.1.0-rc9 (Same ubuntu version uderlying) with the upstream libraries. ibv_ud_pingpong OFED:

Re: rdma: 3.1.0-rc9 breaks UD

2011-10-18 Thread Or Gerlitz
On Tue, Oct 18, 2011 at 5:14 PM, Christoph Lameter c...@gentwo.org wrote: -s 100 fixes the issue. Good to know! I'll take a look into whether/how we could improve this little but annoying incompatibility... Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the

Re: rdma: 3.1.0-rc9 breaks UD

2011-10-18 Thread Or Gerlitz
On Wed, Oct 19, 2011 at 12:52 AM, Roland Dreier rol...@purestorage.com wrote: Do you understand why -s 100 fixes things?  If so can you explain it to me? ;) Oh sorry if I was a bit cryptic here (BTW 99 and 101 and 256,512,2048 would work as well...), I'm not next to the code and writing from

drivers/net separation change - impact on 3.2 mlx4 patches

2011-10-18 Thread Or Gerlitz
Roland, I just recalled that once the 3.2 merge window opens Dave is going to push that drivers/net separation change done by Jeff K. which moves drivers/net/mlx4 to drivers/net/ethernet/mellanox/mlx4 see https://github.com/davem330/net-next/tree/master/drivers/net/ethernet/mellanox/mlx4 - is

Re: drivers/net separation change - impact on 3.2 mlx4 patches

2011-10-18 Thread Or Gerlitz
Roland Dreier rol...@kernel.org wrote: I'm sure we can work it out. Thanks for the clarification...are you looking on my IBoE fixes for 3.2? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH for-3.2 v1 3/5] ib/mlx4: Add extended port capabilities support

2011-10-18 Thread Or Gerlitz
Roland Dreier rol...@kernel.org wrote: Is there any reason mlx4_get_ext_port_caps() couldn't be more like mlx4_check_ext_port_caps(), and have that function set MLX4_FLAG_EXTENDED_PORT_INFO?  Is it possible that only some ports on the same HCA handle the extended port info query? If so is

Re: rdma: 3.1.0-rc9 breaks UD

2011-10-19 Thread Or Gerlitz
On 10/19/2011 1:05 AM, Or Gerlitz wrote: in few hours I will be next to the code... The theory failed, looking on commit 577818b50990853bf112ba2a2c336020dd278622 Update examples for IBoE it doesn't change the default message size for the ud pingpong, so we have to dig deeper, Christoph, can

Re: RDMA_CM over RoCE

2011-10-20 Thread Or Gerlitz
Kelly Burkhart kelly.burkh...@gmail.com wrote: I'm having a problem connecting using RDMA_CM over ethernet Actually not.  My network admin found some sort of misconfiguration on the switch that caused the problem  Everything works now. Interesting, could you share the nature of problem?

Re: [PATCH for-3.2] IBoE fixes

2011-10-26 Thread Or Gerlitz
On 10/10/2011 10:51 AM, Or Gerlitz wrote: This is a batch of IBoE related fixes plus addition of extended PMA counters. Hi Roland, With the merge window opening around yesterday, just checking if we're on track for merging this patch set into 3.2 (I sent V1 for patch #3 as you asked). Also

REQ GID enforcement in the CM

2011-10-27 Thread Or Gerlitz
Hi Sean, Looking on that case, I noted that the CM code (SB) checks that the GID in the incoming REQ is present in at least of one the ports of the relevant device, but not specifically on the port this request arrived to, is that following IBTA? I thought it could be problematic e.g in the

Re: REQ GID enforcement in the CM

2011-10-30 Thread Or Gerlitz
On 10/27/2011 6:55 PM, Jason Gunthorpe wrote: You can use the CM to establish a connection on another port, eg send CM GMPs to port 1, specify the primary data path is port 2 and specify the alternate data path is port 1. Jason makes sense, still, maybe the code here could/should be made

Re: cq error timeout issue

2011-10-31 Thread Or Gerlitz
On Mon, Oct 31, 2011 at 9:08 AM, Vlad Weinbaum vlad.weinb...@xtremio.com wrote: [...] I found detail that I cannot explain. I query the QP after connect and get timeout value 16, that must be 4 us * 2^16 = 256 ms, but I get about 800 ms. As Sean indicated, the timeout is **based** on the

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
On Mon, Oct 31, 2011 at 9:38 PM, Roland Dreier rol...@kernel.org wrote: Sorry for the late review here Oh yes... BTW this is patch 4/5, I don't see patches 1,2,3 on your for-next tree/branch @ kernel.org, have you accepted them? Sorry for the late review here, but does it seem like the best

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Is there any reason to expose the 32 and 64 bit version of the same counter? That seems needless. Emit the largest version available and prepend 0's to fill out to the available width so that userspace can know the counter size.

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Guys (Roland, Jason), I'm open to any comments, any time, for any patch, but for a patch which was posted weeks ago it's pretty unfair to have your comments coming only eight days after the merge window has been opened, lets try to come

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
On Tue, Nov 1, 2011 at 11:42 PM, Roland Dreier rol...@kernel.org wrote: The least bad way forward does seem like it is probably the separate new directory thing. I agree Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: I don't mean the 32 bit counters are useless, I mean exposing PMA counters that saturate and can be randomly reset by external agents through sysfs is useless. You can't make any kind of data collection based on such a system. Ideally

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
On Tue, Nov 1, 2011 at 11:49 PM, Roland Dreier rol...@kernel.org wrote: There's no obligation to merge something just because you posted it before the merge window, and in fact Linus's complaint at the kernel summit is always that sub-maintainers don't say no enough. And let's be honest in

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-01 Thread Or Gerlitz
Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Why have a sysfs counter at all when you can just ask the PMA and get exactly the same data? The HW/FW PMA agent isn't supported for IBoE only for IB, the counters are for both Or. -- To unsubscribe from this list: send the line

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-02 Thread Or Gerlitz
On 11/2/2011 12:46 AM, Ira Weiny wrote: What do you mean for both? Ira The sysfs PMA counters are functional for both IB and IBoE, the latter uses a HW counter allocated per device/port for which all the QPs created on that port are reporting their rx/tx bytes/packets, see commits

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-02 Thread Or Gerlitz
On 11/1/2011 11:58 PM, Jason Gunthorpe wrote: maybe you should patch to un-export them until things can be fixed sanely... Jason, I don't think we want to work this way, bug are either opened or attempted to be fixed or fixed. You can't just come out of the the blue and remove

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-11-02 Thread Or Gerlitz
On 11/1/2011 11:42 PM, Roland Dreier wrote: The least bad way forward does seem like it is probably the separate new directory thing Hi Roland, I suggest we go that least bad way along the lines of your comment. If/when on some future point something constructive can be formed from Jason's

[PATCH for-3.2 0/2] iser fixes for 3.2

2011-11-03 Thread Or Gerlitz
Roland, These are two fixes making iser better citizen w.r.t to honoring the DMA mapping API Or Gerlitz (2): ib/iser: use separate buffers for the login request/response ib/iser: issue dma unmapping on the tx bufs used for the iscsi/iser headers drivers/infiniband/ulp/iser

[PATCH 1/2] ib/iser: use separate buffers for the login request/response

2011-11-03 Thread Or Gerlitz
for requests and one for responses, and apply on each the correct DMA mapping direction. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp/iser/iscsi_iser.h |3 +- drivers/infiniband/ulp/iser/iser_initiator.c | 31 ++- drivers/infiniband/ulp/iser

[PATCH 2/2] ib/iser: issue dma unmapping on the tx bufs used for the iscsi/iser headers

2011-11-03 Thread Or Gerlitz
The current driver never does DMA unmapping on these buffers. Fix that by adding dma unmapping to the task cleanup callback, and dma mapping to the task init function (drop the headers_initialized micro-optimization). Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/ulp

Re: iSER + CentOS 5.7 + Xen lockup

2011-11-07 Thread Or Gerlitz
On 11/8/2011 3:14 AM, Mohammed Naser wrote: Hello everyone, we had this server crash a couple of times because of (what seems to me) some iSER problems. This node runs all the default drivers that ship with CentOS 5.7 You mentioned Xen in your subject line, but later say CentOS 5.7, what

Re: [GIT PULL] please pull infiniband.git

2011-11-08 Thread Or Gerlitz
/main.c, looking on the latter code I see that the patch was actually applied on the code, just checking if this missing log points to some other problem? Or. commit cb29688aaa4caa4d54df2976118fe99a839bb433 Author: Or Gerlitz ogerl...@mellanox.com Date: Sun Oct 16 10:26:21 2011 +0200

question on the timewait event of the rdma-cm

2011-11-14 Thread Or Gerlitz
Sean, I'm debugging some disconnect related race in iser - and wanted to check with you something re the CM/RDMA-CM state machine: I see that when a disconnected is initiated by the passive side (iser target) of a connection, such that the active side (iser initiator) gets

Re: question on the timewait event of the rdma-cm

2011-11-14 Thread Or Gerlitz
On Mon, Nov 14, 2011 at 9:16 PM, Hefty, Sean sean.he...@intel.com wrote: After disconnecting, the QP should enter the timewait state for twice the packet lifetime. Does going through timewait always holds? e.g no matter what's the return status of rdma_disconnect and/or the status of the

Re: question on the timewait event of the rdma-cm

2011-11-14 Thread Or Gerlitz
It usually holds.  It will fail if rdma_disconnect() is called from a bogus state.  But otherwise, I believe that it will enter timewait on failure to send or receive a disconnect message mmm, so can these bogus states for rdma_disconnect to be called be better defined? basically, for the

Re: question on the timewait event of the rdma-cm

2011-11-14 Thread Or Gerlitz
By bogus I mean calling disconnect when the QP has never been connected, or calling disconnect twice what return value can serve as bogus indication for the application? is that -EINVAL? also, basically a QP could have buffers posted to it also before being connected (e.g after RTR or there's

Re: srp_transport: Fix atttribute registration race

2011-11-14 Thread Or Gerlitz
On Sun, Nov 13, 2011 at 11:55 PM, Dave Dillow dillo...@ornl.gov wrote: SRP uses RDMA, so you cannot use UC mode. per the IB spec, RDMA write is supported for UC Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More

Re: question on the timewait event of the rdma-cm

2011-11-14 Thread Or Gerlitz
On Mon, Nov 14, 2011 at 11:55 PM, Hefty, Sean sean.he...@intel.com wrote: [...] calling disconnect is one way that a QP may be transitioned into timewait [...] I was talking on the QP physical state (e.g error that causes flushes) not the state w.r.t the IB CM. Or. -- To unsubscribe from

Re: Upstream support for multicast IBoE

2011-11-23 Thread Or Gerlitz
Roland Dreier rol...@purestorage.com wrote: looks like the libmlx4 patches I applied from you are missing multicast AH support? Yes, when I reworked the patches for submission I went from easier (RC) to harder (ucast UD + Vlans) and eventually didn't nailed down the multicast front. I probably

Re: Upstream support for multicast IBoE

2011-11-23 Thread Or Gerlitz
Roland Dreier rol...@purestorage.com wrote: looks like the libmlx4 patches I applied from you are missing multicast AH support? On a related note, what/when would it take to get a release of libibverbs/libmlx4? so far there's no single release that supports IBoE and people who don't go OFED

Re: RAW Ethernet support for Kernel IB stack?

2011-11-23 Thread Or Gerlitz
Christoph Lameter c...@linux.com wrote: Seems that OFED has this raw ethernet support but the kernel IB stack does not? Any work in progress on that one? Yes, I will be reworking the patches for upstream submission, expected in the coming weeks. Or. -- To unsubscribe from this list: send the

Re: [PATCH] [libibverbs] Allow 3rd party extensions to verb routines

2011-12-01 Thread Or Gerlitz
On 11/30/2011 11:38 PM, Hefty, Sean wrote: [...] Also, any thoughts on the direction of AF_IB for adding support for native IB addresses through the rdma_cm? yes, see some questions and comments over that thread -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body

Re: [PATCH 4/5] rdma/cm: Update port reservation to support AF_IB

2011-12-01 Thread Or Gerlitz
On 11/4/2011 9:08 AM, Hefty, Sean wrote: +static struct idr *cma_select_ib_ps(struct rdma_id_private *id_priv) +{ + struct idr *ps = NULL; + struct sockaddr_ib *sib; + u64 sid_ps, mask, sid; + + sib = (struct sockaddr_ib *)id_priv-id.route.addr.src_addr; + mask =

Re: [PATCH 4/5] rdma/cm: Update port reservation to support AF_IB

2011-12-01 Thread Or Gerlitz
On 11/4/2011 9:08 AM, Hefty, Sean wrote: +static struct idr *cma_select_ib_ps(struct rdma_id_private *id_priv) [...] + if (ps) { + sib-sib_sid = cpu_to_be64(sid_ps | ntohs(cma_port((struct sockaddr *) sib))); + sib-sib_sid_mask = cpu_to_be64(RDMA_IB_IP_PS_MASK

Re: [PATCH 4/5] rdma/cm: Update port reservation to support AF_IB

2011-12-03 Thread Or Gerlitz
On Sat, Dec 3, 2011 at 12:41 AM, Hefty, Sean sean.he...@intel.com wrote: What sparse settings did you use to produce this warning? make CF=-D__CHECK_ENDIAN__ C=2 -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Or Gerlitz
On 12/4/2011 4:29 PM, Jack Morgenstein wrote: If the kernel is not configured to support IOV, pci_enable_sriov will fail. Jack, If CONFIG_PCI_IOV isn't set, pci_enable_sriov isn't there... Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [RFC] – Proposal for new process for OFED releases

2011-12-04 Thread Or Gerlitz
On 12/2/2011 2:04 AM, Hefty, Sean wrote: We propose a new process for the OFED releases starting from next OFED release: - OFED content will be the relevant kernel.org modules and user space released packages - OFED will offer only backports to the distros (no fixes) I think this point needs

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Or Gerlitz
On 12/5/2011 9:19 AM, Jack Morgenstein wrote: If CONFIG_PCI_IOV isn't set, pci_enable_sriov isn't there... Not so. I checked. If CONFIG_PCI_IOV isn't set, pci_enable_sriov returns -ENODEV via a static inline function. Look in kernel file include/linux/pci.h (for the most recent kernel)

Re: crash unloading mlx4 in 3.2-rc3

2011-12-06 Thread Or Gerlitz
Roland Dreier rol...@purestorage.com wrote: Yeah, no worries, since that patch works I think I understand the problem.  And it was in 3.1 AFAICT too... came in with cfcde11c3d7a (IB/mlx4: Use flow counters on IBoE ports) which was in 3.1. I'll queue up my fix, thanks for testing. mmm, so its

[PATCH 0/4] ib/mlx4: fix 8021q vlan priority-bits used under IBoE

2011-12-11 Thread Or Gerlitz
. Or Gerlitz (1): ib/mlx4: fix SL to 8021q priority-bits settings under IBoE drivers/infiniband/hw/mlx4/ah.c |2 +- drivers/infiniband/hw/mlx4/cq.c |6 +- drivers/infiniband/hw/mlx4/qp.c |4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) Or Gerlitz (3): use Ethernet 8021q vlans

[PATCH 1/4] ib/mlx4: fix SL to 8021q priority-bits settings under IBoE

2011-12-11 Thread Or Gerlitz
. These inconsistencies resulted in wrong SL -- wire 8021q bpits mappings, which are fixed by using SL -- PPP0 all around the place. Signed-off-by: Oren Duer o...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/hw/mlx4/ah.c |2 +- drivers/infiniband/hw/mlx4/cq.c |6

[PATCH libmlx4 2/4] use Ethernet 8021q vlans related fields with CQE

2011-12-11 Thread Or Gerlitz
When running IBoE traffic, the hardware places Ethernet fields into the CQE. This patch enhances the code to include the ones related to vlans. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/cq.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff

[PATCH libmlx4 4/4] fix SL to 8021q priority-bits settings under IBoE

2011-12-11 Thread Or Gerlitz
in wrong input into AH build-up from CQE such as done by consumers of ibv_init_ah_from_wc This is fixed by using PPP0 where relevant, a related fix is provided to the kernel mlx4 driver. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- src/cq.c|5 - src/verbs.c |5 +++-- 2 files

[PATCH librdmacm] udaddy/ucmatose: allow easy setting of tos in hex

2011-12-11 Thread Or Gerlitz
Under IBoE, the 3 MSBits of the TOS map to the SL, hence letting the user to specify them in hex makes the interface friendlier. Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- examples/cmatose.c |2 +- examples/udaddy.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: RAW Ethernet support for Kernel IB stack?

2011-12-14 Thread Or Gerlitz
On 12/9/2011 12:06 AM, Christoph Lameter wrote: Are there any prereleases of that available? Or if you just give me a list of OFED patches then I can try and see how far I can get on my own I should be sending it by next week Or. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH net-next V2 00/21] net/mlx4: SRIOV support

2011-12-14 Thread Or Gerlitz
On Wed, Dec 14, 2011 at 10:42 PM, Yinghai Lu ying...@kernel.org wrote: got following warning: could you send your .config as attached to Yevgeny Petrilin yevge...@mellanox.com, he will distribute it to the group Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the

checkpoint release of libibverbs/libmlx4

2011-12-16 Thread Or Gerlitz
On Tue, Dec 6, 2011 at 12:49 AM, Or Gerlitz or.gerl...@gmail.com wrote: Roland Dreier rol...@purestorage.com wrote: I want to do a checkpoint release of libibverbs with IBoE support (ie what's in the tree already) and then get XRC in. This makes sense, could we add also that little patch

Re: [PATCH 04/14] ib_srp: Set block layer timeout

2011-12-17 Thread Or Gerlitz
Bart Van Assche bvanass...@acm.org wrote: The default block layer timeout is 30 seconds. Could you provider a pointer to where this is defined? Typical values for the QP local ack timeout and retry count are 19 and 7 respectively, which means that it can take up to 60.1 seconds before a HCA

Re: IB/iSER with Linux 3.0 and Debian: Lesson learned

2011-12-19 Thread Or Gerlitz
On 12/19/2011 11:14 AM, Sebastian Riemer wrote: Finally I've got IB/iSER running on Debian Squeeze with Linux kernel 3.0 smoothly. The problem was that we did not have the suitable OFED for our kernel Sebastian, Beep, I'd like to better/understand the problem before looking on your struggle

Re: [PATCH] ib/cm: fix layout of APR message

2011-12-19 Thread Or Gerlitz
On 12/19/2011 9:10 PM, Hefty, Sean wrote: Thanks for catching this. Let's hope very few/no people are using APR in such a way that fixing this bug will bite them. no in-tree users so... I tend to agree there's no other choice here. -- To unsubscribe from this list: send the line unsubscribe

Re: IB/iSER with Linux 3.0 and Debian: Lesson learned

2011-12-20 Thread Or Gerlitz
Sebastian Riemer wrote: Debian Squeeze (in general 2.6.32 based) comes with open-iscsi 2.0.871.3-2squeeze1. We've used that version together with the in-tree mainline kernel 3.0 OFA kernel modules and Debian Squeeze OFED-1.4 user-space. But there were lots of iSER connection aborts (and even

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-12-20 Thread Or Gerlitz
Ira Weiny wrote: Jason Gunthorpejguntho...@obsidianresearch.com wrote: How do you feel about having counters_ext appear in ethernet mode and disappear in IB mode? That might get complicated with ports which can be either mode. Ira (reviving this thread), At the ib core level, the link layer

Re: [PATCH 4/5] ib/core: add support for extended performance counters in sysfs

2011-12-20 Thread Or Gerlitz
Ira Weiny wrote: Jason Gunthorpejguntho...@obsidianresearch.com wrote: How do you feel about having counters_ext appear in ethernet mode and disappear in IB mode? That might get complicated with ports which can be either mode. Ira (reviving this thread), At the ib core level, the link layer

<    1   2   3   4   5   6   7   8   9   10   >