you're OK
with that.
Or.
Or Gerlitz (2):
IB/iser: Add Mellanox copyright
MAINTAINERS: Add entry for iSCSI Extensions for RDMA (iSER) initiator
Roi Dayan (1):
IB/iser: Fix device removal flow
MAINTAINERS | 13 +
drivers/infiniband/ulp/iser
Add entry for the iSER initiator driver and which is maintained by
Or Gerlitz and Roi Dayan below the kernel Infiniband subsystem.
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
MAINTAINERS | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b
Add Mellanox copyright to the iser initiator source code which I maintain.
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c |1 +
drivers/infiniband/ulp/iser/iscsi_iser.h |1 +
drivers/infiniband/ulp/iser/iser_initiator.c |1
Hefty sean.he...@intel.com
Signed-off-by: Roi Dayan r...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_verbs.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c
b/drivers
entry to help people
figure out who's involved (and send bugs and flames...) hope you're OK
with that.
Or.
Or Gerlitz (2):
IB/iser: Add Mellanox copyright
MAINTAINERS: Add entry for iSCSI Extensions for RDMA (iSER) initiator
Roi Dayan (1):
IB/iser: Fix device removal flow
MAINTAINERS
On 09/05/2013 00:20, Roland Dreier wrote:
Or Gerlitz (2):
IB/iser: Return error to upper layers on EAGAIN registration failures
IB/iser: Add support for iser CM REQ additional info
Roi Dayan (2):
IB/iser: Add module version
IB/iser: Move informational messages from
On Fri, May 17, 2013 at 10:36 PM, Jack Wang jinpu.w...@profitbricks.com wrote:
We've seen below neigh-list list corruption warning during testing,
So about little heads up on what kernel you are using? what's the way
to trigger this warning?
From Dongsu's and my opinion, several place also
On 19/05/2013 00:36, Jack Wang wrote:
I tried 3.4.23, and mainline kernel from Roland's rdma-for-linus, we
added bug injection interface, run multithread iperf, and switched ib
mode between connected and datagram in sync on each side as Shlomo
suggested.
Can you be more specific re the bug
On 18/05/2013 00:37, Roland Dreier wrote:
you see that when freeing a CQ, we first do the HW2SW_CQ firmware
command; once this command completes, no more events will be generated
for that CQ. Then we do synchronize_irq for the CQ's interrupt
vector. Once that completes, no more completion
On 20/05/2013 12:10, Jinpu Wang wrote:
which list_del do you mean? in ipoib_cm_tx_start?
yes, but not only, you can start with 5KG hammer and convert all
thesehits to list_del_init
linux-2.6]# grep list_del drivers/infiniband/ulp/ipoib/*.c | grep neigh
drivers/infiniband/ulp/ipoib/ipoib_cm.c:
Hi Roland,
Following what we discussed last week during the Linux Foundation EU
summit, I think it would be good to follow what you said and have a
point release for libibverbs and libmlx4 before we pull in the verbs
extensions framework and features that use it (XRC, Flow-Steering, etc
more
On 20/05/2013 15:46, Jinpu Wang wrote:
A quick test show the list_corruption warning is gone, after I convert
all list_del(neigh-list) to list_del_list(neigh-list).
yes, but this wasn't your original problem or was it?
--
To unsubscribe from this list: send the line unsubscribe linux-rdma
On Mon, May 20, 2013 at 5:36 PM, Jack Wang jinpu.w...@profitbricks.com wrote:
Sorry for confusion. Current list corruption is gone in my preliminary test,
after I changed
list_del to list_del_init as Or suggested.
As Or asked for the original bug, so I just want to show him the whole story.
Hi Sean,
Do we have some public quoted usages/feedback for rsockets? I think
you've mentioned something during the panel at the Linux EU summit
last week but I am not sure...
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
On Mon, May 20, 2013 at 10:38 PM, Jack Wang jinpu.w...@profitbricks.com wrote:
The bug in our production environment is introduced in our backport
about ipoib fixes from mainline, and when we hit that bug we reverted
back to old kernel without the backport patch, and the bug didn't happen for
On Mon, May 20, 2013 at 10:52 PM, Hefty, Sean sean.he...@intel.com wrote:
Do we have some public quoted usages/feedback for rsockets? I think
you've mentioned something during the panel at the Linux EU summit
last week but I am not sure...
Most feedback I can think of has come via private
On 20/05/2013 17:53, Jack Morgenstein wrote:
===
net/mlx4_core: Fix racy flow in the driver CQ completion handler
The mlx4 CQ completion handler, mlx4_cq_completion, doesn't bother to lock
the radix tree which is used to manage the table of CQs,
On 21/05/2013 13:42, Bart Van Assche wrote:
On 05/21/13 11:40, Or Gerlitz wrote:
2. is possible in the Linux kernel for one hard irq callback to flash on
CPU X while another hard irq callback is running on the same CPU?
I think that from kernel 2.6.35 on MSI IRQs are no longer nested. See
Hi Sean,
We have a user space application which is made of M (clients) x N
(servers) RC connectivity pattern using librdmacm. Basically, there are
N nodes, each running M client process and each client connects to all N
servers.
So under some unknown conditions, many of the clients
On 21/05/2013 17:13, Jack Morgenstein wrote:
I just need to verify that the patch can be applied correctly on the upstream
kernel.
The use of RCU (and not spinlock) makes sense from a performance standpoint
in any case. We do NOT want to force mlx4_cq_completion to have a spinlock
which is
On 21/05/2013 18:24, Hefty, Sean wrote:
I don't remember this patch at all.
Alex, can you please send Sean this patch
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Tue, May 21, 2013 at 6:24 PM, Hefty, Sean sean.he...@intel.com wrote:
One thing seen in the nodes dmesg is a message from an old patch of
yours which exists in ofed1.5.3 but didn't hit (or wasn't accepted?)
upstream saying ib_cm: calculated mra timeout 67584 8192, decreasing
used
On Tue, May 21, 2013 at 1:43 AM, Shawn Bohrer shawn.boh...@gmail.com wrote:
I appologize if I missed it, but did any support for L3/L4 CSUM
generation get added? Doesn't look like the upstream libibverbs has
it, and I don't seem to see any patches floating around.
Roland commented that he
On Tue, May 21, 2013 at 1:54 AM, Shawn Bohrer shawn.boh...@gmail.com wrote:
Are there any patches for libibverbs to add
ibv_create_flow/ibv_destroy_flow? And are there any needed patches
for libmlx4? I'm building up a stack so we can begin testing this series.
YES there are patches NO I
On Mon, May 20, 2013 at 7:49 PM, Roland Dreier rol...@kernel.org wrote:
That's fine, I'll do the releases this week.
cool.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 24/05/2013 20:43, Liu Ginhann wrote:
Here is version information of our test chassis,
what driver / card are you using?
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 24/05/2013 20:43, Liu Ginhann wrote:
Ibv_reg_mr() call return EFAULT - bad address
Basically, AFAIK, the IB stack should support what you are trying to do,
If you tell from which code e.g in libibverbs/libmlx4 or the kernel this
value is returned, it might be helpful for further assisting
On Sun, May 26, 2013 at 4:52 PM, Liu Ginhann
ginhann@grassvalley.com wrote:
Will dig into it.Thanks.
does this works if you use get_free_pages in the kernel instead of kmem_cache?
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
On 29/05/2013 02:10, Roland Dreier wrote:
libibverbs is a library that allows programs to use RDMA verbs for
direct access to RDMA (currently InfiniBand and iWARP) hardware from userspace.
Hey, so there's RoCE out there too...
The new stable release, 1.1.7, is available from
libmlx4
On Tue, May 28, 2013 at 8:51 PM, Jeff Squyres (jsquyres)
jsquy...@cisco.com wrote:
I ask because, as an MPI guy, I would *love* to see this stuff integrated
into the kernel and libibverbs.
Hi Jeff,
Have you looked on ODP? see
On 30/05/2013 01:56, Jeff Squyres (jsquyres) wrote:
On May 29, 2013, at 4:53 AM, Or Gerlitz or.gerl...@gmail.com wrote:
Have you looked on ODP? see
https://www.openfabrics.org/resources/document-downloads/presentations/doc_download/568-on-demand-paging-for-user-space-networking.html
Hank
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Or Gerlitz
Sent: Monday, May 27, 2013 12:53 AM
To: Liu Ginhann
Cc: Or Gerlitz; linux-rdma@vger.kernel.org
Subject: Re: ibv_reg_mr call failed
On Sun, May 26, 2013
On 04/06/2013 04:24, Jeff Squyres (jsquyres) wrote:
On May 29, 2013, at 1:53 AM, Or Gerlitz or.gerl...@gmail.com wrote:
Have you looked on ODP? see
https://www.openfabrics.org/resources/document-downloads/presentations/doc_download/568-on-demand-paging-for-user-space-networking.html
On 08/06/2013 19:42, Liu Ginhann wrote:
does this works if you use get_free_pages in the kernel instead of
kmem_cache?
I tried get_free_pages, kmalloc, kmem_cache_alloc. None of them work, it failed
with the same error - EFAULT bad pointer.
After code walk through, I believe it failed in
bit registration
ID which is returned to the caller within struct ib_flow and used
later for detaching that flow.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/main.c | 246 +
1
IB_FLOW_ATTR_MC_DEFAULT - same as IB_FLOW_ATTR_ALL_DEFAULT but only for
multicast
IB_FLOW_ATTR_SNIFFER - sniffer rule, receive all port traffic
ALL_DEFAULT and MC_DEFAULT rules options are valid only for Ethernet link type.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl
Hi Roland, all
These patches add Flow Steering support to the kernel IB core, to uverbs and
to the mlx4 IB (verbs) driver along with one patch to uverbs which adds
some code to support extensions.
IB/core: Add receive Flow Steering support
IB/core: Infra-structure to support verbs
From: Hadar Hen Zion had...@mellanox.com
Implement ib_uverbs_create_flow and ib_uverbs_destroy_flow to
support flow steering for user space applications.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs.h
and processed a bit differently.
Signed-off-by: Igor Ivanov igor.iva...@itseez.com
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_main.c | 29 -
include/uapi/rdma/ib_user_verbs.h
On 13/06/2013 12:53, Sebastian Riemer wrote:
On 12.06.2013 15:24, Bart Van Assche wrote:
The SRP initiator implements host reset by reconnecting to the SRP
target. That means that communication with the target is possible
as soon as host reset finished. Hence skip the host settle delay.
...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/ah.c | 21 +-
drivers/infiniband/hw/mlx4/cq.c |5 +
drivers/infiniband/hw/mlx4/main.c| 461 +++---
drivers/infiniband/hw/mlx4/mlx4_ib.h |3 +
drivers/infiniband/hw
Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as
they encode related Ethernet net-device interface MAC address and
possibly VLAN id.
This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6)
of the that Ethernet interface, under the following reasoning:
1. There are
and processed a bit differently.
Signed-off-by: Igor Ivanov igor.iva...@itseez.com
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_main.c | 29 -
include/uapi/rdma/ib_user_verbs.h
within gids,
had to extend the Infiniband address structures (e.g. ib_ah_attr) with layer 2
address parameters, namely mac and vlan.
Signed-off-by: Moni Shoua mo...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/cm.c |3 ++
drivers/infiniband/core
From: Matan Barak mat...@mellanox.com
Add support for RoCE (IBoE) IP based addressing extensions towards user space.
Extend INIT_QP_ATTR and QUERY_ROUTE ucma commands.
Extend MODIFY_QP and CREATE_AH uverbs commands.
Signed-off-by: Matan Barak mat...@mellanox.com
Signed-off-by: Or Gerlitz ogerl
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
Can you talk abit about compatibility please? What happens when nodes
with this patch are on the same network as nodes without it?
The CM on the passive side would send a reject with the reason being
invalid gid so this will not go
On Thu, Jun 13, 2013 at 8:09 PM, Jason Gunthorpe
jguntho...@obsidianresearch.com wrote:
On Thu, Jun 13, 2013 at 06:01:44PM +0300, Or Gerlitz wrote:
From: Matan Barak mat...@mellanox.com
Add support for RoCE (IBoE) IP based addressing extensions towards
user space.
Extend INIT_QP_ATTR
On Tue, Jun 11, 2013 at 2:42 PM, Or Gerlitz ogerl...@mellanox.com wrote:
[...]
V0 has been acknowledged by Steve and Christoph, and was also got positive
feedback from Sean and Jason over f2f talks we had during the Linux
Foundation EU
summit on last month.
Hi Roland,
So we're @ -rc6
On 17/06/2013 21:44, Hal Rosenstock wrote:
I'm not 100% sure about the origin of those RPMs but I think the 3.3.15
one is RedHat packaged and the 3.3.16 appears to be PLD packaged and the
processes are a little different. I suspect the 3.3.16 one is packaged
with the spec file in the tree
On 18/06/2013 14:19, Hal Rosenstock wrote:
Is /etc/rdma a standard location in Linux ? Is it used by other RDMA upstream
components ?
its used by RHEL packages, not upstream
Also, opensm doesn't by default use this location for the config file. I expect
that's dealt with by other scripts
on top of that port so this should be considered when building and
maintaining the gid table.
Signed-off-by: Moni Shoua mo...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/main.c| 461 +++---
drivers/infiniband/hw/mlx4
and processed a bit differently.
Signed-off-by: Igor Ivanov igor.iva...@itseez.com
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_main.c | 29 -
include/uapi/rdma/ib_user_verbs.h
Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as
they encode related Ethernet net-device interface MAC address and
possibly VLAN id.
This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6)
of the that Ethernet interface, under the following reasoning:
1. There are
within gids,
had to extend the Infiniband address structures (e.g. ib_ah_attr) with layer 2
address parameters, namely mac and vlan.
Signed-off-by: Moni Shoua mo...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/cm.c |3 ++
drivers/infiniband/core
...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs.h |2 +
drivers/infiniband/core/uverbs_cmd.c | 330 ++---
drivers/infiniband/core/uverbs_main.c |4 +-
drivers/infiniband/core/uverbs_marshall.c
uses ib_user_path_rec_ex
Signed-off-by: Matan Barak mat...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/ucma.c | 172 -
include/uapi/rdma/rdma_user_cm.h | 21 +-
2 files changed, 187 insertions(+), 6 deletions
, instead of
parsing the dgid to get the MAC and VLAN, take them from the
address handle attributes.
Signed-off-by: Moni Shoua mo...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx4/ah.c | 21 +
drivers/infiniband/hw/mlx4/cq.c |5
On 16/06/2013 15:02, Eli Cohen wrote:
From: Eli Cohen e...@mellanox.com
The patches that follow constitute the driver for Mellanox's 5th generation
of HCAs named Connect-IB.
The driver is comprised of two kernel modules: mlx5_ib and mlx5_core. This
partitioning resembles what we have for mlx4
On 19/06/2013 18:47, Wendy Cheng wrote:
what kind of HW I would need to run it ?
The mlx4 driver supports memory windows as of kernel 3.9
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Mike Marciniszyn mike.marcinis...@intel.com wrote:
From: Ramkrishna Vepa ramkrishna.v...@intel.com
This patch adds context relative numa affinity conditioned on the
module parameter numa_aware. The qib_ctxtdata has an additional
node_id member and qib_create_ctxtdata() has an addition
On 25/06/2013 00:10, Roland Dreier wrote:
On Tue, Jun 11, 2013 at 4:42 AM, Or Gerlitz ogerl...@mellanox.com wrote:
+struct ib_kern_flow {
+ struct ib_device *device;
+ struct ib_uobject *uobject;
+ void *flow_context;
+};
I don't think it makes sense to put
IB_FLOW_ATTR_MC_DEFAULT - same as IB_FLOW_ATTR_ALL_DEFAULT but only for
multicast
IB_FLOW_ATTR_SNIFFER - sniffer rule, receive all port traffic
ALL_DEFAULT and MC_DEFAULT rules options are valid only for Ethernet link type.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl
registration
ID which is placed into struct mlx4_ib_flow that wraps the instance of
struct ib_flow which is retuned to caller. Later, this reg ID is used
for detaching that flow from the firmware.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
and processed a bit differently.
Signed-off-by: Igor Ivanov igor.iva...@itseez.com
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_main.c | 29 -
include/uapi/rdma/ib_user_verbs.h
From: Hadar Hen Zion had...@mellanox.com
Implement ib_uverbs_create_flow and ib_uverbs_destroy_flow to
support flow steering for user space applications.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs.h
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
MAINTAINERS | 10 ++
drivers/infiniband/Kconfig |1 +
drivers/infiniband/Makefile |1 +
drivers/infiniband/hw/mlx5/Kconfig | 10 ++
From: Eli Cohen e...@mellanox.com
The patches that follow constitute the driver for Mellanox's 5th generation
of HCAs named Connect-IB.
The driver is comprised of two kernel modules: mlx5_ib and mlx5_core. This
partitioning resembles what we have for mlx4 with the substantial difference
that
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
drivers/infiniband/hw/mlx5/ah.c | 95
drivers/infiniband/hw/mlx5/cq.c | 851 +
drivers/infiniband/hw/mlx5/doorbell.c | 100
drivers/infiniband/hw/mlx5/mad.c
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 593
drivers/infiniband/hw/mlx5/mr.c | 1025 ++
2 files changed, 1618 insertions(+), 0 deletions(-)
create mode
On 26/06/2013 16:05, Roland Dreier wrote:
On Wed, Jun 26, 2013 at 5:57 AM, Or Gerlitz ogerl...@mellanox.com wrote:
Add Infra-structure to support extended uverbs capabilities in a
forward/backward manner. Uverbs command opcodes which are based on the verbs
extensions approach should
On 26/06/2013 18:17, Or Gerlitz wrote:
Based on the bits set in the comp mask and the in_words field value,
the kernel which has cmdX_v2 can work towards older user space
libraries/applications e.g cmdX_v1 and cmdX_v0
The comp mask is not part of the header, but rather the 1st field
On Wed, Jun 26, 2013 at 10:56 PM, Hefty, Sean sean.he...@intel.com wrote:
The input to ib_create_flow is instance of struct ib_flow_attr which
contain few mandatory control elements and optional flow specs.
struct ib_flow_attr {
enum ib_flow_attr_type type;
u16 size;
On Thu, Jun 27, 2013 at 12:33 AM, Steve Wise
sw...@opengridcomputing.com wrote:
On 6/26/2013 4:13 PM, Or Gerlitz wrote:
On Wed, Jun 26, 2013 at 10:56 PM, Hefty, Sean sean.he...@intel.com
Steering rules processing order is according to rules priority. The user
sets the 12 low-order bits from
On Thu, Jun 27, 2013 at 11:55 PM, Hefty, Sean sean.he...@intel.com wrote:
My point was that the IPv6 filter should be defined and used here. The
following basic filters were defined:
ethernet - src/dst mac ...
ip -src/dst ip
tcp/udp - src/dst port
These are at
On Sun, Jun 16, 2013 at 3:02 PM, Eli Cohen e...@dev.mellanox.co.il wrote:
From: Eli Cohen e...@mellanox.com
The patches that follow constitute the driver for Mellanox's 5th generation
of HCAs named Connect-IB.
The driver is comprised of two kernel modules: mlx5_ib and mlx5_core. This
On Fri, Jun 28, 2013 at 4:20 PM, Or Gerlitz or.gerl...@gmail.com wrote:
On Sun, Jun 16, 2013 at 3:02 PM, Eli Cohen e...@dev.mellanox.co.il wrote:
From: Eli Cohen e...@mellanox.com
The patches that follow constitute the driver for Mellanox's 5th
generation
of HCAs named Connect-IB
On Tue, Jul 2, 2013 at 12:22 AM, Roland Dreier rol...@kernel.org wrote:
Also, sparse warns about [...] in mlx5_ib.h. Nor does it have any callers,
so it's a bit
hard to tell if it's really and truly a bug.
removing this function for V2
--
To unsubscribe from this list: send the line
On Mon, Jul 1, 2013 at 9:03 PM, Roland Dreier rol...@kernel.org wrote:
In general I don't think overriding the CFLAGS (as you do in the mlx5
Makefiles) is a good idea, and in particular here your -Wall -Werror
break the build, at least for my gcc 4.7.3:
CC
On Mon, Jul 1, 2013 at 8:49 PM, Roland Dreier rol...@kernel.org wrote:
So I'm inclined to apply the mlx5 driver for 3.11, since it's a
completely new driver. However, reading through it so far I had the
following comments, and I'd like these cleanups addressed along with Dave
Miller's:
On 03/07/2013 15:41, Bart Van Assche wrote:
[...]
Bart,
The individual patches in this series are as follows:
0001-IB-srp-Fix-remove_one-crash-due-to-resource-exhausti.patch
0002-IB-srp-Fix-race-between-srp_queuecommand-and-srp_cla.patch
On 01/07/2013 20:49, Roland Dreier wrote:
- I think the active flag for the health check timer is unnecessary.
It can just be stopped with del_timer_sync().
Hi Roland
Jack looked on this comment/code and he says that the active flag is used
to prevent re-scheduling the timer from inside the
From: Jack Morgenstein ja...@dev.mellanox.co.il
Continue the approach taken by commit d2b57063e4a IB/core: Reserve bits in
enum ib_qp_create_flags for low-level driver use and reserved entries to
the ib_qp_type and ib_wr_opcode enums. The low-level drivers will then define
macros to use these
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
drivers/infiniband/hw/mlx5/ah.c | 95
drivers/infiniband/hw/mlx5/cq.c | 844 +
drivers/infiniband/hw/mlx5/doorbell.c | 100
drivers/infiniband/hw/mlx5/mad.c
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
MAINTAINERS | 10 ++
drivers/infiniband/Kconfig |1 +
drivers/infiniband/Makefile |1 +
drivers/infiniband/hw/mlx5/Kconfig | 10 ++
Hi Roland, all
Here's V2 of the driver, with Dave's and Roland's comments addressed,
looking forward to see if we have OK from Roland to merge that into 3.11
Jack, Moshe and Or.
changes from V1:
- Addreessed Dave Miller's comments:
* Local variables in functions listed from longest to
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 547 ++
drivers/infiniband/hw/mlx5/mr.c | 1021 ++
2 files changed, 1568 insertions(+), 0 deletions(-)
create mode 100644
On 03/07/2013 20:22, Shawn Bohrer wrote:
On Wed, Jul 03, 2013 at 07:33:07AM +0200, Hannes Frederic Sowa wrote:
On Wed, Jul 03, 2013 at 07:11:52AM +0200, Hannes Frederic Sowa wrote:
On Tue, Jul 02, 2013 at 01:38:26PM +, Cong Wang wrote:
On Tue, 02 Jul 2013 at 08:28 GMT, Hannes Frederic
From: Hadar Hen Zion had...@mellanox.com
Implement ib_uverbs_create_flow and ib_uverbs_destroy_flow to
support flow steering for user space applications.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs.h
and processed a bit differently.
Signed-off-by: Igor Ivanov igor.iva...@itseez.com
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/uverbs_main.c | 29 -
include/uapi/rdma/ib_user_verbs.h
Hi Roland, all
V3 addresses the comments made by Sean. There are still some concerns/questions
posed
by Roland on the uverbs extensions element of the series. I have posted replies
for
them, but so far no further comments were made.
V3 changes:
- Addressed comments from Sean:
- modified
registration
ID which is placed into struct mlx4_ib_flow that wraps the instance of
struct ib_flow which is retuned to caller. Later, this reg ID is used
for detaching that flow from the firmware.
Signed-off-by: Hadar Hen Zion had...@mellanox.com
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers
-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/core/verbs.c | 27 +
include/rdma/ib_verbs.h | 121 ++-
2 files changed, 146 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
On Wed, Jul 3, 2013 at 10:26 PM, Roland Dreier rol...@kernel.org wrote:
On Wed, Jul 3, 2013 at 9:41 AM, Or Gerlitz ogerl...@mellanox.com wrote:
Jack looked on this comment/code and he says that the active flag is used
to prevent re-scheduling the timer from inside the timer handling routine
From: Jack Morgenstein ja...@dev.mellanox.co.il
Continue the approach taken by commit d2b57063e4a IB/core: Reserve bits in
enum ib_qp_create_flags for low-level driver use and reserved entries to
the ib_qp_type and ib_wr_opcode enums. The low-level drivers will then define
macros to use these
Hi Roland,
Here's V3 of the mlx5 driver, with Dave's, Joe's and yours comments addressed.
Hoping that would be all for getting this into 3.11
Jack, Moshe and Or.
changes from V2:
- Addressed feedback from Joe Perches:
* Added parentheses around sizeof
* Removed unnecessary do-while for
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 545 ++
drivers/infiniband/hw/mlx5/mr.c | 1014
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx5/ah.c | 92
drivers/infiniband/hw/mlx5/cq.c | 843
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
Signed-off-by: Jack Morgenstein ja...@dev.melanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
MAINTAINERS | 10 ++
drivers/infiniband/Kconfig |1 +
drivers
From: Eli Cohen e...@mellanox.com
Signed-off-by: Eli Cohen e...@mellanox.com
Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c | 1504 +
drivers/infiniband/hw/mlx5
Hi Roland,
There's a typo in Jack's email address which is our mistake, was in V3
9/9, please fix
it to be Jack Morgenstein ja...@dev.mellanox.co.il (the error is
missing l in mellanox)
thanks,
Or.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a
901 - 1000 of 2157 matches
Mail list logo
