Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
On 1/19/2014 5:42 AM, Nicholas A. Bellinger wrote:
On Sat, 2014-01-18 at 13:42 -0800, Roland Dreier wrote:
On Thu, Jan 16, 2014 at 1:14 PM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
I've reviewed the API from the perspective of what's required for
implementing protection support in
On 1/19/2014 12:37 PM, Sagi Grimberg wrote:
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
On 1/22/2014 2:43 AM, Roland Dreier wrote:
On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz or.gerl...@gmail.com wrote:
Roland, ping! the signature patches were posted three months ago. We
deserve a response from the maintainer that goes beyond I need to
think on that.
Responsiveness was stated by
On 1/29/2014 4:13 PM, Bart Van Assche wrote:
On 01/28/14 22:02, Or Gerlitz wrote:
Roland, ping! the signature patches were posted three months ago.
I have a question about RDMA and T10-DIF support. The Linux block layer,
the Linux SCSI core, Linux filesystems and block drivers all support
This is not going to be supported soon - so drop it.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c |1 -
include/target/target_core_base.h |6 --
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/target/target_core_sbc.c b
No need to actually compute protection information when formatting
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_file.c | 40 +
1 files changed, 1 insertions(+), 39 deletions(-)
diff --git a/drivers/target/target_core_file.c
In case protection information is involved, allocate
protection SG-list for transport.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_transport.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/target
SBC-3 mandates the protection checks that must be
performed in the rdprotect/wrprotect field. Use them.
According to backstore device pi_attributes and
cdb rdprotect/wrprotect.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c | 88
-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 104 +++
drivers/infiniband/ulp/isert/ib_isert.h | 23 ++-
2 files changed, 110 insertions(+), 17 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we don't ask
for these completions, but for T10-PI we will.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 238 +++
drivers/infiniband/ulp/isert/ib_isert.h | 14 ++-
2 files changed, 127 insertions(+), 125 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp
).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c |3 ---
drivers/target/target_core_transport.c | 21 +
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/target/target_core_sbc.c b/drivers/target
User may enable T10-PI support per network portal group. any connection
established on top of it, will be required to serve protected transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_configfs.c |6 ++
drivers/target/iscsi
. This is a hook for the iscsi target layer to signal the transport
at connection establishment that this connection will carry protected
transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_core.h |5 -
drivers/target/iscsi/iscsi_target_tpg.c |2 ++
2
On 2/18/2014 7:05 PM, Bart Van Assche wrote:
On 02/18/14 17:47, Sebastian Riemer wrote:
I've also noticed the added target locking around target-free_tx
handling in srp_rport_reconnect(). There are cases e.g. in
srp_queuecommand() where holding the rport mutex isn't enough to protect
it. So for
In case protection information is involved, allocate
protection SG-list for transport.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_transport.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/target
completion check the signature status
- if succeeded send good SCSI response
- if failed send SCSI bad response with appropriate sense buffer
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 321 ---
drivers/infiniband
-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 104 +++
drivers/infiniband/ulp/isert/ib_isert.h | 23 ++-
2 files changed, 110 insertions(+), 17 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers
This is not going to be supported soon - so drop it.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c |1 -
include/target/target_core_base.h |6 --
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/target/target_core_sbc.c b
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index 33f3163..59fdc9f 100644
--- a/drivers/target/target_core_sbc.c
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we don't ask
for these completions, but for T10-PI we will.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
the amount of code in isert_reg_rdma.
- Fixed print of DIF error (sector instead of offset).
- Fix RDMA length for protection on wire domain.
- Refactored reg_sig_mr to use helper routines.
Sagi Grimberg (12):
Target/transport: Allocate protection sg if needed
Target/sbc: Set protection
. This is a hook for the iscsi target layer to signal the transport
at connection establishment that this connection will carry protected
transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_core.h |5 -
drivers/target/iscsi/iscsi_target_tpg.c |2 ++
2
(writes are inserted and reads
are stripped).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c |3 ---
drivers/target/target_core_transport.c | 21 ++---
2 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/drivers/target
-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 238 +++
drivers/infiniband/ulp/isert/ib_isert.h | 14 ++-
2 files changed, 127 insertions(+), 125 deletions(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp
No need to actually compute protection information when formatting
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_file.c | 40 +
1 files changed, 1 insertions(+), 39 deletions(-)
diff --git a/drivers/target/target_core_file.c
SBC-3 mandates the protection checks that must be
performed in the rdprotect/wrprotect field. Use them.
According to backstore device pi_attributes and
cdb rdprotect/wrprotect field.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/target_core_sbc.c | 86
User may enable T10-PI support per network portal group. any connection
established on top of it, will be required to serve protected transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_configfs.c |6 ++
drivers/target/iscsi
On 2/20/2014 1:14 AM, Nicholas A. Bellinger wrote:
On Wed, 2014-02-19 at 17:50 +0200, Sagi Grimberg wrote:
Hey Nic,
I addressed your comments in the this set. I'll try to send the
initiator code for review in the next couple of days.
This patchset introduces target side T10-PI offload support
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers
As a preliminary step for signature feature which will
reuqire posting multiple (3) WQEs for a single WR, we
break post_send routine WQE indexing into begin and
finish routines.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband
that the actual data transfer has finished.
issue: 333508
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c |8 ++
include/rdma/ib_verbs.h | 149 ++-
2 files changed, 156 insertions(+), 1 deletions(-)
diff --git
: Changed signature error processing via MR radix lookup.
Sagi Grimberg (10):
IB/core: Introduce protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
IB/mlx5: Initialize mlx5_ib_qp signature related
IB/mlx5: Break wqe handling
This will be useful when processing signature errors
on a specific key. The mlx5 driver will lookup the
matching mlx5 memory region structure and mark it as
dirty (contains signature errors).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx5/core/main.c
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This commit does not add/change functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h |3 +++
drivers/infiniband/hw/mlx5/qp.c | 12 +---
include/linux/mlx5/qp.h |1 +
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h
b
will be applicable for a new REG_SIG_MR
work request introduced later in this patchset.
In the future these routines may replace or implement current memory
regions creation routines existing today:
- ib_reg_user_mr
- ib_alloc_fast_reg_mr
- ib_get_dma_mr
- ib_dereg_mr
Signed-off-by: Sagi Grimberg sa
, that will mean
that the created ib_mr may be attached with signature attributes
(BSF, PSVs).
Currently we only allow direct/indirect registration modes.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c|2 +
drivers/infiniband/hw/mlx5/mlx5_ib.h
.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 422 +++
include/linux/mlx5/qp.h | 61 ++
2 files changed, 483 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband
, it will not be allowed to use
the memory region for another signature operation
(REG_SIG_MR work request will fail).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/cq.c | 63 ++
drivers/infiniband/hw/mlx5/main.c|1 +
drivers/infiniband/hw
).
This may introduces corruption in free_tx IUs list and IU itself
Signed-off-by: Vu Pham vuhu...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/ulp/srp
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59 insertions(+), 42 deletions(-)
diff --git a/drivers
support to SCSI midlayer according to
IB device capabilities.
Sagi Grimberg (11):
IB/iser: Avoid FRWR notation, use fastreg instead
IB/iser: Push the desicion what memory key to use into fast_reg_mr
routine
IB/iser: Move fast_reg_descriptor initialization to a function
IB/iser: Keep IB
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
Detected by Coverity.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index 0e20bfb..b615135 100644
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
indicators rather than keeping multiple bools.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h |1 +
drivers/infiniband
Hey Bart,
Here are three more fixes for kernel 3.15. These are the patches
Sebastian was referring to.
Sagi Grimberg (2):
IB/srp: Fix crash when unmapping data loop
IB/srp: Check ib_query_gid return value
Vu Pham (1):
IB/srp: Protect free_tx iu list from concurrent flows
drivers
were used on this request)
and only increment when needed.
This crash is easily reproduceable with SRIOV OR Connect-IB
(where FMRs are not supported)
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |5 -
1 files changed, 4 insertions(+), 1 deletions
Once the iSCSI transaction is completed we must
imeplement check_protection in order to notify
on DIF errors that may have occured.
The routine boils down to calling ib_check_mr_status
to get the signature status of the transaction.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
phase, it is worth considering passing these
parameters from iscsid via nlmsg. This will allow these
parameters to be connection based rather than global.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c |8
drivers/infiniband/ulp/iser
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_verbs.c | 58
: APPTAG_CHECK_FAILED
- 0x3: REFTAG_CHECK_FAILED
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/scsi/libiscsi.c | 32
include/scsi/libiscsi.h |4
include/scsi/scsi_transport_iscsi.h |1 +
3 files changed, 37
After allocating a scsi_host we set protection types
and guard type supported.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/ulp/iser
On 2/24/2014 8:46 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote:
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
and we increase the effective SQ size, but still
limit the user max_send_wr
On 2/24/2014 9:01 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote:
This patchset Introduces Verbs level support for signature handover feature.
Siganture is intended to implement end-to-end data integrity on a transactional
basis in a completely offloaded
On 2/24/2014 9:30 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-02-23 at 22:53 -0800, Nicholas A. Bellinger wrote:
On Sun, 2014-02-23 at 14:19 +0200, Sagi Grimberg wrote:
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
Hey Bart,
Here are three more fixes for kernel 3.15. These are the patches
Sebastian was referring to.
Changes from v0:
- Fix typos in commit message
Sagi Grimberg (2):
IB/srp: Fix crash when unmapping data loop
IB/srp: Check ib_query_gid return value
Vu Pham (1):
IB/srp: Protect free_tx
means that FMRs were used on this request)
and only increment when needed.
This crash is easily reproduceable with ConnectX VFs OR
Connect-IB (where FMRs are not supported)
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |5 -
1 files changed, 4
Detected by Coverity.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index 0e20bfb..b615135 100644
).
This may introduces corruption in free_tx IUs list and IU itself
Signed-off-by: Vu Pham vuhu...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/srp/ib_srp.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/ulp/srp
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59
This routines operates on data buffers and may also work with
protection infomation buffers. So we generalize them to handle
an iser_data_buf which can be the command data or command protection
information.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa
Once the iSCSI transaction is completed we must
imeplement check_protection in order to notify
on DIF errors that may have occured.
The routine boils down to calling ib_check_mr_status
to get the signature status of the transaction.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
the wire, only CRC is allowed.
In the next phase, it is worth considering passing these
parameters from iscsid via nlmsg. This will allow these
parameters to be connection based rather than global.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
indicators rather than keeping multiple bools.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al
.
In addition Introduce iser_reg_sig_mr which performs fast
registration work-request for a signature enabled memory region
(IB_WR_REG_SIG_MR). In this routine we set all the protection
relevants for the device to offload protection data-transfer
and verification.
Signed-off-by: Sagi Grimberg sa
: APPTAG_CHECK_FAILED
- 0x3: REFTAG_CHECK_FAILED
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/scsi/libiscsi.c | 32
include/scsi/libiscsi.h |4
include/scsi
Unaligned SG-lists may also happen for protection
information. Genrelize bounce buffer routine to handle
any iser_data_buf which may be data and/or protection.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser
Tabachnik (2):
IB/iser: Introduce pi_enable, pi_guard module parameters
IB/iser: Initialize T10-PI resources
Sagi Grimberg (11):
IB/iser: Avoid FRWR notation, use fastreg instead
IB/iser: Push the desicion what memory key to use into fast_reg_mr
routine
IB/iser: Move fast_reg_descriptor
From: Alex Tabachnik al...@mellanox.com
During connection establishment we also initiatlize
T10-PI resources (QP, PI contexts) in order to support
SCSI's protection operations.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
After allocating a scsi_host we set protection types
and guard type supported.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++-
1 files changed, 22 insertions(+), 1
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
On 2/24/2014 5:24 PM, Bart Van Assche wrote:
On 02/24/14 15:30, Sagi Grimberg wrote:
When unmapping request data, it is unsafe automatically
decrement req-nfmr regardless of it's value. This may
happen since IO and reconnect flow may run concurrently
resulting in req-nfmr = -1 and falsely call
On 2/24/2014 5:38 PM, Bart Van Assche wrote:
On 02/24/14 15:30, Sagi Grimberg wrote:
From: Vu Pham vuhu...@mellanox.com
srp_reconnect_rport() serializes calls of srp_rport_reconnect()
with srp_queuecommand(), srp_abort(), srp_reset_device(),
srp_reset_host() via rport-mutex and also blocks
On 3/3/2014 6:41 AM, Mike Christie wrote:
On 02/27/2014 05:13 AM, Sagi Grimberg wrote:
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 4046241..a58a6bb 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -395,6 +395,10 @@ static int iscsi_prep_scsi_cmd_pdu
On 3/3/2014 6:44 AM, Mike Christie wrote:
On 02/27/2014 05:13 AM, Sagi Grimberg wrote:
diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c
b/drivers/infiniband/ulp/iser/iser_initiator.c
index 58e14c7..7fd95fe 100644
--- a/drivers/infiniband/ulp/iser/iser_initiator.c
+++ b/drivers
On 3/4/2014 9:49 AM, Or Gerlitz wrote:
On 04/03/2014 02:01, Nicholas A. Bellinger wrote:
This is necessary because even though IB_SEND_SIGNALED is
not set for RDMA WRITEs + READs, during a QP failure event
the work requests will be returned with exception status
from the TX completion queue.
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the above map
calls fail then you would get infinite retries. You would currently want
to do the mapping in the init_task callout instead.
If it makes it
On 3/4/2014 1:25 PM, Or Gerlitz wrote:
On 04/03/2014 11:59, Sagi Grimberg wrote:
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the
above map
calls fail then you would get infinite retries. You would
.
This is necessary because even though IB_SEND_SIGNALED is not
set for either work request, during a QP failure event the work
requests will be returned with exception status from the TX
completion queue.
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser-target code that have come up recently during stress testing.
Note there is still a seperate iser-target
On 3/4/2014 6:16 PM, Or Gerlitz wrote:
On 04/03/2014 16:44, Sagi Grimberg wrote:
@@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host
*host, struct scsi_cmnd *sc)
goto prepd_fault
On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote:
On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote:
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser
Unaligned SG-lists may also happen for protection
information. Genrelize bounce buffer routine to handle
any iser_data_buf which may be data and/or protection.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser
the block layer merges bios.
- Don't fail connections on devices without DIF support - warn and continue
without DIF.
- reword FR - FastReg
Alex Tabachnik (2):
IB/iser: Introduce pi_enable, pi_guard module parameters
IB/iser: Initialize T10-PI resources
Sagi Grimberg (11):
IB/iser: Avoid FRWR
Once the iSCSI transaction is completed we must
imeplement check_protection in order to notify
on DIF errors that may have occured.
The routine boils down to calling ib_check_mr_status
to get the signature status of the transaction.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
indicators rather than keeping multiple bools.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59
: APPTAG_CHECK_FAILED
- 0x3: REFTAG_CHECK_FAILED
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/scsi/libiscsi.c | 32
include/scsi/libiscsi.h |4
include/scsi
From: Alex Tabachnik al...@mellanox.com
During connection establishment we also initiatlize
T10-PI resources (QP, PI contexts) in order to support
SCSI's protection operations.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp
After allocating a scsi_host we set protection types
and guard type supported.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++-
1 files changed, 22 insertions(+), 1
This routines operates on data buffers and may also work with
protection infomation buffers. So we generalize them to handle
an iser_data_buf which can be the command data or command protection
information.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa
the wire, only CRC is allowed.
In the next phase, it is worth considering passing these
parameters from iscsid via nlmsg. This will allow these
parameters to be connection based rather than global.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
101 - 200 of 1199 matches
Mail list logo
