From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com]
Sent: Monday, July 06, 2015 4:59 PM
To: Wan, Kaike
Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira
Subject: Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests
through netlink
+/* Local service
+/* Local service status attribute */
+enum {
+ LS_NLA_STATUS_SUCCESS = 0,
+ LS_NLA_STATUS_EINVAL,
+ LS_NLA_STATUS_ENODATA,
+ LS_NLA_STATUS_MAX
+};
So, this is never used, there seems to be a bunch of never used stuff
- please audit everything and get rid of the cruft
From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com]
Sent: Friday, July 03, 2015 5:16 PM
To: Wan, Kaike
Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira
Subject: Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests
through netlink
On Tue, Jun 30, 2015
On Tue, Jun 30, 2015 at 09:45:52AM -0400, kaike@intel.com wrote:
@@ -7,12 +7,14 @@ enum {
RDMA_NL_RDMA_CM = 1,
RDMA_NL_NES,
RDMA_NL_C4IW,
+ RDMA_NL_SA,
I think this should be RDMA_NL_LS to be consistent with the rest, the
SA resolve OP should be something like:
include/uapi/rdma/rdma_netlink.h | 87
++
1 files changed, 87 insertions(+), 0 deletions(-)
diff --git a/include/uapi/rdma/rdma_netlink.h
b/include/uapi/rdma/rdma_netlink.h
index 6e4bb42..d2c50e9 100644
--- a/include/uapi/rdma/rdma_netlink.h
+++
From: Hefty, Sean
Sent: Tuesday, June 30, 2015 1:17 PM
To: Wan, Kaike; linux-rdma@vger.kernel.org
Cc: Wan, Kaike; Fleck, John; Weiny, Ira
Subject: RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests
through netlink
include/uapi/rdma/rdma_netlink.h | 87
