RE: [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle

2016-07-05 Thread MyungJoo Ham
> > - Original Message - > Sender : Peter Chen > Date : 2016-07-01 18:49 (GMT+9) > Title : [PATCH 7/7] devfreq: exynos-bus: add missing of_node_put after > calling of_parse_phandle > > of_node_put needs to be called when the device node which is got >

RE: [PATCH 6/7] devfreq: add missing of_node_put after calling of_parse_phandle

2016-07-05 Thread MyungJoo Ham
> - Original Message - > Sender : Peter Chen > Date : 2016-07-01 18:49 (GMT+9) > Title : [PATCH 6/7] devfreq: add missing of_node_put after calling > of_parse_phandle > > of_node_put needs to be called when the device node which is got > from

[PATCH 7/7] ASoC: rsrc-card: use asoc_simple_card_parse_card_name()

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/rsrc-card.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/sh/rcar/rsrc-card.c

[PATCH 5/7] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto simple-card needs to get its card name. This patch makes this method simple style standard. Signed-off-by: Kuninori Morimoto --- previous -> this - check card->dai_link

[PATCH 4/7] ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/rsrc-card.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/sound/soc/sh/rcar/rsrc-card.c

[PATCH 3/7] ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name()

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/rsrc-card.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/sound/soc/sh/rcar/rsrc-card.c

[PATCH 2/7] ASoC: simple-card: use asoc_simple_card_parse_dailink_name()

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto Signed-off-by: Kuninori Morimoto --- sound/soc/generic/simple-card.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/sound/soc/generic/simple-card.c

[PATCH 1/7] ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name()

2016-07-05 Thread Kuninori Morimoto
From: Kuninori Morimoto Current simple-card is creating dai_link->name / dai_link->stream_name. These are based on CPU + Codec name, or "fe.CPU" or "be.Codec" if it was DPCM. This patch adds asoc_simple_card_set_dailink_name() and set dailink name as common

[PATCH 0/7] ASoC: simple: dailink_name and card_name

2016-07-05 Thread Kuninori Morimoto
Hi Mark These are for dailink_name and card_name cleanup for simple-card. 1) - 3) : for dailink_name 4) : tidyup 5) - 7) : for card_name Kuninori Morimoto (7): 1) ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name() 2) ASoC: simple-card: use

Re: [PATCH 3/6] ASoC: simple-card-utils: add asoc_simple_card_parse_dailink_name()

2016-07-05 Thread Kuninori Morimoto
Hi Mark > > Please let me know if your favored style is name format should be > > handled on each sound card, not in utils.c > > I can arrange it. > > I'd definitely prefer to limit the usage of DPCM in generic code so > keeping it in the card seems safer. As you wish !! I will do it in next

[PATCH v2 1/2] ARM: dts: r8a7792: add GPIO clocks

2016-07-05 Thread Sergei Shtylyov
Describe the GPIO clocks in the R8A7792 device tree. Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven --- Changes in version 2: - converted stray spaces to a tab; - added Geert's tag. arch/arm/boot/dts/r8a7792.dtsi |

[PATCH] gpio: rcar: document R8A7792 support

2016-07-05 Thread Sergei Shtylyov
Renesas R8A7792 SoC is a member of the R-Car gen2 family that is supported by the Renesas R-Car GPIO driver. Signed-off-by: Sergei Shtylyov --- The patch is against the 'devel' branch of Linus Walleij's 'linux-gpio.git' repo.

Re: [PATCH 3/7] arm: mach-u300: regulator: add missing of_node_put after calling of_parse_phandle

2016-07-05 Thread Linus Walleij
On Fri, Jul 1, 2016 at 11:41 AM, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Linus Walleij > Signed-off-by: Peter Chen Acked-by: Linus

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add EtherAVB pin groups

2016-07-05 Thread Linus Walleij
On Tue, Jul 5, 2016 at 5:46 PM, Geert Uytterhoeven wrote: > On Tue, Jul 5, 2016 at 4:54 PM, Linus Walleij > wrote: >> On Tue, Jul 5, 2016 at 8:57 AM, Geert Uytterhoeven >> wrote: >>> Hi Sergei, >>> >>> On Mon, Jul 4, 2016

Re: [PATCH 0/2] Add R8A7792 GPIO support

2016-07-05 Thread Sergei Shtylyov
Hello. On 07/05/2016 12:10 AM, Sergei Shtylyov wrote: Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, 'renesas-devel-20160704-v4.7-rc6' tag. We're adding the R8A7792 GPIO clocks and device nodes. These patches depend on the R8A7792/Blanche PFC patchset in order to

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add EtherAVB pin groups

2016-07-05 Thread Geert Uytterhoeven
Hi Linus, On Tue, Jul 5, 2016 at 4:54 PM, Linus Walleij wrote: > On Tue, Jul 5, 2016 at 8:57 AM, Geert Uytterhoeven > wrote: >> Hi Sergei, >> >> On Mon, Jul 4, 2016 at 9:52 PM, Sergei Shtylyov >> wrote: >>>

Re: [PATCH v2] gpio: convince line to become input in irq helper

2016-07-05 Thread Linus Walleij
I sent a patch for the direction setter to be more careful, but it's no silver bullet for strange semantics. On Tue, Jul 5, 2016 at 12:07 PM, Geert Uytterhoeven wrote: > [1] gpio_rcar e6052000.gpio: sense irq = 11, type = 8 > ravb e680.ethernet eth0: Base address

Re: [PATCH v2 3/3] ARM: dts: blanche: add Ethernet pins

2016-07-05 Thread Sergei Shtylyov
On 07/05/2016 10:29 AM, Geert Uytterhoeven wrote: Add the (previously omitted) pin data for the SMSC LAN89218 Ethernet chip to the Blanche board's device tree: the chip's IRQ output is connected to the SoC's IRQ0 pin and its nCS input is connected to the SoC's EX_CS0# pin. Signed-off-by:

Re: [PATCH 3/6] ASoC: simple-card-utils: add asoc_simple_card_parse_dailink_name()

2016-07-05 Thread Mark Brown
On Tue, Jul 05, 2016 at 12:24:54AM +, Kuninori Morimoto wrote: > Please let me know if your favored style is name format should be > handled on each sound card, not in utils.c > I can arrange it. I'd definitely prefer to limit the usage of DPCM in generic code so keeping it in the card seems

Re: [PATCH 07/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

2016-07-05 Thread Mark Brown
On Mon, Jul 04, 2016 at 08:59:53AM +, Kuninori Morimoto wrote: > > If we try to dereference card->dai_link without checking to see if it's > > set then we'll crash. > Ahh, do you mean we need like this ? > if (!card->name && card->dai_link) > card->name = card->dai_link->name; Yes,

Re: [PATCH/RFC v2 5/5] mmc: renesas_sdhi: add support for R-Car Gen3 SDHI DMAC

2016-07-05 Thread Geert Uytterhoeven
On Thu, Jun 30, 2016 at 12:05 AM, Simon Horman wrote: > --- a/drivers/mmc/host/sh_mobile_sdhi.c > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > +static int sh_mobile_sdhi_init_dma(enum tmio_mmc_dmac_type dmac_type) > +{ > + switch (dmac_type) { > + case

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add EtherAVB pin groups

2016-07-05 Thread Sergei Shtylyov
Hello. On 7/5/2016 9:57 AM, Geert Uytterhoeven wrote: Add the EtherAVB pin groups to the R8A7792 PFC driver. Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven However, you forgot to add the avb_avtp_match group. Is

Re: [PATCH v2] gpio: convince line to become input in irq helper

2016-07-05 Thread Geert Uytterhoeven
Hi Linus, On Wed, Jun 22, 2016 at 11:25 PM, Linus Walleij wrote: > The generic IRQ helper library just checks if the IRQ line is > set as input before activating it for interrupts. As we > recently started to check things better with .get_dir() it > turns out that it's

Re: [PATCH 2/2] ARM: dts: r8a7792: add EtherAVB support

2016-07-05 Thread Geert Uytterhoeven
On Mon, Jul 4, 2016 at 11:23 PM, Sergei Shtylyov wrote: > Define the generic R8A7792 part of the EtherAVB device node. > > Based on the commit 89aac8af1a60 ("ARM: dts: r8a7794: add EtherAVB support"). > > Signed-off-by: Sergei Shtylyov

Re: [PATCH 1/2] ARM: dts: r8a7792: add EtherAVB clocks

2016-07-05 Thread Geert Uytterhoeven
On Mon, Jul 4, 2016 at 11:22 PM, Sergei Shtylyov wrote: > Add the EtherAVB clock and its parent, HP clock to the R8A7792 device tree. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven

Re: [PATCH 2/2] ARM: dts: r8a7792: add GPIO support

2016-07-05 Thread Geert Uytterhoeven
On Mon, Jul 4, 2016 at 11:12 PM, Sergei Shtylyov wrote: > Describe all 12 GPIO controllers in the R8A7792 device tree. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven

Re: renesas-drivers-2016-06-28-v4.7-rc5

2016-07-05 Thread Geert Uytterhoeven
Hi Morimoto-san, On Tue, Jul 5, 2016 at 9:31 AM, Kuninori Morimoto wrote: >> Currently I provide e.g.: >> >> topic/salvator-x-hdmi-prototype-drivers-v3-rebased2 >> topic/salvator-x-hdmi-prototype-integration-v3-rebased4 >> >> The drivers branch needs only a

Re: [PATCH 1/2] ARM: dts: r8a7792: add GPIO clocks

2016-07-05 Thread Geert Uytterhoeven
On Mon, Jul 4, 2016 at 11:11 PM, Sergei Shtylyov wrote: > Describe the GPIO clocks in the R8A7792 device tree. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: renesas-drivers-2016-06-28-v4.7-rc5

2016-07-05 Thread Kuninori Morimoto
Hi Geert > Currently I provide e.g.: > > topic/salvator-x-hdmi-prototype-drivers-v3-rebased2 > topic/salvator-x-hdmi-prototype-integration-v3-rebased4 > > The drivers branch needs only a rebase when Laurent's for/renesas-drivers > changes, while the integration branch needs a rebase after

Re: [PATCH v2 3/3] ARM: dts: blanche: add Ethernet pins

2016-07-05 Thread Geert Uytterhoeven
Hi Sergei, On Mon, Jul 4, 2016 at 10:55 PM, Sergei Shtylyov wrote: > Add the (previously omitted) pin data for the SMSC LAN89218 Ethernet chip > to the Blanche board's device tree: the chip's IRQ output is connected to > the SoC's IRQ0 pin and its nCS input is

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add EtherAVB pin groups

2016-07-05 Thread Geert Uytterhoeven
Hi Sergei, On Mon, Jul 4, 2016 at 9:52 PM, Sergei Shtylyov wrote: > Add the EtherAVB pin groups to the R8A7792 PFC driver. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven

Re: renesas-drivers-2016-06-28-v4.7-rc5

2016-07-05 Thread Geert Uytterhoeven
Hi Morimoto-san, On Tue, Jul 5, 2016 at 3:40 AM, Kuninori Morimoto wrote: >> I have pushed renesas-drivers-2016-06-28-v4.7-rc5 to >> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git >> >> This tree is meant to ease development of platform