Re: [PATCH 1/8] drm: bridge: Add LVDS encoder driver

2016-10-20 Thread Archit Taneja
On 10/19/2016 07:55 PM, Laurent Pinchart wrote: The LVDS encoder driver is a DRM bridge driver that supports the parallel to LVDS encoders that don't require any configuration. The driver thus doesn't interact with the device, but creates an LVDS connector for the panel and exposes its size and

Re: [PATCH 2/8] drm: bridge: vga-dac: Add adi,adv7123 compatible string

2016-10-20 Thread Archit Taneja
On 10/19/2016 07:55 PM, Laurent Pinchart wrote: The ADV7123 is a transparent VGA DAC. Unlike dumb VGA DACs it can be controlled through a power save pin, and requires a power supply. However, on most boards where the device is used neither the power save signal nor the power supply are controll

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
> However, for version 3.0 that will be posted shortly, it will start to > include the SDHI section. Nice. Could you ping me when this comes out? > > * Does it have a version register (CTL_VERSION)? If so, what does it > > say? > > 0x820B Okay, this is a version I have not seen before. > >

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
> I'll submit a v4 of this patch series tomorrow. Please wait a little. I'd like to use that feature on R-Car, too, so I wonder if the additional feature flag is the proper path. signature.asc Description: PGP signature

Re: [PATCH v2 2/2] clk: renesas: cpg-mssr: add R8A7743 support

2016-10-20 Thread Sergei Shtylyov
Hello. On 10/19/2016 12:06 PM, Geert Uytterhoeven wrote: Add RZ/G1M (R8A7743) Clock Pulse Generator / Module Standby and Software Reset support, using the CPG/MSSR driver core and the common R-Car Gen2 (and RZ/G) code. Based on the proof-of-concept R8A7791 CPG/MSSR patch by Geert Uytterhoeven

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
Hello Wolfram, > > > + /* if count was multiple of 4 */ > > > + if (!(count & 0x3)) > > > + return; > > > + buf8 = (u8 *)(buf + (count >> 2)); > > > + count %= 4; > > > > To skip the same operation done on 'count' twice, maybe? > > > > bu

Re: [PATCH v2] ARM: shmobile: Consolidate R8A7743 and R8A779[234] machine definitions

2016-10-20 Thread Sergei Shtylyov
Hello. On 10/20/2016 11:58 AM, Simon Horman wrote: The four SoCs use identical machine operations, consolidate them into two machine definitions in a single file. Signed-off-by: Laurent Pinchart Tested-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- Changes since v1: - Rebased on top

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
On 10/20/2016, Wolfram Sang wrote: > Sadly, I don't have SDHI documentation for this SoC. In the current hardware manual on renesas.com, the SHDI section is not included. However, for version 3.0 that will be posted shortly, it will start to include the SDHI section. > * Does it have a version

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
On Mon, Sep 12, 2016 at 10:15:06AM -0400, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses are > not sup

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-10-20 Thread Wolfram Sang
On Mon, Sep 12, 2016 at 10:15:05AM -0400, Chris Brandt wrote: > In moving platforms from board files to DT, there still needs to be a way > to set the ocr_mask setting for the tmio driver during probe. Without this > setting, the probe will fail because the supported voltages are not known. > > Th

Re: [PATCH 4/8] drm: Add encoder_type field to the drm_bridge structure

2016-10-20 Thread Archit Taneja
Hi, On 10/19/2016 07:55 PM, Laurent Pinchart wrote: The drm_bridge object models on- or off-chip hardware encoders and provide an abstract control API to display drivers. In order to help display drivers creating the right kind of drm_encoder object, expose the type of the hardware encoder assoc

Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property

2016-10-20 Thread Laurent Pinchart
Hi Simon, On Thursday 20 Oct 2016 10:42:30 Simon Horman wrote: > Hi Laurent, > > On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote: > > The system uses one address cell and one size cell, not two. Fix the DU > > DT node. > > Do you want to handle this as a fix for v4.9? If so shal

Re: [PATCH v3 0/11] Add R8A7743/SK-RZG1M board support

2016-10-20 Thread Geert Uytterhoeven
Hi Simon, On Thu, Oct 20, 2016 at 11:24 AM, Simon Horman wrote: > On Wed, Oct 12, 2016 at 11:29:56AM +0300, Sergei Shtylyov wrote: >> On 10/12/2016 11:09 AM, Simon Horman wrote: >> >>> Here's the set of 11 patches against Simon Horman's 'renesas.git' repo's >> >>>'renesas-devel-20161003-v4.8' ta

Re: [PATCH v3 0/11] Add R8A7743/SK-RZG1M board support

2016-10-20 Thread Simon Horman
On Wed, Oct 12, 2016 at 11:29:56AM +0300, Sergei Shtylyov wrote: > On 10/12/2016 11:09 AM, Simon Horman wrote: > > >>> Here's the set of 11 patches against Simon Horman's 'renesas.git' repo's > >>>'renesas-devel-20161003-v4.8' tag. I'm adding the device tree support for > >>>the R8A7743-based SK-

Re: [PATCH v3 0/2] arm64: dts: add support for eMMC with 8 bit bus width

2016-10-20 Thread Simon Horman
On Sun, Oct 16, 2016 at 10:27:46AM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > Since the MMC core parts for eMMC 8 bit support are now upstream, we can also > pull in the DTS changes. The patches are also in renesas/drivers > (0dca0dbaac8269 and 9dea74f4b9eb79), so could be picked from th

Re: [PATCH v7 10/11] arm64: dts: r8a7796: salvator-x: enable UHS for SDHI 0 & 3

2016-10-20 Thread Simon Horman
On Fri, Sep 16, 2016 at 12:33:17PM +0200, Wolfram Sang wrote: > On Tue, Sep 13, 2016 at 12:57:07PM +0200, Simon Horman wrote: > > Based on work for the r8a7796 by Wolfram Sang. > > > > Cc: Wolfram Sang > > Signed-off-by: Simon Horman > > Reviewed-by: Wolfram Sang Thanks, I have queued this up

Re: [PATCH v7 08/11] arm64: dts: r8a7796: add SDHI nodes

2016-10-20 Thread Simon Horman
On Fri, Sep 16, 2016 at 12:53:22PM +0200, Simon Horman wrote: > On Fri, Sep 16, 2016 at 12:30:48PM +0200, Wolfram Sang wrote: > > On Tue, Sep 13, 2016 at 12:57:05PM +0200, Simon Horman wrote: > > > Add SDHI nodes to the DT of the r8a7796 SoC. > > > > > > Based on the DT of the r8a7795 SoC. > > >

Re: [PATCH v7 09/11] arm64: dts: r8a7796: salvator-x: enable SDHI0 & 3

2016-10-20 Thread Simon Horman
On Fri, Sep 16, 2016 at 12:32:18PM +0200, Wolfram Sang wrote: > On Tue, Sep 13, 2016 at 12:57:06PM +0200, Simon Horman wrote: > > Enable the exposed SD card slots in the DT of the r8a7796/salvator-x. > > > > Based on work for the r8a7795/salvator-x by Ai Kyuse. > > > > Signed-off-by: Simon Horman

Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property

2016-10-20 Thread Simon Horman
Hi Laurent, On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote: > The system uses one address cell and one size cell, not two. Fix the DU > DT node. Do you want to handle this as a fix for v4.9? If so shall we add the following? Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU

Re: [PATCH v2 0/3] r8a7793 Gose video input support

2016-10-20 Thread Simon Horman
Hi Ulrich, On Tue, Oct 18, 2016 at 05:02:20PM +0200, Ulrich Hecht wrote: > Hi! > > This is a by-the-datasheet implementation of analog and digital video input > on the Gose board. > > I have tried to address all concerns raised by reviewers, with the exception > of the composite input patch, whi

Re: [PATCH v2 0/2] Renesas Lager/Koelsch HDMI input

2016-10-20 Thread Simon Horman
On Tue, Oct 18, 2016 at 06:17:25PM +0300, Laurent Pinchart wrote: > Hi Ulrich, > > Thank you for the patches. > > For the whole series, > > Reviewed-by: Laurent Pinchart Thanks, series applied with Laurent's tag.

Re: [PATCH v2 2/2] ARM: dts: koelsch: add HDMI input

2016-10-20 Thread Simon Horman
On Wed, Oct 19, 2016 at 09:33:11AM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 18, 2016 at 5:01 PM, Ulrich Hecht > wrote: > > From: Hans Verkuil > > > > Add support in the dts for the HDMI input. Based on the Lager dts > > patch from Ultich Hecht. > > Ulrich ;-) I have queued up this patch w

Re: [PATCH 0/2] R-Car FDP: Remove SoC-specific compatible strings

2016-10-20 Thread Simon Horman
On Mon, Oct 17, 2016 at 11:29:01PM +0300, Laurent Pinchart wrote: > Hello, > > Now that the Gen3 documentation mentions the FCP version register, it's clear > that the SoC instance in which the FCP is integrated can be identified at > runtime without requiring SoC-specific compatible strings. > >

Re: [PATCH 3/4] arm64: dts: renesas: r8a7796: Add DU device to DT

2016-10-20 Thread Simon Horman
On Tue, Oct 18, 2016 at 12:19:26PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Tuesday 18 Oct 2016 11:05:32 Geert Uytterhoeven wrote: > > On Mon, Oct 17, 2016 at 11:34 PM, Laurent Pinchart wrote: > > > Add the DU device to r8a7796.dtsi in a disabled state. > > > > > > Signed-off-by: Laurent

Re: [PATCH v2] ARM: shmobile: Consolidate R8A7743 and R8A779[234] machine definitions

2016-10-20 Thread Simon Horman
On Mon, Oct 17, 2016 at 04:59:04PM +0300, Laurent Pinchart wrote: > The four SoCs use identical machine operations, consolidate them into > two machine definitions in a single file. > > Signed-off-by: Laurent Pinchart > Tested-by: Simon Horman > Reviewed-by: Geert Uytterhoeven > --- > Changes s