Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-03-05 Thread Kuninori Morimoto
Hi Laurent, Kieran > > > Testing SRU-UDS scaling 768x576 - 768x576 - 640x480 in RGB24: fail > > > Testing SRU-UDS scaling 768x576 - 768x576 - 768x576 in RGB24: pass > > > Testing SRU-UDS scaling 768x576 - 768x576 - 1024x768 in RGB24: pass > > > Testing SRU-UDS scaling 768x576 - 1536x1152 -

RE: [PATCH] phy: core: fix the condition to enable pm_runtime in phy_create()

2017-03-05 Thread Yoshihiro Shimoda
Hi, > From: Yoshihiro Shimoda > Sent: Friday, March 03, 2017 8:33 PM > > This patch fixes an issue that phy_create() never enables the pm_runtime. > And then, we can remove calling the pm_runtime_{en,dis}able from some > phy drivers. > > Fixes: ff764963479a ("drivers: phy: add generic PHY

[GIT PULL FOR renesas-drivers] DU + VSP display flicker fixes

2017-03-05 Thread Laurent Pinchart
://linuxtv.org/pinchartl/media.git tags/drm-next-du-vsp-v3-20170305 for you to fetch changes up to 6208a2aec17b45be0d10921135c112c57138bca0: drm: rcar-du: Register a completion callback with VSP1 (2017-03-06 03:05:58 +0200) Kieran Bingham (4

[GIT PULL FOR renesas-drivers] VSP1 rotation and histogram

2017-03-05 Thread Laurent Pinchart
Hi Geert, The following changes since commit 130f8756b9b83c0137ee0d587152a7ef3e10f74b: v4l: vsp1: Register pipe with output WPF (2017-03-05 01:53:46 +0200) are available in the git repository at: git://linuxtv.org/pinchartl/media.git vsp1/histogram for you to fetch changes up to

[PATCH v2.1 3/3] v4l: vsp1: wpf: Implement rotation support

2017-03-05 Thread Laurent Pinchart
Some WPF instances, on Gen3 devices, can perform 90° rotation when writing frames to memory. Implement support for this using the V4L2_CID_ROTATE control. Signed-off-by: Laurent Pinchart --- Changes since v2: - Store controls in distinct fields instead

[GIT PULL FOR renesas-drivers] R-Car Gen3 HDMI output support

2017-03-05 Thread Laurent Pinchart
Hi Geert, Please find two pull requests below for renesas-drivers (in a single e-mail, lucky you :-)). The first tag contains driver changes only and is based on a merge of drm-next and drm-misc-next. The 5 patches from Maarten Lankhorst should be merged in drm-misc-next tomorrow (if all goes

[PATCH v3 2/5] arm64: dts: r8a7795: salvator-x: Enable HDMI outputs

2017-03-05 Thread Laurent Pinchart
From: Koji Matsuoka Instantiate the HDMI connectors and enable the encoders. Signed-off-by: Koji Matsuoka Signed-off-by: Ulrich Hecht Signed-off-by: Laurent Pinchart

[PATCH v3 1/5] arm64: dts: r8a7795: Add HDMI encoder support

2017-03-05 Thread Laurent Pinchart
From: Ulrich Hecht Add DT nodes for the two HDMI encoders in disabled state. Based on work by Koji Matsuoka. Signed-off-by: Ulrich Hecht Signed-off-by: Laurent Pinchart ---

[PATCH v3 5/5] ARM: shmobile: dts: Switch to panel-lvds bindings for Mitsubishi panels

2017-03-05 Thread Laurent Pinchart
The aa104xd12 and aa121td01 panels are LVDS panels, not DPI panels. Use the correct DT bindings. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 3 ++- arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi | 3 ++- 2 files

[PATCH v3 3/5] arm64: dts: r8a7795: salvator-x: Add DU1 and DU2 external dot clocks

2017-03-05 Thread Laurent Pinchart
The DU1 and DU2 external dot clocks are fixed frequency clock generators running at 33MHz. Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 23 ++ 1 file changed, 23 insertions(+) diff --git

[PATCH v3 4/5] arm64: dts: r8a7795: salvator-x: Add DU0 and DU3 external dot clocks

2017-03-05 Thread Laurent Pinchart
The clocks are generated by an I2C-controlled programmable clock generator. Signed-off-by: Laurent Pinchart Reviewed-by: Marek Vasut Reviewed-by: Geert Uytterhoeven ---

[PATCH v3 0/5] R-Car H3 HDMI output DT integration

2017-03-05 Thread Laurent Pinchart
Hello, This patch series contains all the DT changes needed to integrate HDMI output support for the H3 Salvator-X board. The patches have previously been posted as part of other patch series with driver changes. They are now submitted standalone as I expect the driver patches to be merged soon.

[PATCH v3 5/9] dt-bindings: display: renesas: Add R-Car Gen3 HDMI TX DT bindings

2017-03-05 Thread Laurent Pinchart
The Renesas R-Car Gen3 SoCs use a Synopsys DWC HDMI TX encoder IP. Add corresponding device tree bindings based on the DWC HDMI TX bindings model. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring ---

[PATCH v3 9/9] drm: rcar-du: Add HDMI outputs to R8A7795 device description

2017-03-05 Thread Laurent Pinchart
From: Koji Matsuoka Update the device description with the two available HDMI outputs. Signed-off-by: Koji Matsuoka Signed-off-by: Laurent Pinchart ---

[PATCH v3 7/9] drm: rcar-du: Skip disabled outputs

2017-03-05 Thread Laurent Pinchart
When a DT node connected to a DU output is disabled no bridge will ever be instantiated for it. Skip the output in that case. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v3 6/9] drm: rcar-du: Add Gen3 HDMI encoder support

2017-03-05 Thread Laurent Pinchart
From: Koji Matsuoka The R-Car Gen3 SoCs include on-chip DesignWare HDMI encoders. Support them with a platform driver to provide platform glue data to the dw-hdmi driver. The driver is a complete rewrite of code coming from the Renesas BSP, save for the values in

[PATCH v3 8/9] drm: rcar-du: Add DPLL support

2017-03-05 Thread Laurent Pinchart
From: Koji Matsuoka The implementation hardcodes a workaround for the H3 ES1.x SoC regardless of the SoC revision, as the workaround can be safely applied on all devices in the Gen3 family without any side effect. Signed-off-by: Koji Matsuoka

[PATCH v3 4/9] drm: rcar-du: Hardcode encoders types to DRM_MODE_ENCODER_NONE

2017-03-05 Thread Laurent Pinchart
Unlike the connector type, the encoder type is unused by userspace. As it is equally unused in the driver, except in a single location where the connector type can be used instead, hardcode it to DRM_MODE_ENCODER_NONE. This allow removing all code that tries to determine (unsuccessfully in case a

[PATCH v3 0/9] R-Car Gen3 HDMI output support

2017-03-05 Thread Laurent Pinchart
Hello, This patch series implements support for the HDMI output on Renesas R-Car Gen3 SoCs, and more specifically on the R-Car H3. Compared to the previous version, I've left out all the dw-hdmi patches that have been updated separately and are on their way to being merged. I've also left out

[PATCH v3 2/9] drm: rcar-du: Add support for LVDS mode selection

2017-03-05 Thread Laurent Pinchart
Retrieve the LVDS mode from the panel and configure the LVDS encoder accordingly. LVDS mode selection is static as LVDS panels can't be hot-plugged on any of the device supported by the driver. Support for dynamic mode selection can be implemented in the future when needed. Signed-off-by: Laurent

[PATCH v3 1/9] drm: rcar-du: Use the DRM panel API

2017-03-05 Thread Laurent Pinchart
Instead of parsing the panel device tree node manually, use the panel API to delegate panel handling to a panel driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Kconfig | 1 + drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 22

[PATCH v3 3/9] drm: rcar-du: Replace manual bridge implementation with DRM bridge

2017-03-05 Thread Laurent Pinchart
The rcar-du driver contains a manual implementation of HDMI and VGA bridges. Use DRM bridges to replace it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/Kconfig | 6 -- drivers/gpu/drm/rcar-du/Makefile | 5 +-

[PATCH v5.1 04/10] drm: bridge: dw-hdmi: Fix the PHY power down sequence

2017-03-05 Thread Laurent Pinchart
The PHY requires us to wait for the PHY to switch to low power mode after deasserting TXPWRON and before asserting PDDQ in the power down sequence, otherwise power down will fail. The PHY power down can be monitored though the TX_READY bit, available through I2C in the PHY registers, or the

[PATCH v5.1 06/10] drm: bridge: dw-hdmi: Create PHY operations

2017-03-05 Thread Laurent Pinchart
The HDMI TX controller support different PHYs whose programming interface can vary significantly, especially with vendor PHYs that are not provided by Synopsys. To support them, create a PHY operation structure that can be provided by the platform glue layer. The existing PHY handling code

[PATCH v5.1 05/10] drm: bridge: dw-hdmi: Fix the PHY power up sequence

2017-03-05 Thread Laurent Pinchart
When powering the PHY up we need to wait for the PLL to lock. This is done by polling the TX_PHY_LOCK bit in the HDMI_PHY_STAT0 register (interrupt-based wait could be implemented as well but is likely overkill). The bit is asserted when the PLL locks, but the current code incorrectly waits for

Re: [PATCHv2] arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins

2017-03-05 Thread Niklas Söderlund
Hi Simon, On 2016-12-08 14:31:38 +0100, Simon Horman wrote: > On Mon, Dec 05, 2016 at 06:43:10PM +0100, Niklas Söderlund wrote: > > The EthernetAVB should not depend on the bootloader to setup correct > > drive-strength values. Values for drive-strength where found by > > examining the registers

Re: [PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Kieran Bingham
Hi Laurent, On 05/03/17 21:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Sunday 05 Mar 2017 16:00:03 Kieran Bingham wrote: >> To be able to perform page flips in DRM without flicker we need to be >> able to notify the rcar-du module when the VSP has completed its

Re: [PATCH v3 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-05 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Sunday 05 Mar 2017 16:00:04 Kieran Bingham wrote: > Currently we process page flip events on every display interrupt, > however this does not take into consideration the processing time needed > by the VSP1 utilised in the pipeline. > > Register a callback

Re: [PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Sunday 05 Mar 2017 16:00:03 Kieran Bingham wrote: > To be able to perform page flips in DRM without flicker we need to be > able to notify the rcar-du module when the VSP has completed its > processing. > > We must not have bidirectional dependencies on

Re: [PATCH v3 1/3] v4l: vsp1: Postpone frame end handling in event of display list race

2017-03-05 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Sunday 05 Mar 2017 16:00:02 Kieran Bingham wrote: > If we try to commit the display list while an update is pending, we have > missed our opportunity. The display list manager will hold the commit > until the next interrupt. > > In this event, we skip the

[PATCH 2/2] Formatting updates to resolve checkpatch errors in ks_wlan_ioctl.h.

2017-03-05 Thread Matthew Giassa
Updating macros to be wrapped in parentheses to accomodate checkpatch errors throughout the header. This change, combined with the previous patch, resolves all outstanding warnings/errors produce by checkpatch. Signed-off-by: Matthew Giassa ---

[PATCH 1/2] Formatting updates to remove checkpatch warnings in ks_wlan_ioctl.h.

2017-03-05 Thread Matthew Giassa
Implementing some minor formatting changes to remove checkpatch warnings. Removing space-hardtab instances. Removing C++-style line comments in favor of C-style equivalent. Re-aligning function prototype arguments to remove related checkpatch warning. Signed-off-by: Matthew Giassa

[PATCH v2.2] v4l: Clearly document interactions between formats, controls and buffers

2017-03-05 Thread Laurent Pinchart
V4L2 exposes parameters that influence buffers sizes through the format ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly VIDIOC_G_SELECTION and VIDIOC_S_SELECTION). Other parameters not part of the format structure may also influence buffer sizes or buffer layout in general. One

Re: [PATCH v2.1] v4l: Clearly document interactions between formats, controls and buffers

2017-03-05 Thread Sakari Ailus
Hi Laurent, Thanks for the update. On Sun, Mar 05, 2017 at 04:39:36PM +0200, Laurent Pinchart wrote: > V4L2 exposes parameters that influence buffers sizes through the format > ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly > VIDIOC_G_SELECTION and VIDIOC_S_SELECTION). Other

Re: [PATCH v3 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-05 Thread Sergei Shtylyov
Hello! On 03/05/2017 07:00 PM, Kieran Bingham wrote: Currently we process page flip events on every display interrupt, however this does not take into consideration the processing time needed by the VSP1 utilised in the pipeline. Register a callback with the VSP driver to obtain completion

Re: [PATCH v6 3/3] ARM: dts: r7s72100: Add watchdog timer

2017-03-05 Thread Guenter Roeck
On 03/04/2017 02:37 PM, Chris Brandt wrote: Add watchdog timer support for RZ/A1. For the RZ/A1, the only way to do a reset is to overflow the WDT, so this is useful even if you don't need the watchdog functionality. Signed-off-by: Chris Brandt Reviewed-by: Geert

Re: [PATCH v6 2/3] watchdog: renesas-wdt: add support for rza

2017-03-05 Thread Guenter Roeck
On 03/04/2017 02:37 PM, Chris Brandt wrote: Describe the WDT hardware in the RZ/A series. Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven Acked-by: Rob Herring Reviewed-by: Guenter Roeck

Re: [PATCH v6 1/3] watchdog: add rza_wdt driver

2017-03-05 Thread Guenter Roeck
On 03/04/2017 02:37 PM, Chris Brandt wrote: Adds a watchdog timer driver for the Renesas RZ/A Series SoCs. A reset handler is also included since a WDT overflow is the only method for restarting an RZ/A SoC. Signed-off-by: Chris Brandt Reviewed-by: Guenter Roeck

[PATCH v3 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-05 Thread Kieran Bingham
Currently we process page flip events on every display interrupt, however this does not take into consideration the processing time needed by the VSP1 utilised in the pipeline. Register a callback with the VSP driver to obtain completion events, and track them so that we only perform page flips

[PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Kieran Bingham
To be able to perform page flips in DRM without flicker we need to be able to notify the rcar-du module when the VSP has completed its processing. We must not have bidirectional dependencies on the two components to maintain support for loadable modules, thus we extend the API to allow a callback

[PATCH v3 0/3] RCAR-DU, VSP1: Prevent pre-emptive frame flips on VSP1-DRM pipelines

2017-03-05 Thread Kieran Bingham
The RCAR-DU utilises a running VSPD pipeline to perform processing for the display pipeline. This presents the opportunity for some race conditions to affect the quality of the display output. To prevent reporting page flips early, we must track this timing through the VSP1, and only allow the

[PATCH v3 1/3] v4l: vsp1: Postpone frame end handling in event of display list race

2017-03-05 Thread Kieran Bingham
If we try to commit the display list while an update is pending, we have missed our opportunity. The display list manager will hold the commit until the next interrupt. In this event, we skip the pipeline completion callback handler so that the pipeline will not mistakenly report frame completion

[PATCH v2.1] v4l: Clearly document interactions between formats, controls and buffers

2017-03-05 Thread Laurent Pinchart
V4L2 exposes parameters that influence buffers sizes through the format ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly VIDIOC_G_SELECTION and VIDIOC_S_SELECTION). Other parameters not part of the format structure may also influence buffer sizes or buffer layout in general. One

Re: [PATCH v2 2/3] v4l: Clearly document interactions between formats, controls and buffers

2017-03-05 Thread Laurent Pinchart
Hi Hans, On Saturday 04 Mar 2017 11:53:45 Hans Verkuil wrote: > On 28/02/17 16:03, Laurent Pinchart wrote: > > V4L2 exposes parameters that influence buffers sizes through the format > > ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT and VIDIO_S_FMT). Other parameters > > S_SELECTION should be mentioned

Re: [PATCH v2 2/3] v4l: Clearly document interactions between formats, controls and buffers

2017-03-05 Thread Laurent Pinchart
Hi Sakari, On Saturday 04 Mar 2017 15:48:54 Sakari Ailus wrote: > On Sat, Mar 04, 2017 at 11:57:32AM +0100, Hans Verkuil wrote: > ... > > >>> +To simplify their implementation, drivers may also require buffers to > >>> be +reallocated in order to change formats or controls that influence > >>>

Re: [PATCH 0/4] iio: adc: Maxim max961x driver

2017-03-05 Thread Jonathan Cameron
On 27/02/17 09:09, jacopo mondi wrote: > Hi Jonathan, > On 25/02/2017 17:09, Jonathan Cameron wrote: >> On 24/02/17 15:05, Jacopo Mondi wrote: >>> Hello! >>> >>> This series adds driver and documentation for Maxim max9611/max9612 >>> high-side current sense amplifier with 12-bit ADC and I2c

Re: [PATCH] media: platform: Renesas IMR driver

2017-03-05 Thread Magnus Damm
Hi Sergei, Thanks for your efforts with this driver. Nice to see that V2 is getting in better shape. In the future, would it be possible for you to include the patch version number in the [PATCH] tag somehow? On Fri, Mar 3, 2017 at 9:03 PM, Sergei Shtylyov

Re: [PATCH 3/4] iio: adc: Add max9611/9612 ADC driver

2017-03-05 Thread Jonathan Cameron
On 27/02/17 07:45, jacopo mondi wrote: > Hi Jonathan, >thanks for review > > On 25/02/2017 16:53, Jonathan Cameron wrote: >> On 24/02/17 15:05, Jacopo Mondi wrote: >>> Add iio driver for Maxim max9611/9612 current-sense amplifiers with >>> 12-bits ADC. >> Data sheet link always good >>> >>>