Re: [git pull] pinctrl: sh-pfc: Updates for v4.13

2017-05-30 Thread Linus Walleij
On Mon, May 29, 2017 at 1:57 PM, Geert Uytterhoeven wrote: > Hi Linus, > > The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: > > Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/ker

Re: [PATCH 5/7] pci: use proper name for the R-Car SoC

2017-05-30 Thread Bjorn Helgaas
On Sun, May 28, 2017 at 11:30:48AM +0200, Wolfram Sang wrote: > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text. > > Signed-off-by: Wolfram Sang > --- > I suggest this trivial patch should be picked individually per susbsystem. > > Documentation/devicetree/bindings/

Re: [PATCH] mmc: renesas_sdhi_core: on R-Car 2+, make use of CBSY bit

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 11:03:46AM +0200, Wolfram Sang wrote: > Most registers need to wait until the command is completed, not > necessarily until the bus is free. At least, R-Car 2+ SoCs can signal > that via the CBSY bit, so let's use it there instead of SCLKDIVEN to > save a little bit of delay

Re: [PATCH 4/5] mmc: tmio: improve checkpatch cleanness

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 02:50:53PM +0200, Simon Horman wrote: > Trivial updates to improve checkpatch cleanness. > > Signed-off-by: Simon Horman Wow, all of them! When I reviewed your DMA refactoring patches, I meant to fix only the whitespace issues which were affecting your patches. But okay,

Re: [PATCH 5/5] mmc: renesas-sdhi: improve checkpatch cleanness

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 02:50:54PM +0200, Simon Horman wrote: > Trivial updates to improve checkpatch cleanness. > > Signed-off-by: Simon Horman Two comments here: > - /* Orginally registers were 16 bit apart, could be 32 or 64 nowadays */ > - if (!host->bus_shift && resource_size(res)

Re: [PATCH 3/5] mmc: tmio, renesas-sdhi: update Renesas related copyrights

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 02:50:52PM +0200, Simon Horman wrote: > Update copyrights to reflect work by Wolfram Sang and myself since last > year. > > Signed-off-by: Simon Horman Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 2/5] mmc: tmio: use EXPORT_SYMBOL_GPL

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 02:50:51PM +0200, Simon Horman wrote: > Use EXPORT_SYMBOL_GPL rather than the non _GPL variant as there seems to be > no reason not to. > > Signed-off-by: Simon Horman Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 1/5] MAINTAINERS: Update files for TMIO/SDHI MMC driver

2017-05-30 Thread Wolfram Sang
On Tue, May 30, 2017 at 02:50:50PM +0200, Simon Horman wrote: > Update files for tmio/sdhi MMC driver to reflect recent filename > changes. > > Signed-off-by: Simon Horman Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

RE: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-30 Thread Chris Brandt
Hi Geert, As always Thank you for your review! On Monday, May 29, 2017, Geert Uytterhoeven wrote: > > #define R7S72100_CLK_PLL 0 > > No CoreSight (MSTP20)? OK, I'll add that in. > > +#define R7S72100_CLK_MCPWM 0 > > Perhaps just R7S72100_CLK_PWM? OK. People don't seem to be usin

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

2017-05-30 Thread Chris Brandt
Hello Jacopo and Linus, On Monday, May 29, 2017, jmondi wrote: > > > We can handle 'bi-directional' pins with static tables in our pin > > > controller driver and not have it anywhere in DT. > > > > This sounds like a viable approach. > > > > I just want to know if "output-enable" is the right nam

[PATCH 5/5] mmc: renesas-sdhi: improve checkpatch cleanness

2017-05-30 Thread Simon Horman
Trivial updates to improve checkpatch cleanness. Signed-off-by: Simon Horman --- drivers/mmc/host/renesas_sdhi.h | 2 +- drivers/mmc/host/renesas_sdhi_core.c | 48 ++-- drivers/mmc/host/renesas_sdhi_sys_dmac.c | 25 + 3 files changed, 42

[PATCH 4/5] mmc: tmio: improve checkpatch cleanness

2017-05-30 Thread Simon Horman
Trivial updates to improve checkpatch cleanness. Signed-off-by: Simon Horman --- drivers/mmc/host/renesas_sdhi.h | 2 +- drivers/mmc/host/tmio_mmc.c | 8 +-- drivers/mmc/host/tmio_mmc.h | 17 +++--- drivers/mmc/host/tmio_mmc_core.c | 114 +++ i

[PATCH 2/5] mmc: tmio: use EXPORT_SYMBOL_GPL

2017-05-30 Thread Simon Horman
Use EXPORT_SYMBOL_GPL rather than the non _GPL variant as there seems to be no reason not to. Signed-off-by: Simon Horman --- drivers/mmc/host/tmio_mmc_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc

[PATCH 1/5] MAINTAINERS: Update files for TMIO/SDHI MMC driver

2017-05-30 Thread Simon Horman
Update files for tmio/sdhi MMC driver to reflect recent filename changes. Signed-off-by: Simon Horman --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..5b4c477573dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1288

[PATCH 3/5] mmc: tmio, renesas-sdhi: update Renesas related copyrights

2017-05-30 Thread Simon Horman
Update copyrights to reflect work by Wolfram Sang and myself since last year. Signed-off-by: Simon Horman --- drivers/mmc/host/renesas_sdhi_core.c | 5 +++-- drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 +++ drivers/mmc/host/tmio_mmc.c | 2 ++ drivers/mmc/host/tmio_mmc.h

[PATCH 0/5] mmc: tmio, renesas-sdhi: cleanups

2017-05-30 Thread Simon Horman
Hi, this short series provides some cleanups to the tmio and renesas-sdhi drivers. * Update files listed in MAINTAINERS * Consistently use EXPORT_SYMBOL_GPL * Update Renesas related copyrights * Improve checkpatch cleanness Simon Horman (5): MAINTAINERS: Update files for TMIO/SDHI MMC driver

renesas-drivers-2017-05-30-v4.12-rc3

2017-05-30 Thread Geert Uytterhoeven
I have pushed renesas-drivers-2017-05-30-v4.12-rc3 to https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git This tree is meant to ease development of platform support and drivers for Renesas ARM SoCs. It is created by merging (a) the for-next branches of various subsystem trees an

Re: [PATCH v2] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread Peter Rosin
On 2017-05-30 10:54, Jacopo Mondi wrote: > I2c-mux channels are created as mux siblings while they should be > children of the mux itself. Fix it. Has this received any testing at all? I think it will break various users of i2c_parent_is_i2c_adapter() that expect the current situation that a i2c

Re: [linux-next / tty] possible circular locking dependency detected

2017-05-30 Thread Geert Uytterhoeven
On Mon, May 22, 2017 at 9:39 AM, Sergey Senozhatsky wrote: > > [ 1274.378287] == > [ 1274.378289] WARNING: possible circular locking dependency detected > [ 1274.378290] 4.12.0-rc1-next-20170522-dbg-7-gc09b2ab28b74-dirty #1317 > Not tainted

Re: ravb WoL interrupt flood

2017-05-30 Thread Niklas Söderlund
Hi Geert, Thanks for the report. I did run a 200+ loop suspend/resume without issues so this error is probably hard to reproduce or something changed since v4.11-rc1 which if IIRC was the base I used to do the tests. All I can think of is that if the interface was down at the time the system w

Re: [PATCH] mmc: tmio: make sure SDIO gets reinitialized after resume

2017-05-30 Thread Ulf Hansson
On 23 May 2017 at 15:34, Wolfram Sang wrote: > To achieve that, we set the registers in the generic HW reset routine > which gets called at both, init and resume. We also make sure to move > SDIO initialization before reset gets called in probe(). > > Signed-off-by: Wolfram Sang > Tested-by: Masa

Re: [PATCH 4/7] mmc: use proper name for the R-Car SoC

2017-05-30 Thread Ulf Hansson
On 30 May 2017 at 09:16, Lee Jones wrote: > On Mon, 29 May 2017, Ulf Hansson wrote: > >> On 28 May 2017 at 11:30, Wolfram Sang >> wrote: >> > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive >> > text. >> > >> > Signed-off-by: Wolfram Sang >> >> Thanks, applied for next!

ravb WoL interrupt flood

2017-05-30 Thread Geert Uytterhoeven
Hi Niklas, I just got a flood of messages after WoL from s2idle on r8a7795/salvator-x: [ 802.341060] ravb e680.ethernet eth0: ignoring interrupt, rx status 0x0001, rx mask 0x0001, [ 802.350369] ravb e680.ethernet eth0: tx status 0x, tx mask 0x0001

[PATCH] mmc: renesas_sdhi_core: on R-Car 2+, make use of CBSY bit

2017-05-30 Thread Wolfram Sang
Most registers need to wait until the command is completed, not necessarily until the bus is free. At least, R-Car 2+ SoCs can signal that via the CBSY bit, so let's use it there instead of SCLKDIVEN to save a little bit of delay. Signed-off-by: Wolfram Sang --- Tested with a Renesas Lager board

[PATCH v2] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread Jacopo Mondi
I2c-mux channels are created as mux siblings while they should be children of the mux itself. Fix it. Signed-off-by: Jacopo Mondi Suggested-by: Laurent Pinchart --- Hello, while inspecting child nodes of an i2c adapter it has been noted that child devices of an i2c-mux are listed as children

Re: [PATCH] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, May 30, 2017 at 10:38 AM, jmondi wrote: > On Tue, May 30, 2017 at 10:31:21AM +0200, Geert Uytterhoeven wrote: >> On Tue, May 30, 2017 at 10:13 AM, Jacopo Mondi >> wrote: >> > I2c-mux channels are created with the mux parent device as their own >> > parent, while they should be

Re: [PATCH v3 0/4] r8a7793 Gose video input support

2017-05-30 Thread Simon Horman
On Fri, May 26, 2017 at 08:49:07AM +0200, Simon Horman wrote: > On Fri, May 19, 2017 at 03:07:00PM +0200, Ulrich Hecht wrote: > > Hi! > > > > This is a by-the-datasheet implementation of analog and digital video input > > on the Gose board. > > > > This revision adds new bindings that distinguish

Re: [PATCH v3 0/4] r8a7793 Gose video input support

2017-05-30 Thread Simon Horman
On Mon, May 29, 2017 at 11:08:12AM +0200, Hans Verkuil wrote: > On 05/19/2017 03:07 PM, Ulrich Hecht wrote: > >Hi! > > > >This is a by-the-datasheet implementation of analog and digital video input > >on the Gose board. > > > >This revision adds new bindings that distinguish between ADV7180 variant

Re: [PATCH] ARM: dts: r7s72100: add clock bit definitions

2017-05-30 Thread Simon Horman
On Mon, May 29, 2017 at 11:31:37AM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Thu, May 25, 2017 at 6:05 PM, Chris Brandt > wrote: > > Add the remaining bit locations for the module stop clock registers. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Geert Uytterhoeven Chris, p

Re: [PATCH 5/7] pci: use proper name for the R-Car SoC

2017-05-30 Thread Simon Horman
On Mon, May 29, 2017 at 11:13:48AM +0200, Geert Uytterhoeven wrote: > On Sun, May 28, 2017 at 11:30 AM, Wolfram Sang > wrote: > > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive > > text. > > > > Signed-off-by: Wolfram Sang > > Acked-by: Geert Uytterhoeven Acked-by: Si

Re: [PATCH 0/2] arm64: dts: r8a779[56]: add DMA for IIC_DVFS

2017-05-30 Thread Simon Horman
On Sun, May 28, 2017 at 12:14:28PM +0200, Wolfram Sang wrote: > Based on renesas-drivers/master as of today. Please apply. > > Wolfram Sang (2): > arm64: dts: r8a7795: add DMA for IIC_DVFS > arm64: dts: r8a7796: add DMA for IIC_DVFS Thanks, I have queued these up.

Re: [PATCH] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread jmondi
Hi Geert, On Tue, May 30, 2017 at 10:31:21AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, May 30, 2017 at 10:13 AM, Jacopo Mondi > wrote: > > I2c-mux channels are created with the mux parent device as their own > > parent, while they should be siblings of the mux itself. > > Isn't it

Re: [PATCH] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, May 30, 2017 at 10:13 AM, Jacopo Mondi wrote: > I2c-mux channels are created with the mux parent device as their own > parent, while they should be siblings of the mux itself. Isn't it the other way around? Cfr. the example and the patch. > Fix this. > > Signed-off-by: Jacopo

[PATCH] i2c: i2c-mux: Fix channel parent node assignment

2017-05-30 Thread Jacopo Mondi
I2c-mux channels are created with the mux parent device as their own parent, while they should be siblings of the mux itself. Fix this. Signed-off-by: Jacopo Mondi Suggested-by: Laurent Pinchart --- Hello, while inspecting child nodes of an i2c adapter it has been noted that child devices o

Re: [PATCH 4/7] mmc: use proper name for the R-Car SoC

2017-05-30 Thread Lee Jones
On Mon, 29 May 2017, Ulf Hansson wrote: > On 28 May 2017 at 11:30, Wolfram Sang > wrote: > > It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive > > text. > > > > Signed-off-by: Wolfram Sang > > Thanks, applied for next! > > For mfd, Lee, please tell if you have any issue