Re: [PATCH] media: i2c: adv748x: Map v4l2_std_id to the internal reg value

2017-09-11 Thread Simon Yuan
On Tuesday, 12 September 2017 10:26:53 NZST Kieran Bingham wrote: > From: Simon Yuan > > The video standard was not mapped to the corresponding value of the > internal video standard in adv748x_afe_querystd, causing the wrong > video standard to be selected. > > Fixes:

[PATCH] media: i2c: adv748x: Map v4l2_std_id to the internal reg value

2017-09-11 Thread Kieran Bingham
From: Simon Yuan The video standard was not mapped to the corresponding value of the internal video standard in adv748x_afe_querystd, causing the wrong video standard to be selected. Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver") Signed-off-by: Simon Yuan

Re: [PATCH v2 6/8] v4l: vsp1: Adapt entities to configure into a body

2017-09-11 Thread Kieran Bingham
Hi Laurent, On 17/08/17 18:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote: >> Currently the entities store their configurations into a display list. >> Adapt this such that the code can be configured into a body

Re: [PATCH v2 5/8] v4l: vsp1: Refactor display list configure operations

2017-09-11 Thread Kieran Bingham
Hi Laurent, On 17/08/17 19:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:28 Kieran Bingham wrote: >> The entities provide a single .configure operation which configures the >> object into the target display list, based on the

Re: [PATCH v2 8/8] v4l: vsp1: Reduce display list body size

2017-09-11 Thread Kieran Bingham
On 17/08/17 17:11, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:31 Kieran Bingham wrote: >> The display list originally allocated a body of 256 entries to store all >> of the register lists required for each frame. >> >> This has now been

Re: [PATCH] [media] v4l: vsp1: Use generic node name

2017-09-11 Thread Rob Herring
On Wed, Aug 30, 2017 at 11:57:31AM +0200, Geert Uytterhoeven wrote: > Use the preferred generic node name in the example. > > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/8] v4l: vsp1: Provide a fragment pool

2017-09-11 Thread Kieran Bingham
Hi Laurent, Thanks for your review, On 17/08/17 13:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:25 Kieran Bingham wrote: >> Each display list allocates a body to store register values in a dma >> accessible buffer from a dma_alloc_wc()

Re: [PATCH v2 3/8] v4l: vsp1: Convert display lists to use new fragment pool

2017-09-11 Thread Kieran Bingham
Hi Laurent, Thanks for the review On 17/08/17 13:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:26 Kieran Bingham wrote: >> Adapt the dl->body0 object to use an object from the fragment pool. >> This greatly reduces the pressure on the TLB

Re: A patch for a bug in adv748x

2017-09-11 Thread Simon Yuan
On Tuesday, 12 September 2017 07:00:33 NZST Kieran Bingham wrote: > Hi Simon, > > On 11/09/17 05:30, Simon Yuan wrote: > > Hi Niklas, > > > > How are you doing? I've picked you as my contact since I met you earlier > > this year at ELC2017. Not sure if you still remember, but we had a very > >

Re: A patch for a bug in adv748x

2017-09-11 Thread Kieran Bingham
Hi Simon, On 11/09/17 05:30, Simon Yuan wrote: > Hi Niklas, > > How are you doing? I've picked you as my contact since I met you earlier this > year at ELC2017. Not sure if you still remember, but we had a very brief chat > about the status of the adv748x driver. I'll let Niklas reply to this

Re: [PATCH v2 0/2] Renesas R8A77970 CPG/MSSR clock support

2017-09-11 Thread Geert Uytterhoeven
Hi Sergei, On Fri, Sep 8, 2017 at 11:34 PM, Sergei Shtylyov wrote: >Here's the set of 2 patches against the 'clk-next' branch of CLK group's > 'linux.git' repo. Thank you, looks good! > As the DT patches in the R8A77970/Eagle board support series >

Re: [PATCH v2 2/2] clk: renesas: cpg-mssr: add R8A7797 support

2017-09-11 Thread Geert Uytterhoeven
On Fri, Sep 8, 2017 at 11:34 PM, Sergei Shtylyov wrote: > Add R-Car V3M (R8A77970) Clock Pulse Generator / Module Standby and > Software Reset support, using the CPG/MSSR driver core and the common > R-Car Gen3 code. > > Based on the original (and large) patch

Re: [PATCH v2 1/2] dt-bindings: clock: add R8A77970 CPG core clock definitions

2017-09-11 Thread Geert Uytterhoeven
On Fri, Sep 8, 2017 at 11:34 PM, Sergei Shtylyov wrote: > Add macros usable by the device tree sources to reference the R8A77970 > CPG core clocks by index. The data come from the table 8.2c of R-Car > Series, 3rd Generation User's Manual: Hardware (Rev. 0.55,

[PATCH 1/5] ARM: dts: r8a7790: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Add properties to describe the reset topology for on-SoC devices: - Add the "#reset-cells" property to the CPG/MSSR device node, - Add resets and reset-names properties to the various device nodes. This allows to reset SoC devices using the Reset Controller API. Note that resets usually

[PATCH 3/5] ARM: dts: r8a7792: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Add properties to describe the reset topology for on-SoC devices: - Add the "#reset-cells" property to the CPG/MSSR device node, - Add resets and reset-names properties to the various device nodes. This allows to reset SoC devices using the Reset Controller API. Note that resets usually

[PATCH 5/5] ARM: dts: r8a7794: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Add properties to describe the reset topology for on-SoC devices: - Add the "#reset-cells" property to the CPG/MSSR device node, - Add resets and reset-names properties to the various device nodes. This allows to reset SoC devices using the Reset Controller API. Note that resets usually

[PATCH 4/5] ARM: dts: r8a7793: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Add properties to describe the reset topology for on-SoC devices: - Add the "#reset-cells" property to the CPG/MSSR device node, - Add resets and reset-names properties to the various device nodes. This allows to reset SoC devices using the Reset Controller API. Note that resets usually

[PATCH 0/5] ARM: dts: rcar-gen2: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Hi Simon, Magnus, This patch series describes the reset topology on all R-Car Gen2 Socs, like was done before for R-Car Gen3 and RZ/G1. Resets usually match the corresponding module clocks. Exceptions are: - The audio module has resets for the Serial Sound Interfaces only, - The

[PATCH 2/5] ARM: dts: r8a7791: Add reset control properties

2017-09-11 Thread Geert Uytterhoeven
Add properties to describe the reset topology for on-SoC devices: - Add the "#reset-cells" property to the CPG/MSSR device node, - Add resets and reset-names properties to the various device nodes. This allows to reset SoC devices using the Reset Controller API. Note that resets usually

[PATCH v2] MAINTAINERS: Add Renesas SoC DT bindings doc to Renesas ARM sections

2017-09-11 Thread Geert Uytterhoeven
Suggested-by: Sergei Shtylyov Signed-off-by: Geert Uytterhoeven --- v2: - Fix silly typo. --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 28e9ab798e35b7ab..ae965af723fa129e

Re: [PATCH] MAINTAINERS: Add Renesas SoC DT bindings doc to Renesas ARM sections

2017-09-11 Thread Sergei Shtylyov
Hello! On 9/11/2017 1:54 PM, Geert Uytterhoeven wrote: Suggested-by: Sergei Shtylyov Signed-off-by: Geert Uytterhoeven --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi

2017-09-11 Thread Simon Horman
On Wed, Sep 06, 2017 at 02:52:06PM +0100, Chris Paterson wrote: > From: Biju Das > > Signed-off-by: Biju Das > Signed-off-by: Chris Paterson > --- > v2->v3 > - Renamed lables to use iic instead of i2c. > > v1->v2 >