Re: [PATCH RFT] mmc: core: use usleep_range rather than HZ magic in mmc_delay()

Hi On 2017/11/16 18:42, Ulf Hansson wrote: On 16 November 2017 at 08:59, Shawn Lin wrote: Hi, On 2017/11/16 15:47, Ulf Hansson wrote: On 14 November 2017 at 23:55, Wolfram Sang wrote: Documentation/timers/timers-howto.txt

Re: [PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

Hi Jacopo, On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from ov772x sensor driver. > - Handle clock directly > - Register async subdevice > - Add platform specific enable/disable functions > - Adjust build system > > This commit does

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Jacopo, On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote: > Hi Sakari, >thanks for review! You're welcome! > On Wed, Nov 15, 2017 at 02:45:51PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > Could you remove the original driver and send the patch using git > > send-email

[PATCH 0/2] Add R8A77970/Eagle I2C support

Hello! Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20171113-v4.14' tag. We're adding the R8A77970 I2C nodes and then describing the PCA9654 I/O expander connected to the I2C0 bus. These patches depend on the R8A77970/Eagle PFC suport patchset in order to

[PATCH 1/2] arm64: dts: renesas: r8a77970: add I2C support

Define the generic R8A77970 parts of the I2C[0-4] device node. Based on the original (and large) patch by Daisuke Matsushita . Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov

[PATCH 2/2] arm64: dts: renesas: eagle: add I2C0 support

Define the Eagle board dependent part of the I2C0 device node. The I2C0 bus is populated by ON Semiconductor PCA9653 I/O expander and Analog Devices ADV7511W HDMI transmitter (but we're only describing the former chip now). Based on the original (and large) patch by Vladimir Barinov.

Re: [PATCH 0/1] Add R8A77970/Eagle I2C support

On 11/16/2017 11:56 PM, Sergei Shtylyov wrote: Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20171113-v4.14' tag. We're adding the R8A77970 I2C nodes and then describing the PCA9654 I/O expander connected to the I2C0 bus. These patches depend on the

[PATCH 1/1] arm64: dts: renesas: eagle: add I2C0 support

Define the Eagle board dependent part of the I2C0 device node. The I2C0 bus is populated by ON Semiconductor PCA9653 I/O expander and Analog Devices ADV7511W HDMI transmitter (but we're only describing the former chip now). Based on the original (and large) patch by Vladimir Barinov.

[PATCH 0/1] Add R8A77970/Eagle I2C support

Hello! Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20171113-v4.14' tag. We're adding the R8A77970 I2C nodes and then describing the PCA9654 I/O expander connected to the I2C0 bus. These patches depend on the R8A77970/Eagle PFC suport patchset in order to

Re: [PATCH] gpio: pca953x: fix vendor prefix for PCA9654

On 11/16/2017 11:18 PM, Sergei Shtylyov wrote: Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: Later, of course. Could be fixed while committing, I guess? add onsemi,pca9654 id") made use

[PATCH] gpio: pca953x: fix vendor prefix for PCA9654

Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id") made use of another, undocumented vendor prefix. Since such prefix doesn't seem to be used in any device trees, I think we can

[PATCH v2 2/4] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Add compatible strings for r8a7743 and r8a7745. No driver change is needed as "renesas,rcar-gen2-vin" will activate the right code. However, it is good practice to document compatible strings for the specific SoC as this allows SoC specific changes to the driver if needed, in addition to document

[PATCH v2 1/4] dt-bindings: media: rcar_vin: Reverse SoC part number list

Change the sorting of the part numbers from descending to ascending to match with other documentation. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das --- v1->v2: * new patch triggered by Geert's comment, see the below link for

[PATCH v2 4/4] ARM: dts: r8a7745: add VIN dt support

Add VIN[01] support to SoC dt. Also, add aliases. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das --- This patch depends on the following patch: * ARM: dts: r8a7745: Add CAN[01] SoC support

[PATCH v2 0/4] Add VIN support to r8a774[35]

Hello, this series documents VIN related dt-bindings for r8a774[35], adds VIN[012] nodes to the r8a7743 SoC dtsi and adds VIN[01] nodes to the r8a7745 SoC dtsi. Best regards, Fabrizio Castro (4): dt-bindings: media: rcar_vin: Reverse SoC part number list dt-bindings: media: rcar_vin: add

RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Hi Geert, > >> > >> Please keep the list sorted by SoC part number. > > > > It is sorted, just in descending order. Do you want me to re-order the full > > list in ascending order? > > That may be a good idea, given the current order is non-standard and > counter-intuitive. sure, dropping this

Re: [PATCH v2 7/8] v4l: vsp1: Move video configuration to a cached dlb

Hi Laurent, Thankyou for the review, and your patience on the long awaited response on these remaining patches. On 17/08/17 19:10, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:30 Kieran Bingham wrote: >> We are now able to configure a

Re: [PATCH v2 2/2] drm: rcar-du: Clip planes to screen boundaries

On Mon, Nov 13, 2017 at 10:47:00AM +0200, Laurent Pinchart wrote: > Unlike the KMS API, the hardware doesn't support planes exceeding the > screen boundaries or planes being located fully off-screen. We need to > clip plane coordinates to support the use case. > > Fortunately the DRM core offers

Re: [PATCH/RFC 2/2] v4l: rcar-vin: Wait for device access to complete before unplugging

Hi Sakari, On 2017-11-16 14:36:24 +0200, Sakari Ailus wrote: > On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote: > > To avoid races between device access and unplug, call the > > video_device_unplug() function in the platform driver remove handler. > > This will unsure that all

[PATCH] pinctrl: sh-pfc: r8a7796: Rename RTS{0,1,3,4}# pin function definitions

From: Takeshi Kihara This patch renames the pin function macro definitions of the GPSR5 and IPSR{0,3,5,6,12} registers value for the RTS{0,1,3,4}# pin. This is a correction because GPSR and IPSR register specification for R8A7796 SoC was changed in R-Car Gen3

[PATCH] pinctrl: sh-pfc: r8a7795: Rename RTS{0,1,3,4}# pin function definitions

From: Takeshi Kihara This patch renames the pin function macro definitions of the GPSR and IPSR registers value for the RTS{0,1,3,4}# pin. This is a correction because GPSR and IPSR register specification for R8A7795 ES2.0 SoC was changed in R-Car Gen3 Hardware

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

Hi Laurent, On 16/11/17 12:32, Sakari Ailus wrote: > Hi Laurent, > > Thank you for the initiative to bring up and address the matter! I concur - this looks like a good start towards managing the issue. One potential thing spotted on top of Sakari's review inline below, of course I suspect this

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Hi Fabrizio, On Thu, Nov 16, 2017 at 2:45 PM, Fabrizio Castro wrote: >> Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree >> support for r8a774[35] >> >> On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro >>

[PATCH 2/2] ARM: dts: genmai: Correct primary compatible value for eeprom

The Renesas part number of the two-wire serial interface EEPROM is not 24C128, but R1EX24128ASA00A. Hence change its primary compatible value to "renesas,r1ex24128". Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/r7s72100-genmai.dts | 2 +- 1 file changed, 1

[PATCH 0/2] ARM: dts: renesas: Correct primary compatible value for eeprom

Hi Simon, Magnus, The Renesas part numbers of the two-wire serial interface EEPROMs do not follow the 24Cxx pattern, but the R1EX24xxx pattern. Hence change the primary compatible values to the appropriate variant of "renesas,r1ex24xxx", like is already done on Gose. Note that the

[PATCH 1/2] ARM: dts: koelsch: Correct primary compatible value for eeprom

The Renesas part number of the two-wire serial interface EEPROM is not 24C02, but R1EX24002ATAS0G. Hence change its primary compatible value to "renesas,r1ex24002", like on Gose. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +- 1 file

[PATCH] dt-bindings: i2c: eeprom: Add Renesas R1EX24128

Document the compatible value for the Renesas R1EX24128ASAS0A two-wire serial interface EEPROM, so it can be used in DTS files without causing checkpatch warnings. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +- 1 file

RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Hello Geert, thank you for your comment! > Subject: Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree > support for r8a774[35] > > On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro > wrote: > > ---

[PATCH 3/4] arm64: dts: renesas: r8a7796-salvator-x: Add SoC name to file header

Document clearly which SoC this DTS applies to, to distinguish from Salvator-X boards equipped with other SoCs. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/4] arm64: dts: renesas: salvator-x/xs: Add SoC name to file header

Hi Simon, Magnus, With the proliferation of Salvator-X and Salvator-XS boards carrying different R-Car Gen3 SoCs variants, several DTS files ended up having the same file headers. Add the SoC names to the file headers to avoid confusion. Thanks! Geert Uytterhoeven (4): arm64: dts:

[PATCH 2/4] arm64: dts: renesas: r8a7795-salvator-x: Add SoC name to file header

Document clearly which SoC this DTS applies to, to distinguish from Salvator-X boards equipped with other SoCs. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/4] arm64: dts: renesas: r8a7795-es1-salvator-x: Add SoC name to file header

Document clearly which SoC this DTS applies to, to distinguish from Salvator-X boards equipped with other SoCs. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] arm64: dts: renesas: r8a7795-salvator-xs: Add SoC name to file header

Document clearly which SoC this DTS applies to, to distinguish from Salvator-XS boards equipped with other SoCs. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Hello Geert, thank you for your comment! > > Add compatible strings for r8a7743 and r8a7745. No driver change > > change is needed as "renesas,rcar-gen2-vin" will activate the right > > double "change" ps, do you think a v2 is in order? Thanks, Fab Renesas Electronics Europe Ltd, Dukes

[PATCH] ARM: dts: r8a779x: Add '#reset-cells' in cpg-mssr

From: Arnd Bergmann With the latest dtc, we get many warnings about the missing '#reset-cells' property in these controllers, e.g.: arch/arm/boot/dts/r8a7790-lager.dtb: Warning (resets_property): Missing property '#reset-cells' in node /clock-controller@e615 or bad phandle

[PATCH v2] arm64: dts: renesas: salvator-common: Add BD9571 PMIC

Add a device node for the ROHM BD9571MWV PMIC. This was based on the example in the DT binding documentation, but using IRQ0 instead of a GPIO interrupt, as that matches the schematics, and because INTC-EX is a simpler block. Signed-off-by: Geert Uytterhoeven --- v2:

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro wrote: > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -14,7 +14,10 @@ channel which can be either RGB, YUYV or BT656. > -

Re: [PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

On Thu, Nov 16, 2017 at 1:11 PM, Fabrizio Castro wrote: > Add compatible strings for r8a7743 and r8a7745. No driver change > change is needed as "renesas,rcar-gen2-vin" will activate the right double "change" > code. However, it is good practice to document

Re: [PATCH/RFC 2/2] v4l: rcar-vin: Wait for device access to complete before unplugging

On Thu, Nov 16, 2017 at 02:33:49AM +0200, Laurent Pinchart wrote: > To avoid races between device access and unplug, call the > video_device_unplug() function in the platform driver remove handler. > This will unsure that all device access completes before the remove > handler proceeds to free

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

Hi Laurent, Thank you for the initiative to bring up and address the matter! On Thu, Nov 16, 2017 at 02:33:48AM +0200, Laurent Pinchart wrote: > Device unplug being asynchronous, it naturally races with operations > performed by userspace through ioctls or other file operations on video > device

Re: [PATCH 3/3] arm64: dts: renesas: eagle: add EtherAVB pins

On 11/15/2017 11:21 PM, Sergei Shtylyov wrote: Add the (previously omitted) EtherAVB pin data to the Eagle board's device tree. --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts @@ -34,6 +34,9 @@ [...] @@ -53,6

[PATCH 2/2] ARM: dts: r8a7743: add VIN dt support

Add VIN[012] support to SoC dt. Also, add aliases. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das --- arch/arm/boot/dts/r8a7743.dtsi | 36 1 file changed, 36 insertions(+) diff --git

[PATCH 1/2] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

Add compatible strings for r8a7743 and r8a7745. No driver change change is needed as "renesas,rcar-gen2-vin" will activate the right code. However, it is good practice to document compatible strings for the specific SoC as this allows SoC specific changes to the driver if needed, in addition to

[PATCH 0/2] Add VIN support to r8a7743

Hello, this series documents VIN related dt-bindings for r8a774[35], and adds VIN[012] nodes to the r8a7743 SoC dtsi. Best regards, Fabrizio Castro (2): dt-bindings: media: rcar_vin: add device tree support for r8a774[35] ARM: dts: r8a7743: add VIN dt support

Re: [PATCH 3/3] vin-tests: Refactor mc_get_dev

Hi Niklas, On 15/11/17 16:51, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > Unfortunately I experience some problems with this patch. My apologies, I thought this was working when I used it, it was left in my local branch and hadn't been sent (along with the other two)

Re: [PATCH RFT] mmc: core: use usleep_range rather than HZ magic in mmc_delay()

On 16 November 2017 at 08:59, Shawn Lin wrote: > Hi, > > On 2017/11/16 15:47, Ulf Hansson wrote: >> >> On 14 November 2017 at 23:55, Wolfram Sang >> wrote: >>> >>> Documentation/timers/timers-howto.txt recommends to use usleep_range for

Re: [PATCH 3/4] arm64: dts: r8a77995: draak: enable SDHI2

Hi Uli, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > The single SDHI controller is connected to eMMC. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++

Re: [PATCH 2/4] arm64: dts: r8a77995: Add SDHI (MMC) support

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > R-Car D3 has only one SDHI controller. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 1/4] mmc: renesas_sdhi: enable R-Car D3 (r8a77995) support

Hi Uli, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Adds compatible string and whitelists for internal DMAC implementation. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > ---

Re: [PATCH] v4l: sh_mobile_ceu: Return buffers on streamoff()

Hi Jacopo, Thanks for the patch. I think you could add this to v2 of your related set; that way it'll be easy to get the dependencies right. I don't think this is urgent either... On Wed, Nov 15, 2017 at 06:59:12PM +0100, Jacopo Mondi wrote: > videobuf2 core reports an error when not all buffers

Re: [PATCH 4/4] dt-bindings: mmc: renesas_sdhi: Add r8a77995 support

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Adds bindings for the R-Car D3 SoC's SDHI IP. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 5/6] arm64: renesas: draak: enable I2C controller 1

Hi Uli, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > No devices to add, I2C1 has an external connector only. > > Signed-off-by: Ulrich Hecht Thanks for your patch! Reviewed-by: Geert Uytterhoeven

Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

Hi Ulrich, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Enables EEPROM on I2C0 on the Draak board. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++

[RFC] arm: dts: gr-peach: Add audiocamerashield DTSi

Add device tree header for GR-Peach's audiocamerashield with OV7670 image sensor. Signed-off-by: Jacopo Mondi --- Hello, this patch adds device tree header file for GR-Peach's audiocamerashield. More details on the shield can be found at [1]. Sending as RFC and

Re: [PATCH 3/6] arm64: renesas: r8a77995: add I2C support

Hi Ulrich, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Defines R-Car D3 I2C controllers 0-3. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++

RE: [PATCH 2/3] arm64: dts: r8a7795: add DMA for SCIF2

Hello Ulrich, > From: linux-renesas-soc-ow...@vger.kernel.org [mailto:linux-renesas-soc- > ow...@vger.kernel.org] On Behalf Of Ulrich Hecht > Sent: 15 November 2017 15:25 > > Tested on Draak. I guess you meant for the patch title to use r8a77995? Kind regards, Chris > > Signed-off-by:

Re: [PATCH 6/6] i2c: rcar: document R8A77970 bindings

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > R-Car D3 (R8A77995) SoC has a R-Car Gen3-compatible I2C controller. > > Signed-off-by: Ulrich Hecht With s/70/95/ in the subject: Reviewed-by: Geert Uytterhoeven

Re: [PATCH 2/6] i2c: rcar: enable for R-Car D3 (r8a77995)

Hi Ulrich, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Same as other Gen3 SoCs. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/drivers/i2c/busses/i2c-rcar.c > +++ b/drivers/i2c/busses/i2c-rcar.c > @@

Re: [PATCH 1/6] pinctrl: sh-pfc: r8a77995: add missing pins SCL0 and SDA0 to pinmux data

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Required for I2C0 operation. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven i.e. will queue in sh-pfc-for-v4.16. Gr{oetje,eeting}s,

Re: [PATCH 2/3] arm64: dts: r8a7795: add DMA for SCIF2

Hi Ulrich, On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Tested on Draak. > > Signed-off-by: Ulrich Hecht Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++

Re: [PATCH 1/3] arm64: dts: r8a77995: add SYS-DMAC nodes

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > Differs from other Gen3 SoCs in that each controller only supports eight > channels. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven

Re: [PATCH 3/3] dmaengine: rcar-dmac: Document R-Car D3 bindings

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht wrote: > R8A77995's SYS-DMAC is R-Car Gen3-compatible. > > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH RFT] mmc: core: use usleep_range rather than HZ magic in mmc_delay()

Hi, On 2017/11/16 15:47, Ulf Hansson wrote: On 14 November 2017 at 23:55, Wolfram Sang wrote: Documentation/timers/timers-howto.txt recommends to use usleep_range for delays 1-20ms. Let's adhere to it. No need for messing with HZ and still do busy looping