Re: [PATCH v2 1/3] nvram: at24c: prevent segfault by checking "rom-size"

On 03/19/2018 10:30 PM, Wolfram Sang wrote: > The value for "rom-size" is used as a divisor, so it must not be 0 or it > will segfault. A size of 0 wouldn't make sense anyhow. > > Signed-off-by: Wolfram Sang > --- > hw/nvram/eeprom_at24c.c | 5 + > 1 file

Re: [PATCH v2 2/3] nvram: at24c: use a sane default for "rom-size"

On 03/19/2018 10:31 PM, Wolfram Sang wrote: > 0 as "rom-size" will lead to an error message. Let's use the size of a > small 24c01 which has 128 byte. > > Signed-off-by: Wolfram Sang Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporting

> > -ERR(TYPE_AT24C_EE > > -" : failed to write backing file\n"); > > +error_report("failed to write backing file\n"); > > Drop the \n here and elsewhere in your patch; error_report() already does > that for you. Darn, I haven't installed

Re: [Qemu-devel] [PATCH v2 0/3] nvram: at24c: fix problems related to "rom-size"

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180319213101.6100-1-wsa+rene...@sang-engineering.com Subject: [Qemu-devel] [PATCH v2 0/3] nvram: at24c: fix problems related to "rom-size" === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v2 3/3] nvram: at24c: use standard error reporting

On 03/19/2018 04:31 PM, Wolfram Sang wrote: Replace the ERR macro with error_report() because fprintf is deprecated. This also fixes the prefix printed out twice. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 17 ++--- 1 file

[PATCH v2 1/3] nvram: at24c: prevent segfault by checking "rom-size"

The value for "rom-size" is used as a divisor, so it must not be 0 or it will segfault. A size of 0 wouldn't make sense anyhow. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 3/3] nvram: at24c: use standard error reporting

Replace the ERR macro with error_report() because fprintf is deprecated. This also fixes the prefix printed out twice. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

[PATCH v2 0/3] nvram: at24c: fix problems related to "rom-size"

I used this driver as a template for a custom one. While hacking on my own, I noticed some problems in this driver, too. This series fixes the first set of them, related to the "rom-size" parameter. It fixes a segfault. I think the first patch is clearly suitable for stable. I think the second

[PATCH v2 2/3] nvram: at24c: use a sane default for "rom-size"

0 as "rom-size" will lead to an error message. Let's use the size of a small 24c01 which has 128 byte. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/nvram/eeprom_at24c.c

Re: [Intel-gfx] [PATCH igt 0/8] Non-Intel test suite fixes

On Fri, Mar 16, 2018 at 9:55 AM, Daniel Vetter wrote: > On Thu, Mar 15, 2018 at 03:45:36PM +0100, Ulrich Hecht wrote: >> Hi! >> >> I have run the tests on a Renesas R-Car M3-W's DU device, and have found a >> number of false negatives that mostly stem from use of Intel-specifics

[PATCH 2/3] pinctrl: sh-pfc: r8a7796: deduplicate VIN4 pin definitions

Use union vin_data and VIN_DATA_PIN_GROUP() to reduce redundancies in pin definitions. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 308 --- 1 file changed, 72 insertions(+), 236 deletions(-) diff --git

[PATCH 3/3] pinctrl: sh-pfc: r8a77995: deduplicate VIN4 pin definitions

Use union vin_data and VIN_DATA_PIN_GROUP() to reduce redundancies in pin definitions. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 154 -- 1 file changed, 36 insertions(+), 118 deletions(-) diff --git

[PATCH 0/3] pinctrl: sh-pfc: R-Car Gen3 VIN4 18-bit pin control fixups

Hi! This fixes the incorrect RGB666 pin assignments reported by Geert in H3, M3-W and D3 SoCs. Thank you! CU Uli Ulrich Hecht (3): pinctrl: sh-pfc: r8a7795: correct VIN4 18-bit pins pinctrl: sh-pfc: r8a7796: correct VIN4 18-bit pins pinctrl: sh-pfc: r8a77995: correct VIN4 18-bit pins

[PATCH 1/3] pinctrl: sh-pfc: r8a7795: correct VIN4 18-bit pins

RGB666 has a pin assignment that differs from the other formats. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 0/3] pinctrl: sh-pfc: R-Car Gen 3 VIN4 deduplication

Hi! This uses union vin_data and VIN_DATA_PIN_GROUP() to reduce redundancy in the VIN4 pin data on H3, M3-W and D3 SoCs. CU Uli Ulrich Hecht (3): pinctrl: sh-pfc: r8a7795: deduplicate VIN4 pin definitions pinctrl: sh-pfc: r8a7796: deduplicate VIN4 pin definitions pinctrl: sh-pfc:

[PATCH 1/3] pinctrl: sh-pfc: r8a7795: deduplicate VIN4 pin definitions

Use union vin_data and VIN_DATA_PIN_GROUP() to reduce redundancies in pin definitions. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 308 --- 1 file changed, 72 insertions(+), 236 deletions(-) diff --git

[PATCH 3/3] pinctrl: sh-pfc: r8a77995: correct VIN4 18-bit pins

RGB666 has a pin assignment that differs from the other formats. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c

[PATCH 2/3] pinctrl: sh-pfc: r8a7796: correct VIN4 18-bit pins

RGB666 has a pin assignment that differs from the other formats. Signed-off-by: Ulrich Hecht --- drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 02:56 PM, Vladimir Zapolskiy wrote: > On 03/19/2018 03:48 PM, Marek Vasut wrote: >> On 03/19/2018 02:43 PM, Vladimir Zapolskiy wrote: >>> On 03/19/2018 12:56 PM, Marek Vasut wrote: On 03/19/2018 11:53 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, Mar 19, 2018

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 03:48 PM, Marek Vasut wrote: > On 03/19/2018 02:43 PM, Vladimir Zapolskiy wrote: >> On 03/19/2018 12:56 PM, Marek Vasut wrote: >>> On 03/19/2018 11:53 AM, Geert Uytterhoeven wrote: Hi Marek, On Mon, Mar 19, 2018 at 10:53 AM, Marek Vasut

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 02:43 PM, Vladimir Zapolskiy wrote: > On 03/19/2018 12:56 PM, Marek Vasut wrote: >> On 03/19/2018 11:53 AM, Geert Uytterhoeven wrote: >>> Hi Marek, >>> >>> On Mon, Mar 19, 2018 at 10:53 AM, Marek Vasut wrote: On 03/19/2018 09:38 AM, Simon Horman wrote:

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 12:56 PM, Marek Vasut wrote: > On 03/19/2018 11:53 AM, Geert Uytterhoeven wrote: >> Hi Marek, >> >> On Mon, Mar 19, 2018 at 10:53 AM, Marek Vasut wrote: >>> On 03/19/2018 09:38 AM, Simon Horman wrote: On Sun, Mar 18, 2018 at 11:52:52AM +0100, Marek Vasut

[PATCH 1/7] arm64: dts: renesas: r8a77965: add usb2_phy nodes

This patch add usb2_phy nodes for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 0/7] arm64: dts: renesas: r8a77965: add usb related nodes

All dt-bindings exist on next-20180319. Since Renesas tree closed for v4.17, this patch set should be for v4.18. Yoshihiro Shimoda (7): arm64: dts: renesas: r8a77965: add usb2_phy nodes arm64: dts: renesas: r8a77965: add usb3_phy node arm64: dts: renesas: r8a77965: add USB 2.0 host nodes

[PATCH 2/7] arm64: dts: renesas: r8a77965: add usb3_phy node

This patch adds usb3_phy node for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 7/7] arm64: dts: renesas: r8a77965: add USB 3.0 peripheral node

This patch adds USB 3.0 peripheral node for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 6/7] arm64: dts: renesas: r8a77965: add USB 3.0 host node

This patch adds USB 3.0 host node for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 5/7] arm64: dts: renesas: r8a77965: add HS-USB node

This patch adds HS-USB node for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH 3/7] arm64: dts: renesas: r8a77965: add USB 2.0 host nodes

This patch adds USB 2.0 host (EHCI/OHCI) nodes for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 38 +++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git

[PATCH 4/7] arm64: dts: renesas: r8a77965: add usb_dmac nodes

This patch adds USB-DMAC nodes for r8a77965. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 11:53 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, Mar 19, 2018 at 10:53 AM, Marek Vasut wrote: >> On 03/19/2018 09:38 AM, Simon Horman wrote: >>> On Sun, Mar 18, 2018 at 11:52:52AM +0100, Marek Vasut wrote: The data link active signal usually

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

Hi Marek, On Mon, Mar 19, 2018 at 10:53 AM, Marek Vasut wrote: > On 03/19/2018 09:38 AM, Simon Horman wrote: >> On Sun, Mar 18, 2018 at 11:52:52AM +0100, Marek Vasut wrote: >>> The data link active signal usually takes ~20 uSec to be asserted, >>> poll the bit more often

Re: [PATCH V4] PCI: rcar: Use runtime PM to control controller clock

On Mon, Mar 19, 2018 at 10:54:47AM +0100, Marek Vasut wrote: > On 03/19/2018 09:44 AM, Simon Horman wrote: > > On Sun, Mar 18, 2018 at 11:52:09AM +0100, Marek Vasut wrote: > >> From: Dien Pham > >> > >> The controller clock can be switched off during suspend/resume,

Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7796: Add VIN4, VIN5 pins, groups and functions

Hi Niklas, Uli, On Fri, Mar 9, 2018 at 11:24 PM, Geert Uytterhoeven wrote: > On Fri, Mar 9, 2018 at 10:58 PM, Niklas Söderlund > wrote: >> On 2018-03-09 13:33:03 +0100, Geert Uytterhoeven wrote: >>> P.S. Apparently R-Car Gen2 and Gen3 also

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On 03/19/2018 09:38 AM, Simon Horman wrote: > On Sun, Mar 18, 2018 at 11:52:52AM +0100, Marek Vasut wrote: >> The data link active signal usually takes ~20 uSec to be asserted, >> poll the bit more often to avoid useless delays in this function. >> >> Signed-off-by: Marek Vasut

Re: [PATCH V4] PCI: rcar: Use runtime PM to control controller clock

On 03/19/2018 09:44 AM, Simon Horman wrote: > On Sun, Mar 18, 2018 at 11:52:09AM +0100, Marek Vasut wrote: >> From: Dien Pham >> >> The controller clock can be switched off during suspend/resume, >> let runtime PM take care of that. >> >> Signed-off-by: Dien Pham

Re: [PATCH 0/8] clk: renesas: Always use readl()/writel()

On Fri, Mar 16, 2018 at 02:40:14PM +0100, Geert Uytterhoeven wrote: > Hi Mike, Stephen, > > On arm32/arm64, there is no reason to use the (soon deprecated) > clk_readl()/clk_writel(), and the generic readl()/writel() should be > used in instead. > > Commit 30ad3cf00e94f4a7 ("clk: renesas:

Re: [PATCH V4] PCI: rcar: Use runtime PM to control controller clock

On Sun, Mar 18, 2018 at 11:52:09AM +0100, Marek Vasut wrote: > From: Dien Pham > > The controller clock can be switched off during suspend/resume, > let runtime PM take care of that. > > Signed-off-by: Dien Pham > Signed-off-by: Hien

Re: [PATCH 2/2] PCI: rcar: Clean up the macros

On Sun, Mar 18, 2018 at 11:52:53AM +0100, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, > no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy

Re: [PATCH 1/2] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On Sun, Mar 18, 2018 at 11:52:52AM +0100, Marek Vasut wrote: > The data link active signal usually takes ~20 uSec to be asserted, > poll the bit more often to avoid useless delays in this function. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > > According to the Devicetree Specification, "ok" is not a valid status. > > Correct. > > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") >

Re: [Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size"

Hi Philippe, > > I don't mind much, but why? My reasoning was "let's first fix the cause > > and then the symptom"? > > The '0' case is worst than incorrect, it segfaults, so you are right :) Ok, thanks. > >> Can you add a #define for this value? Such AT24C_ROMSIZE_MIN. > > > > Can do, of