RE: [PATCH/RFC v4 2/4] usb: gadget: udc: renesas_usb3: Add register of usb role switch

Hi Rob, Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, May 24, 2018 5:18 PM > > Hi Rob, > > On Wed, May 23, 2018 at 5:00 PM, Rob Herring wrote: > >>> > Optional properties: > >>> >- phys: phandle + phy specifier pair > >>> >- phy-names: must be "usb" > >>> >

Re: [PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

Hi Jacopo, Thanks for your work. I really like what you did with this patch in v4. On 2018-05-25 00:02:15 +0200, Jacopo Mondi wrote: > The rcar-vin driver so far had a mutually exclusive code path for > handling parallel and CSI-2 video input subdevices, with only the CSI-2 > use case

[PATCH v4 3/9] media: rcar-vin: Create a group notifier

As CSI-2 subdevices are shared between several VIN instances, a shared notifier to collect the CSI-2 async subdevices is required. So far, the rcar-vin driver used the notifier of the last VIN instance to probe but with the forth-coming introduction of parallel input subdevices support in

[PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

The rcar-vin driver so far had a mutually exclusive code path for handling parallel and CSI-2 video input subdevices, with only the CSI-2 use case supporting media-controller. As we add support for parallel inputs to Gen3 media-controller compliant code path now parse both port@0 and port@1,

[PATCH v4 0/9] rcar-vin: Add support for parallel input on Gen3

Hello, this series adds support for parallel video input to the Gen3 version of rcar-vin driver. Compared to v3, this new iteration closes all comments from Niklas and Sergei. As the meat of the patch series hasn't changed much, please refer to v3 cover letter for more details. The most

[PATCH v4 7/9] media: rcar-vin: Handle parallel subdev in link_notify

Handle parallel subdevices in link_notify callback. If the notified link involves a parallel subdevice, do not change routing of the VIN-CSI-2 devices and mark the VIN instance as using a parallel input. If the CSI-2 link setup succeeds instead, mark the VIN instance as using CSI-2.

[PATCH v4 8/9] media: rcar-vin: Rename _rcar_info to rcar_info

Remove leading underscore to align all rcar_group_route structure declarations. Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 6/9] media: rcar-vin: Link parallel input media entities

When running with media-controller link the parallel input media entities with the VIN entities at 'complete' callback time. To create media links the v4l2_device should be registered first. Check if the device is already registered, to avoid double registrations. Signed-off-by: Jacopo Mondi

[PATCH v4 9/9] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi Reviewed-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- drivers/media/platform/rcar-vin/rcar-core.c |

[PATCH v4 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

As the term 'digital' is used all over the rcar-vin code in place of 'parallel', rename all the occurrencies. Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 72

[PATCH v4 4/9] media: rcar-vin: Cache the mbus configuration flags

Media bus configuration flags and media bus type were so far a property of each VIN instance, as the subdevice they were connected to was immutable during the whole system life time. With the forth-coming introduction of parallel input devices support, a VIN instance can have the subdevice it is

[PATCH v4 2/9] media: rcar-vin: Remove two empty lines

Remove un-necessary empty lines. Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] v4l: vsp1: Fix YCbCr planar formats pitch calculation

From: Koji Matsuoka YCbCr planar formats can have different pitch values for the luma and chroma planes. This isn't taken into account in the driver. Fix it. Based on a BSP patch from Koji Matsuoka . Signed-off-by: Koji Matsuoka

[PATCH] v4l: vsp1: Update LIF buffer thresholds

The LIF module has a data buffer to accommodate clock rate differences between the DU and the VSP. Several programmable threshold values control DU start of frame notification by the VSP and VSP clock stop/resume. The R-Car Gen2 and Gen3 datasheets recommend values for the different SoCs. Update

Re: [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

Hi Niklas, On Thu, May 24, 2018 at 12:42:25AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-05-18 16:40:37 +0200, Jacopo Mondi wrote: > > As the term 'digital' is used all over the rcar-vin code in place of > > 'parallel', rename all the occurrencies. > > > >

Re: [PATCH v3 2/3] arm64: dts: renesas: draak: Describe CVBS input

HI Laurent, On Mon, May 21, 2018 at 04:10:34PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Monday, 21 May 2018 15:33:40 EEST jacopo mondi wrote: > > On Mon, May 21, 2018 at 01:54:55PM +0300, Laurent Pinchart wrote: > > > On Monday, 21 May 2018 12:57:05 EEST jacopo mondi wrote: > > >> On

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

On 24 May 2018 15:51 Marek Vasut wrote: Hi Marek, > To: Steve Twiss ; linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown >

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 05/24/2018 07:40 PM, Sergei Shtylyov wrote: >> For ages trivial changes to RAVB and SuperH ethernet links by means of >> standard 'ethtool' trigger a 'sleeping function called from invalid >> context' bug, to visualize it on r8a7795 ULCB: >> >> % ethtool -r eth0 >> BUG: sleeping function

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

> > For it to be unsafe, i think that would mean phylib would need to call > > back into the MAC driver? The only way that could happen is via the > > adjust_link call. And that will deadlock, since it takes the same > > lock. > > > > Or am i/we missing something? > >It doesn't take any

Re: [PATCH V3] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

On Tue, May 22, 2018 at 02:24:20PM +0200, Marek Vasut wrote: > The data link active signal usually takes ~20 uSec to be asserted, > poll the bit more often to avoid useless delays in this function. > Use udelay() instead of usleep() for such a small delay as suggested > by the timer documentation

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On 05/24/2018 07:44 PM, Andrew Lunn wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. >> >> You don't say that *not* grabbing the spinlock is

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On Thu, May 24, 2018 at 07:18:28PM +0300, Sergei Shtylyov wrote: > Hello! > > On 05/24/2018 05:11 PM, Vladimir Zapolskiy wrote: > > >>> The change fixes a sleep in atomic context issue, which can be > >>> always triggered by running 'ethtool -r' command, because > >>> phy_start_aneg() protects

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > For ages trivial changes to RAVB and SuperH ethernet links by means of > standard 'ethtool' trigger a 'sleeping function called from invalid > context' bug, to visualize it on r8a7795 ULCB: > > % ethtool -r eth0 > BUG: sleeping function

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

Hello! On 05/24/2018 05:11 PM, Vladimir Zapolskiy wrote: >>> The change fixes a sleep in atomic context issue, which can be >>> always triggered by running 'ethtool -r' command, because >>> phy_start_aneg() protects phydev fields by a mutex. You don't say that *not* grabbing the spinlock is

[PATCH v2 2/9] ARM: dts: lager: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 1/9] ARM: shmobile: defconfig: Enable MTD command line partition parsing

In preparation for removing MTD partitioning from the DTs and moving it over to kernel command line partition parsing, enable the support for kernel command line MTD partition parsing. The argument for not having MTD partitions in the DT is the same as for not having hard drive partitions in DT,

Re: [PATCH 6/9] ARM: dts: wheat: Drop MTD partitioning from DT

On 05/23/2018 08:25 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Wed, May 23, 2018 at 12:01 AM, Marek Vasut wrote: >> On 05/22/2018 04:43 PM, Geert Uytterhoeven wrote: >>> On Tue, May 22, 2018 at 2:02 PM, Marek Vasut wrote: Drop the MTD

[PATCH v2 4/9] ARM: dts: koelsch: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 7/9] ARM: dts: gose: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 9/9] ARM: dts: silk: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 6/9] ARM: dts: wheat: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

Re: [PATCH 6/6] mfd: da9063: Add DA9063L support

On 05/24/2018 02:32 PM, Steve Twiss wrote: > Hi Marek, > > On 24 May 2018 @ 12:49 Steve Twiss wrote: > >> To: Marek Vasut ; linux-ker...@vger.kernel.org >> Cc: Marek Vasut ; Geert Uytterhoeven >> ; Lee Jones

[PATCH v2 8/9] ARM: dts: alt: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 5/9] ARM: dts: porter: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

[PATCH v2 3/9] ARM: dts: stout: Drop MTD partitioning from DT

Drop the MTD partitioning from DT, since it does not describe HW and to give way to a more flexible kernel command line partition passing. To retain the original partitioning, assure you have enabled CONFIG_MTD_CMDLINE_PARTS in your kernel config and add the following to your kernel command line:

Re: [PATCH 1/4] PCI: rcar: Rename rcar_pcie_parse_request_of_pci_ranges()

On 05/24/2018 03:50 PM, Lorenzo Pieralisi wrote: > On Thu, May 24, 2018 at 09:24:27AM +0200, Marek Vasut wrote: >> On 05/23/2018 11:56 PM, Bjorn Helgaas wrote: >>> On Wed, May 23, 2018 at 07:05:06PM +0200, Marek Vasut wrote: On 05/23/2018 06:17 PM, Lorenzo Pieralisi wrote: > On Mon, May

[PATCH v4 1/6] PCI: rcar: Pull bus clock enable/disable from rcar_pcie_get_resources()

The rcar_pcie_get_resources() is another misnomer with a side effect. The function does not only get resources, but also enables/disables bus clock. This is forgotten in the probe() function though and if anything in probe() fails after rcar_pcie_get_resources() is called, the bus clock are never

[PATCH v4 5/6] PCI: rcar: Remove IRQ mappings in rcar_pcie_enable_msi failpath

The rcar_pcie_enable_msi() creates IRQ mappings using irq_create_mapping() before requesting the IRQs using devm_request_irq(). If devm_request_irq() fails for some reason, rcar_pcie_enable_msi() does not remove the mapping. Pull out the code for disposing IRQ mappings from

[PATCH v4 2/6] PCI: rcar: Add missing irq_dispose_mapping() into failpath

The rcar_pcie_get_resources() is another misnomer with a side effect. The function does not only get resources, but also maps MSI IRQs via irq_of_parse_and_map(). In case anything fails afterward, the IRQ mapping must be disposed through irq_dispose_mapping() which is not done. This patch handles

[PATCH v4 3/6] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails

If the rcar_pcie_enable() fails and MSIs are enabled, the setup done in rcar_pcie_enable_msi() is never undone. Add a function to tear down the MSI setup by disabling the MSI handling in the PCIe block, deallocating the pages requested for the MSIs and zapping the IRQ mapping. Signed-off-by:

[PATCH v4 4/6] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()

The data link active signal usually takes ~20 uSec to be asserted, poll the bit more often to avoid useless delays in this function. Use udelay() instead of usleep() for such a small delay as suggested by the timer documentation and because this will be used in atomic context later on when the

[PATCH v4 0/6] PCI: rcar: Failpath fixes

Multiple minor failpath fixes for the R-Car PCIe driver. V4: Sync up the version numbers Rebase on top of Lorenzo's tree Add new patch fixing bug in the PHY code Marek Vasut (6): PCI: rcar: Pull bus clock enable/disable from rcar_pcie_get_resources() PCI: rcar: Add missing

[PATCH v4 6/6] PCI: rcar: Shut the PHY down in failpath

If anything fails past phy_init_fn() and the system is a Gen3 with a PHY, the PHY will be left on and inited. This is caused by the phy_init_fn, which is in fact a pointer to rcar_pcie_phy_init_gen3() function, which starts the PHY, yet has no counterpart in the failpath. Add that counterpart.

[PATCH v2 1/5] crypto: ccree: correct host regs offset

The product signature and HW revision register have different offset on the older HW revisions. This fixes the problem of the driver failing sanity check on silicon despite working on the FPGA emulation systems. Fixes: 27b3b22dd98c ("crypto: ccree - add support for older HW revs") Cc:

[PATCH v2 0/5] crypto: ccree: cleanup, fixes and R-Car enabling

The patch set enables the use of CryptoCell found in some Renesas R-Car Salvator-X boards and fixes some driver issues uncovered that prevented to work properly. Changes from v1: - Properly fix the bug that caused us to read a bad signature register rather than dropping the check - Proper DT

[PATCH v2 2/5] crypto: ccree: better clock handling

Use managed clock handling, differentiate between no clock (possibly OK) and clock init failure (never OK) and correctly handle clock detection being deferred. Suggested-by: Geert Uytterhoeven Signed-off-by: Gilad Ben-Yossef ---

[PATCH v2 3/5] crypto: ccree: silence debug prints

The cache parameter register configuration was being too verbose. Use dev_dbg() to only provide the information if needed. Signed-off-by: Gilad Ben-Yossef --- drivers/crypto/ccree/cc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 4/5] clk: renesas: r8a7795: add ccree clock bindings

This patch adds the clock used by the CryptoCell 630p instance in the SoC. Signed-off-by: Gilad Ben-Yossef --- This patch depends upon the "clk: renesas: r8a7795: Add CR clock" patch from Geert Uytterhoeven. drivers/clk/renesas/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1

[PATCH v2 5/5] arm64: dts: renesas: r8a7795: add ccree binding

Add bindings for CryptoCell instance in the SoC. Signed-off-by: Gilad Ben-Yossef --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi

Applied "spi: sh-msiof: Fix setting SIRMDR1.SYNCAC to match SITMDR1.SYNCAC" to the spi tree

The patch spi: sh-msiof: Fix setting SIRMDR1.SYNCAC to match SITMDR1.SYNCAC has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On 05/24/2018 04:22 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:53PM +0300, Vladimir Zapolskiy wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. >>

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

Hi Andrew, On 05/24/2018 04:29 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep in atomic context bug,

Re: [PATCH 1/4] PCI: rcar: Rename rcar_pcie_parse_request_of_pci_ranges()

On Thu, May 24, 2018 at 09:24:27AM +0200, Marek Vasut wrote: > On 05/23/2018 11:56 PM, Bjorn Helgaas wrote: > > On Wed, May 23, 2018 at 07:05:06PM +0200, Marek Vasut wrote: > >> On 05/23/2018 06:17 PM, Lorenzo Pieralisi wrote: > >>> On Mon, May 21, 2018 at 03:11:20PM +0200, Marek Vasut wrote: >

Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding

Hi Gilad, On Thu, May 24, 2018 at 3:20 PM, Gilad Ben-Yossef wrote: > On Tue, May 22, 2018 at 10:48 AM, Geert Uytterhoeven > wrote: >> On Mon, May 21, 2018 at 3:43 PM, Gilad Ben-Yossef >> wrote: >>> On Thu, May 17, 2018 at 1:16

Re: [PATCH 5/6] sh_eth: remove custom .get_link_ksettings from ethtool ops

On Thu, May 24, 2018 at 02:14:43PM +0300, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .get_link_ksettings > callback with a shared phy_ethtool_get_link_ksettings(), note that > >lock wrapping is not needed, because the lock does not > serialize access to phydev

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

On Thu, May 24, 2018 at 02:11:56PM +0300, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. > > Another note is that the change implicitly

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On Thu, May 24, 2018 at 02:11:53PM +0300, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. > > Another note is that the change implicitly

Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding

On Tue, May 22, 2018 at 10:48 AM, Geert Uytterhoeven wrote: > Hi Gilad, > > On Mon, May 21, 2018 at 3:43 PM, Gilad Ben-Yossef wrote: >> On Thu, May 17, 2018 at 1:16 PM, Geert Uytterhoeven >> wrote: >>> Indeed. From a quick glance,

RE: [PATCH 3/6] mfd: da9063: Add DA9063L type

On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ;

Re: [PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:21 EEST Kieran Bingham wrote: > Calculate the top and bottom fields for the interlaced frames and > utilise the extended display list command feature to implement the > auto-field operations. This allows the DU to update the VSP2

RE: [PATCH 4/6] mfd: da9063: Disallow RTC on DA9063L

Thanks Marek, On 23 May 2018 12:42 Marek Vasut wrote, > To: linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

Hi Marek, On 24 May 2018 @ 12:49 Steve Twiss wrote: > To: Marek Vasut ; linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ;

Re: [PATCH v4 09/11] media: vsp1: Provide support for extended command pools

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:20 EEST Kieran Bingham wrote: > VSPD and VSP-DL devices can provide extended display lists supporting > extended command display list objects. > > These extended commands require their own dma memory areas for a header > and body

RE: [PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

Hi Marek, On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss

Re: [PATCH] i2c: mux: improve error message for failed symlink

On 2018-05-21 09:34, Wolfram Sang wrote: > Trivial, but still: the failed symlink is not *for* the channel but a > link *to* the channel. > > Signed-off-by: Wolfram Sang Applied to i2c-mux/for-next. Cheers, Peter

Re: [PATCH v2 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs

On 2018-05-22 21:13, Wolfram Sang wrote: > Hi Peter, > >> Hmm, now that I have slept on it, I find this a bit odd. For muxes, all >> channels and the parent are always present. Here, that is not the case. >> And don't get me wrong, I see why that is the case, but that doesn't >> mean that I like

Re: [PATCH v2 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter

On 2018-05-21 09:29, Wolfram Sang wrote: > Due to a typo, the wrong parent device was assigned to the newly created > demuxing adapter device. It got connected to the demuxing platform > device but not to the selected parent I2C adapter device. Fix it to get > a proper parent-child relationship of

Re: [PATCH v4 11/11] drm: rcar-du: Support interlaced video output through vsp1

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:22 EEST Kieran Bingham wrote: > Use the newly exposed VSP1 interface to enable interlaced frame support > through the VSP1 lif pipelines. s/lif/LIF/ > > Signed-off-by: Kieran Bingham >

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

Thanks Marek, > On 23 May 2018 12:43 Marek Vasut wrote, > > To: linux-ker...@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; > Lee Jones ; Mark Brown ; Steve > Twiss

Re: [PATCH v4 08/11] media: vsp1: Add support for extended display list headers

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:19 EEST Kieran Bingham wrote: > Extended display list headers allow pre and post command lists to be > executed by the VSP pipeline. This provides the base support for > features such as AUTO_FLD (for interlaced support) and

[PATCH 5/6] sh_eth: remove custom .get_link_ksettings from ethtool ops

The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that >lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy ---

[PATCH 6/6] sh_eth: remove custom .set_link_ksettings from ethtool ops

The change replaces a custom implementation of .set_link_ksettings callback with a shared phy_ethtool_set_link_ksettings(), this fixes sleep in atomic context bug, which is encountered every time when link settings are changed by ethtool. Now duplex mode setting is enforced in ravb_adjust_link()

[PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

The change fixes a sleep in atomic context issue, which can be always triggered by running 'ethtool -r' command, because phy_start_aneg() protects phydev fields by a mutex. Another note is that the change implicitly replaces phy_start_aneg() with a newer phy_restart_aneg(). Signed-off-by:

[PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

For ages trivial changes to RAVB and SuperH ethernet links by means of standard 'ethtool' trigger a 'sleeping function called from invalid context' bug, to visualize it on r8a7795 ULCB: % ethtool -r eth0 BUG: sleeping function called from invalid context at kernel/locking/mutex.c:747

[PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

The change fixes a sleep in atomic context issue, which can be always triggered by running 'ethtool -r' command, because phy_start_aneg() protects phydev fields by a mutex. Another note is that the change implicitly replaces phy_start_aneg() with a newer phy_restart_aneg(). Signed-off-by:

[PATCH 2/6] ravb: remove custom .get_link_ksettings from ethtool ops

The change replaces a custom implementation of .get_link_ksettings callback with a shared phy_ethtool_get_link_ksettings(), note that >lock wrapping is not needed, because the lock does not serialize access to phydev fields. Signed-off-by: Vladimir Zapolskiy ---

[PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

The change replaces a custom implementation of .set_link_ksettings callback with a shared phy_ethtool_set_link_ksettings(), this fixes sleep in atomic context bug, which is encountered every time when link settings are changed by ethtool. Now duplex mode setting is enforced in ravb_adjust_link()

Re: [PATCH v4 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:18 EEST Kieran Bingham wrote: > Header mode display lists are now supported on all WPF outputs. To > support extended headers and auto-fld capabilities for interlaced mode > handling only header mode display lists can be used. >

Re: [PATCH v4 06/11] media: vsp1: Provide VSP1 feature helper macro

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:17 EEST Kieran Bingham wrote: > The VSP1 devices define their specific capabilities through features > marked in their device info structure. Various parts of the code read > this info structure to infer if the features are

Re: [PATCH v4 05/11] media: vsp1: Clean up DLM objects on error

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:16 EEST Kieran Bingham wrote: > If there is an error allocating a display list within a DLM object > the existing display lists are not free'd, and neither is the DL body > pool. > > Use the existing vsp1_dlm_destroy() function

Re: [PATCH v4 03/11] media: vsp1: Rename dl_child to dl_next

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:14 EEST Kieran Bingham wrote: > Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display > list chain referencing the nodes as children, when in reality they are > siblings. > > Update the terminology to 'dl_next' to

Re: [PATCH v4 04/11] media: vsp1: Remove unused display list structure field

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:15 EEST Kieran Bingham wrote: > The vsp1 reference in the vsp1_dl_body structure is not used. > Remove it. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart

[PATCH v3 3/3] ARM: dts: Renesas R9A06G032 SMP enable method

Add a special enable method for the second CA7 of the R9A06G032 as well as the default value for the "cpu-release-addr" property. Signed-off-by: Michel Pollet --- arch/arm/boot/dts/r9a06g032.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v3 8/9] media: rcar-vin: Rename _rcar_info to rcar_info

Hi Jacopo, Thanks for your work. On 2018-05-18 16:40:44 +0200, Jacopo Mondi wrote: > Remove trailing underscore to align all rcar_group_route structure > declarations. > > Signed-off-by: Jacopo Mondi With Sergei's comment addressed: Acked-by: Niklas Söderlund

Re: [PATCH v3 7/9] media: rcar-vin: Handle parallel subdev in link_notify

Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:43 +0200, Jacopo Mondi wrote: > Handle parallel subdevices in link_notify callback. If the notified link > involves a parallel subdevice, do not change routing of the VIN-CSI-2 > devices and mark the VIN instance as using a parallel input. If

[PATCH v3 2/3] arm: shmobile: Add the R9A06G032 SMP enabler driver

The Renesas R9A06G032 second CA7 is parked in a ROM pen at boot time, it requires a special enable method to get it started. Signed-off-by: Michel Pollet --- arch/arm/mach-shmobile/Makefile| 1 + arch/arm/mach-shmobile/smp-r9a06g032.c | 85

[PATCH v3 1/3] dt-bindings: cpu: Add Renesas R9A06G032 SMP enable method.

Add a special enable method for second CA7 of the R9A06G032 Signed-off-by: Michel Pollet Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/cpus.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 0/3] Renesas R9A06G032 SMP enabler

*WARNING -- this requires the base R9A06G032 support patches already posted This patch series is for enabling the second CA7 of the R9A06G032. It's based on a spin_table method, and it reuses the same binding property as that driver. v3: + Removed mentions of rz/?n1d? + Rebased on base

Re: [PATCH v3 6/9] media: rcar-vin: Link parallel input media entities

Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:42 +0200, Jacopo Mondi wrote: > When running with media-controller link the parallel input > media entities with the VIN entities at 'complete' callback time. > > To create media links the v4l2_device should be registered first. > Check if

Re: [PATCH v3 5/9] media: rcar-vin: Parse parallel input on Gen3

Hi Jacopo, Thanks for your work. On 2018-05-18 16:40:41 +0200, Jacopo Mondi wrote: > The rcar-vin driver so far had a mutually exclusive code path for > handling parallel and CSI-2 video input subdevices, with only the CSI-2 > use case supporting media-controller. As we add support for parallel

Re: [PATCH v4 01/11] media: vsp1: drm: Fix minor grammar error

Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:12 EEST Kieran Bingham wrote: > The pixel format is 'unsupported'. Fix the small debug message which > incorrectly declares this. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent

Re: [PATCH v3 4/9] media: rcar-vin: Cache the mbus configuration flags

Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:40 +0200, Jacopo Mondi wrote: > Media bus configuration flags and media bus type were so far a property > of each VIN instance, as the subdevice they were connected to was > immutable during the whole system life time. > > With the

Re: [PATCH v3 3/9] media: rcar-vin: Create a group notifier

Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:39 +0200, Jacopo Mondi wrote: > As CSI-2 subdevices are shared between several VIN instances, a shared > notifier to collect the CSI-2 async subdevices is required. So far, the > rcar-vin driver used the notifier of the last VIN instance to

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

Hi Kieran, On Thursday, 3 May 2018 16:45:30 EEST Kieran Bingham wrote: > On 03/05/18 12:13, Laurent Pinchart wrote: [snip] > >>> diff --git a/drivers/media/platform/vsp1/vsp1_rwpf.h > >>> b/drivers/media/platform/vsp1/vsp1_rwpf.h index > >>> 70742ecf766f..8d6e42f27908 100644 > >>> ---

[PATCH v7 5/5] clk: renesas: Renesas R9A06G032 clock driver

This provides a clock driver for the Renesas R09A06G032. This uses a structure derived from both the RCAR gen2 driver as well as the renesas-cpg-mssr driver. Signed-off-by: Michel Pollet --- drivers/clk/renesas/Kconfig| 6 +

[PATCH v7 4/5] ARM: dts: Renesas RZN1D-DB Board base file

This adds a base device tree file for the RZN1-DB board, with only the basic support allowing the system to boot to a prompt. Only one UART is used, with only a single CPU running. Signed-off-by: Michel Pollet --- arch/arm/boot/dts/Makefile | 1 +

[PATCH v7 3/5] ARM: dts: Renesas R9A06G032 base device tree file

This adds the Renesas R9A06G032 bare bone support. This currently only handles generic parts (gic, architected timer) and a UART. Signed-off-by: Michel Pollet --- arch/arm/boot/dts/r9a06g032.dtsi | 86 1 file changed, 86

[PATCH v7 2/5] dt-bindings: clock: renesas,r9a06g032-sysctrl: documentation

The Renesas R9A06G032 SYSCTRL node description. Signed-off-by: Michel Pollet --- .../bindings/clock/renesas,r9a06g032-sysctrl.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644

[PATCH v7 1/5] dt-bindings: Add the r9a06g032-sysctrl.h file

This adds the constants necessary to use the renesas,r9a06g032-sysctrl node. Signed-off-by: Michel Pollet Reviewed-by: Rob Herring --- include/dt-bindings/clock/r9a06g032-sysctrl.h | 187 ++ 1 file changed, 187

  1   2   >