[PATCH 1/1] i2c: rcar: handle RXDMA HW behaviour on Gen3

2018-06-28 Thread Wolfram Sang
On Gen3, we can only do RXDMA once per transfer reliably. For that, we must reset the device, then we can have RXDMA once. This patch implements this. When there is no reset controller or the reset fails, RXDMA will be blocked completely. Otherwise, it will be disabled after the first RXDMA

[PATCH 0/1] i2c: rcar: handle RXDMA HW behaviour on Gen3

2018-06-28 Thread Wolfram Sang
As mentioned in the patch description, this patch works around a HW issue on Renesas R-Car Gen3 SoCs. It had not been discovered yet because it only happens when clearing DMA enable bits is too late because of latency. To reproduce the problem reliably, the below patch was used [1]. To the best

Re: [PATCH] pci: fix I/O space page leak

2018-06-28 Thread Lorenzo Pieralisi
On Thu, Jun 28, 2018 at 08:22:59AM -0500, Bjorn Helgaas wrote: > On Wed, Jun 20, 2018 at 08:51:37PM +0300, Sergei Shtylyov wrote: > > When testing the R-Car PCIe driver on the Condor board, I noticed that iff > > I left the PCIe PHY driver disabled, the kernel crashed with this BUG: > > > > [

Re: [PATCH] arm64: dts: renesas: r8a77965: Add second port to rcar_sound placeholder

2018-06-28 Thread Geert Uytterhoeven
On Thu, Jun 28, 2018 at 2:43 PM Simon Horman wrote: > This node is just a placeholder but fills that function better if it does > not trigger build warnings. This update satisfies the requirement that > nodes with #address-cells/#size-cells properties have more than one child > node. > > This is

Re: [PATCH] pci: fix I/O space page leak

2018-06-28 Thread Bjorn Helgaas
On Wed, Jun 20, 2018 at 08:51:37PM +0300, Sergei Shtylyov wrote: > When testing the R-Car PCIe driver on the Condor board, I noticed that iff > I left the PCIe PHY driver disabled, the kernel crashed with this BUG: > > [1.225819] kernel BUG at lib/ioremap.c:72! > [1.230007] Internal

Re: [PATCH 2/2] mmc: renesas_sdhi_internal_dmac: Cannot clear the RX_IN_USE in abort

2018-06-28 Thread Geert Uytterhoeven
On Thu, Jun 28, 2018 at 1:53 PM Yoshihiro Shimoda wrote: > This patch is fixes an issue that the SDHI_INTERNAL_DMAC_RX_IN_USE > flag cannot be cleared because tmio_mmc_core sets the host->data > to NULL before the tmio_mmc_core calls tmio_mmc_abort_dma(). > > So, this patch clears the

Re: [PATCH 1/2] mmc: renesas_sdhi_internal_dmac: Fix missing unmap in error patch

2018-06-28 Thread Geert Uytterhoeven
Hi Shimoda-san, On Thu, Jun 28, 2018 at 1:53 PM Yoshihiro Shimoda wrote: > This patch fixes an issue that lacks the dma_unmap_sg() calling in > the error patch of renesas_sdhi_internal_dmac_start_dma(). Nice catch! Thanks for your patch! > Fixes: 0cbc94daa554 ("mmc: renesas_sdhi_internal_dmac:

Re: [PATCH v9 3/5] ARM: dts: Renesas R9A06G032 base device tree file

2018-06-28 Thread Geert Uytterhoeven
Hi Simon, On Thu, Jun 28, 2018 at 2:16 PM Simon Horman wrote: > On Thu, Jun 28, 2018 at 02:00:32PM +0200, Simon Horman wrote: > > On Thu, Jun 14, 2018 at 11:56:32AM +0100, Michel Pollet wrote: > > > This adds the Renesas R9A06G032 bare bone support. > > > > > > This currently only handles the

[PATCH] arm64: dts: renesas: r8a77965: Add second port to rcar_sound placeholder

2018-06-28 Thread Simon Horman
: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary Signed-off-by: Simon Horman --- Based on renesas-devel-20180628-v4.18-rc2 --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77965

[PATCH 1/2] mmc: renesas_sdhi_internal_dmac: Fix missing unmap in error patch

2018-06-28 Thread Yoshihiro Shimoda
This patch fixes an issue that lacks the dma_unmap_sg() calling in the error patch of renesas_sdhi_internal_dmac_start_dma(). Fixes: 0cbc94daa554 ("mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs") Cc: # v4.17+ Signed-off-by: Yoshihiro Shimoda ---

[PATCH 2/2] mmc: renesas_sdhi_internal_dmac: Cannot clear the RX_IN_USE in abort

2018-06-28 Thread Yoshihiro Shimoda
This patch is fixes an issue that the SDHI_INTERNAL_DMAC_RX_IN_USE flag cannot be cleared because tmio_mmc_core sets the host->data to NULL before the tmio_mmc_core calls tmio_mmc_abort_dma(). So, this patch clears the SDHI_INTERNAL_DMAC_RX_IN_USE in the renesas_sdhi_internal_dmac_abort_dma()

[PATCH 0/2] mmc: renesas_sdhi_internal_dmac: fix two issues for error path

2018-06-28 Thread Yoshihiro Shimoda
This patch set is based on the mmc.git / fixes branch. Yoshihiro Shimoda (2): mmc: renesas_sdhi_internal_dmac: Fix missing unmap in error patch mmc: renesas_sdhi_internal_dmac: Cannot clear the RX_IN_USE in abort drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 +--- 1 file changed, 5

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-28 Thread Wolfram Sang
> Note that reset controller support is optional, so we want to add > > select RESET_CONTROLLER if ARCH_RENESAS && ARM64 > > to the I2C_RCAR section drivers/i2c/busses/Kconfig. Else reset will fail > silently. Actually, no. I use a non-optional reset_controller_get[1], so I will get an

Re: [PATCH] pinctrl: sh-pfc: fix a null pointer dereference of drive strength information

2018-06-28 Thread Geert Uytterhoeven
Hi Niklas, On Thu, Jun 28, 2018 at 2:41 AM Niklas Söderlund wrote: > On 2018-06-27 10:27:54 +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 27, 2018 at 8:01 AM Niklas Söderlund > > wrote: > > > Not all SoCs describes the drive strength registers. When reading the > > > sysfs pinconf-pins file