RE: [PATCH 2/2] serial: sh-sci: Document r7s9210 bindings

2018-07-24 Thread Chris Brandt
Hi Geert, I have one last clarification about your idea regarding documenting the interrupts separately for RZ/A2. On Thursday, July 19, 2018, Geert Uytterhoeven wrote: > For DT backwards compatibility, we have to keep support for the following > 2 schemes: > 1. Single "interrupts" value, no

[PATCH 3/3] soc: renesas: Identify RZ/G2M

2018-07-24 Thread Biju Das
This patch adds support for identifying the RZ/G2M (r8a774a1) SoC. It corrects the original RZ/G SoC family name to RZ/G1 and also adds support for the new RZ/G2 SoC family. Signed-off-by: Biju Das Reviewed-by: Chris Paterson --- This patch corrects the RZ/G family name. Can it be considered

[PATCH 1/3] dt-bindings: arm: Document RZ/G2M SoC DT bindings

2018-07-24 Thread Biju Das
Add device tree bindings documentation for Renesas RZ/G2M (r8a774a1) SoC. Signed-off-by: Biju Das Reviewed-by: Chris Paterson --- Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt

[PATCH 2/3] arm64: Add Renesas R8A774A1 support

2018-07-24 Thread Biju Das
Add configuration option for the RZ/G2M (R8A774A1) SoC. Signed-off-by: Biju Das Reviewed-by: Chris Paterson --- arch/arm64/Kconfig.platforms | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index d5aeac3..6b9f487 100644 ---

[PATCH 0/3] RZ/G2M SoC identification support

2018-07-24 Thread Biju Das
This patch series aims to add SoC identification support for RZ/G2M SoC. RZ/G2M SoC is similar to R-Car Gen3 M3-W SoC. Biju Das (3): dt-bindings: arm: Document RZ/G2M SoC DT bindings arm64: Add Renesas R8A774A1 support soc: renesas: Identify RZ/G2M

Re: [PATCH v3 3/4] mmc: renesas_sdhi: Fix sampling clock position selecting

2018-07-24 Thread Niklas Söderlund
Hi Wolfram, On 2018-07-24 13:26:34 +0200, Wolfram Sang wrote: > On Tue, Jul 17, 2018 at 04:52:15PM +0200, Niklas Söderlund wrote: > > When tuning each tap is issued CMD19 twice and the result of both runs > > recorded in host->taps. If the result is different between the two runs > > the wrong

[PATCH v4 0/2] mmc: {tmio,renesas_sdhi}: fix tuning behavior

2018-07-24 Thread Niklas Söderlund
Hi, Tuning failed on my R-Car H3 ES2.0 board using latest mmc/next while the Renesas BSP kernel worked. After some digging I found patches in the BSP which remedied this and whit these applied tuning now works for me. I have done small fixes, updated commit messages and rebased on latest

[PATCH v4 1/2] mmc: tmio: Fix tuning flow

2018-07-24 Thread Niklas Söderlund
From: Masaharu Hayakawa If the return value of mmc_send_tuning() is error other than -EILSEQ, the tuning fails and process goes out of for_loop. The correct processing is to judge their TAP as not good (NG) and continue. Signed-off-by: Masaharu Hayakawa [Niklas: update commit message]

[PATCH v4 2/2] mmc: renesas_sdhi: Fix sampling clock position selecting

2018-07-24 Thread Niklas Söderlund
When tuning each tap is issued CMD19 twice and the result of both runs recorded in host->taps. If the result is different between the two runs the wrong sampling clock position was selected. Fix this by merging the two runs and only keep the result for each tap if it was good in both sets.

Re: [PATCH/RFT 0/7] rsnd: add support for r8a77965

2018-07-24 Thread Yoshihiro Kaneko
Hi Simon-san, 2018-07-24 1:21 GMT+09:00 Simon Horman : > On Wed, Jul 18, 2018 at 04:47:56AM +0900, Yoshihiro Kaneko wrote: >> This series adds sound support for r8a77965 (R-Car M3-N). >> This series is based on the devel branch of Simon Horman's renesas tree. >> >> Hiroyuki Yokoyama (1): >>

Re: [PATCH 1/1] i2c: rcar: handle RXDMA HW behaviour on Gen3

2018-07-24 Thread Wolfram Sang
On Mon, Jul 23, 2018 at 07:55:22PM +0200, Wolfram Sang wrote: > On Thu, Jun 28, 2018 at 10:45:38PM +0200, Wolfram Sang wrote: > > On Gen3, we can only do RXDMA once per transfer reliably. For that, we > > must reset the device, then we can have RXDMA once. This patch > > implements this. When

Re: [PATCH v3 3/4] mmc: renesas_sdhi: Fix sampling clock position selecting

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 01:26:34PM +0200, Wolfram Sang wrote: > On Tue, Jul 17, 2018 at 04:52:15PM +0200, Niklas Söderlund wrote: > > When tuning each tap is issued CMD19 twice and the result of both runs > > recorded in host->taps. If the result is different between the two runs > > the wrong

Re: [PATCH v3 2/4] mmc: tmio: Fix SCC error detection

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 01:17:10PM +0200, Wolfram Sang wrote: > > > > This patch breaks HS400 on my M3-N again :( > > > > > > > I think that may be because renesas_sdhi_check_scc_error needs > > to be taught about 8-tap HS400. > > Right, so patch 2 kind of depends on patch 4? Yes, I think so.

Re: [PATCH] arm64: dts: renesas: r8a77995: Attach the SYS-DMAC to the IPMMU

2018-07-24 Thread Simon Horman
On Fri, Jul 20, 2018 at 01:10:32PM +0200, Geert Uytterhoeven wrote: > On Thu, Jul 19, 2018 at 1:23 PM Magnus Damm wrote: > > From: Magnus Damm > > > > Hook up SYS-DMAC0, SYS-DMAC1 and SYS-DMAC2 to IPMMU-DS0 and IPMMU-DS1 > > following the R-Car Gen3 Rev.1.00 (April 2018) datasheet. > > > >

Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files

2018-07-24 Thread Simon Horman
On Fri, Jul 20, 2018 at 02:16:13AM +0900, Magnus Damm wrote: > Hi Niklas, > > On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund > wrote: > > Hi Magnus, > > > > Thanks for your patch. > > > > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote: > >> From: Magnus Damm > >> > >> Browsing the DTS for

Re: [PATCH] arm64: dts: renesas: r8a77980: add RWDT support

2018-07-24 Thread Simon Horman
On Mon, Jul 23, 2018 at 07:14:28PM +0300, Sergei Shtylyov wrote: > On 07/23/2018 07:08 PM, Simon Horman wrote: > > >> Describe RWDT in the R8A77980 SoC device tree. > >> > >> Enable RWDT on the Condor and V3H Starter Kit boards. > >> > >> Based on the original (and large) patch by Vladimir

Re: [PATCH] ARM: dts: iwg23s-sbc: Add pinctl support for scif1

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 08:59:18AM +0200, Geert Uytterhoeven wrote: > On Fri, Jul 20, 2018 at 3:19 PM Biju Das wrote: > > Adding pinctrl support for scif1 interface. > > > > Signed-off-by: Biju Das > > Reviewed-by: Chris Paterson > > Reviewed-by: Geert Uytterhoeven Thanks, applied for v4.20.

Re: [PATCH] thermal: rcar_thermal: avoid NULL dereference in absense of IRQ resources

2018-07-24 Thread Geert Uytterhoeven
On Tue, Jul 24, 2018 at 1:15 PM Simon Horman wrote: > Ensure that the base address used by a call to rcar_thermal_common_write() > may be NULL if the SOC supports interrupts for use with the thermal device > but none are defined in DT as is the case for R-Car H1 (r8a7779). Guard > against this

Re: [PATCH] ARM: dts: r8a77470: Add PFC support

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 08:55:51AM +0200, Geert Uytterhoeven wrote: > On Fri, Jul 20, 2018 at 3:15 PM Biju Das wrote: > > Define the generic R8A77470 part of the PFC device node. > > > > Signed-off-by: Biju Das > > Reviewed-by: Fabrizio Castro > > Reviewed-by: Geert Uytterhoeven Thanks,

Re: [PATCH] ARM: dts: r8a77470: Use r8a77470-sysc binding definitions

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 08:54:01AM +0200, Geert Uytterhoeven wrote: > On Fri, Jul 20, 2018 at 3:12 PM Biju Das wrote: > > Replace the hardcoded power domain indices by R8A77470_PD_* symbols. > > > > Signed-off-by: Biju Das > > Reviewed-by: Chris Paterson > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH] ARM: dts: rcar: Correct SATA device sizes to 2 MiB

2018-07-24 Thread Simon Horman
On Mon, Jul 23, 2018 at 05:51:33PM +0200, Simon Horman wrote: > On Fri, Jul 20, 2018 at 02:28:57PM +0200, Geert Uytterhoeven wrote: > > Update the SATA device nodes on R-Car H1, H2, and M2-W to use a 2 MiB > > I/O space, as specified in Rev.1.0 of the R-Car H1 and R-Car Gen2 > > hardware user

Re: [PATCH v3 3/4] mmc: renesas_sdhi: Fix sampling clock position selecting

2018-07-24 Thread Wolfram Sang
On Tue, Jul 17, 2018 at 04:52:15PM +0200, Niklas Söderlund wrote: > When tuning each tap is issued CMD19 twice and the result of both runs > recorded in host->taps. If the result is different between the two runs > the wrong sampling clock position was selected. Fix this by merging the > two runs

Re: [PATCH v3 1/4] mmc: tmio: Fix tuning flow

2018-07-24 Thread Wolfram Sang
> > Simon, did I get it correctly, it worked without this patch for you? > > I think so but I would have to re-test for sure as at some > point I had a variant of this patch in my patch stack. Not needed IMO. We had this case already that some memories work without this patch and some don't.

Re: [PATCH v3 2/4] mmc: tmio: Fix SCC error detection

2018-07-24 Thread Wolfram Sang
> > This patch breaks HS400 on my M3-N again :( > > > > I think that may be because renesas_sdhi_check_scc_error needs > to be taught about 8-tap HS400. Right, so patch 2 kind of depends on patch 4? Niklas, how is your status on reworking patch 4? signature.asc Description: PGP signature

[PATCH] thermal: rcar_thermal: avoid NULL dereference in absense of IRQ resources

2018-07-24 Thread Simon Horman
Ensure that the base address used by a call to rcar_thermal_common_write() may be NULL if the SOC supports interrupts for use with the thermal device but none are defined in DT as is the case for R-Car H1 (r8a7779). Guard against this condition to prevent a NULL dereference when the device is

Re: [PATCH v3 2/4] mmc: tmio: Fix SCC error detection

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 12:44:59PM +0200, Wolfram Sang wrote: > On Tue, Jul 17, 2018 at 04:52:14PM +0200, Niklas Söderlund wrote: > > From: Masaharu Hayakawa > > > > SDR104 and HS200 need to check for SCC error. If SCC error is detected, > > retuning is necessary. > > > > Signed-off-by:

Re: [PATCH v3 1/4] mmc: tmio: Fix tuning flow

2018-07-24 Thread Simon Horman
On Tue, Jul 24, 2018 at 12:42:54PM +0200, Wolfram Sang wrote: > On Tue, Jul 17, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote: > > From: Masaharu Hayakawa > > > > If the return value of mmc_send_tuning() is error other than -EILSEQ, > > the tuning fails and process goes out of for_loop. The

Re: [PATCH v3 2/4] mmc: tmio: Fix SCC error detection

2018-07-24 Thread Wolfram Sang
On Tue, Jul 17, 2018 at 04:52:14PM +0200, Niklas Söderlund wrote: > From: Masaharu Hayakawa > > SDR104 and HS200 need to check for SCC error. If SCC error is detected, > retuning is necessary. > > Signed-off-by: Masaharu Hayakawa > [Niklas: update commit message] > Signed-off-by: Niklas

Re: [PATCH v3 1/4] mmc: tmio: Fix tuning flow

2018-07-24 Thread Wolfram Sang
On Tue, Jul 17, 2018 at 04:52:13PM +0200, Niklas Söderlund wrote: > From: Masaharu Hayakawa > > If the return value of mmc_send_tuning() is error other than -EILSEQ, > the tuning fails and process goes out of for_loop. The correct > processing is to judge their TAP as not good (NG) and continue.

Re: [PATCH] mmc: renesas_sdhi: Add r8a77990 support

2018-07-24 Thread Wolfram Sang
> 8 tap support is included in the following patch which was accepted > for inclusion in upstream (search for 4TAP): > > 26eb2607fa28 ("mmc: renesas_sdhi: add eMMC HS400 mode support") Wow, sorry, I missed that :( I thought there were only 8 TAP preparations in there. Cool, will have a look...

Re: [PATCH] mmc: renesas_sdhi: Add r8a77990 support

2018-07-24 Thread Wolfram Sang
> However, the figures at the top of Sections 70 and 70.2 indicate SDHI is not > available on R-Car E3 (and H3, M3-W, and M3-N)?!? When you look at other chapters, "not available" is usually printed in light gray. I am not sure what these different kinds of styles mean in chapter 70, yet I know

Re: [PATCH] mmc: renesas_sdhi: Add r8a77990 support

2018-07-24 Thread Geert Uytterhoeven
Hi Wolfram, On Sat, Jul 21, 2018 at 1:14 PM Wolfram Sang wrote: > This patch adds SDHI support for the R8A77990 SoC (R-Car E3). No driver > changes > needed for anything except HS400 which we will enable separately later. > > Signed-off-by: Wolfram Sang This matches Table 70.1 ("Pin

Re: [PATCH] arm64: dts: renesas: r8a77980: add RWDT support

2018-07-24 Thread Geert Uytterhoeven
On Fri, Jul 20, 2018 at 9:21 PM Sergei Shtylyov wrote: > Describe RWDT in the R8A77980 SoC device tree. > > Enable RWDT on the Condor and V3H Starter Kit boards. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov

Re: [PATCH] ARM: dts: iwg23s-sbc: Add pinctl support for scif1

2018-07-24 Thread Geert Uytterhoeven
On Fri, Jul 20, 2018 at 3:19 PM Biju Das wrote: > Adding pinctrl support for scif1 interface. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond

Re: [PATCH] ARM: dts: r8a77470: Add PFC support

2018-07-24 Thread Geert Uytterhoeven
On Fri, Jul 20, 2018 at 3:15 PM Biju Das wrote: > Define the generic R8A77470 part of the PFC device node. > > Signed-off-by: Biju Das > Reviewed-by: Fabrizio Castro Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of

Re: [PATCH] ARM: dts: r8a77470: Use r8a77470-sysc binding definitions

2018-07-24 Thread Geert Uytterhoeven
On Fri, Jul 20, 2018 at 3:12 PM Biju Das wrote: > Replace the hardcoded power domain indices by R8A77470_PD_* symbols. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --