[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

2017-03-15 Thread Matthew Giassa
Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

2017-03-15 Thread Matthew Giassa
Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

2017-03-15 Thread Matthew Giassa
Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_i

[PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes

2017-03-15 Thread Matthew Giassa
The following patches address all outstanding checkpatch warnings/errors present in drivers/staging/ks7010/ks_wlan_ioctl.h. This change set has been rebased off of the current master (69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request, and the change log formatting has been

[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

2017-03-15 Thread Matthew Giassa
Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioct

Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

2017-03-15 Thread Matthew Giassa
* Tobin C. Harding <m...@tobin.cc> [2017-03-15 14:14:08 +1100]: On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote: Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all chec

[PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space

2017-03-14 Thread Matthew Giassa
Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioct

[PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs

2017-03-14 Thread Matthew Giassa
Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses

2017-03-14 Thread Matthew Giassa
Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_i

[PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes.

2017-03-14 Thread Matthew Giassa
Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 2/2] Formatting updates to resolve checkpatch errors in ks_wlan_ioctl.h.

2017-03-05 Thread Matthew Giassa
Updating macros to be wrapped in parentheses to accomodate checkpatch errors throughout the header. This change, combined with the previous patch, resolves all outstanding warnings/errors produce by checkpatch. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/

[PATCH 1/2] Formatting updates to remove checkpatch warnings in ks_wlan_ioctl.h.

2017-03-05 Thread Matthew Giassa
Implementing some minor formatting changes to remove checkpatch warnings. Removing space-hardtab instances. Removing C++-style line comments in favor of C-style equivalent. Re-aligning function prototype arguments to remove related checkpatch warning. Signed-off-by: Matthew Giassa <m

[PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 0aa402d..9f71f01 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++

[PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..47c8015 100644 ---

[PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 9f71f01..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++

[PATCHv3 2/4] Removing trailing whitespace in comment block.

2017-02-26 Thread Matthew Giassa
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 47c8015..0aa402d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++

[PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h

2017-02-26 Thread Matthew Giassa
Assembling a set of patches to address all outstanding checkpatch issues in staging/drivers/ks7010/ks_wlan_ioctl.h to replace my earlier v2 work which attempted to do all of this in a single patch. This includes wrapping macros with complex values in parentheses, removing extraneous/mixed

[PATCHv2] Checkpatch fixes for staging/drivers/ks7010.

2017-02-22 Thread Matthew Giassa
Wrapping complex macros with parentheses. Adding extra spaces between macros and integer literals. Indentation changes to remove checkpatch warnings. Swapping out C++-style comments with C-style comments. Signed-off-by: Matthew Giassa <matt...@giassa.net> --- drivers/staging/

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Joe Perches <j...@perches.com> [2017-02-21 10:47:31 -0800]: On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: * Geert Uytterhoeven <ge...@linux-m68k.org> [2017-02-21 15:22:10 +0100]: > The first declaration fit nicely on a single line. > The second one indeed has a

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
n line. What would the proposed fix be? A combination of spaces and hard-tabs? I don't see checkpatch complaining about it, so that could work too. -- -Matthew Giassa e:<matt...@giassa.net>

Re: [PATCH] staging/ks7010: formatting updates.

2017-02-21 Thread Matthew Giassa
* Geert Uytterhoeven <ge...@linux-m68k.org> [2017-02-21 08:59:18 +0100]: Hi Geert, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa <matt...@giassa.net> wrote: Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---"

[PATCH] staging/ks7010: formatting updates.

2017-02-20 Thread Matthew Giassa
Please pardon the earlier e-mail which was missing the changelog text. Wrapping complex macros with parentheses to remove checkpatch errors. Some additional style changes to appease checkpatch. --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +- 1 file changed,