Re: [PATCH] pci: fix I/O space page leak

2018-06-21 Thread Thomas Petazzoni
gt; support") > Signed-off-by: Sergei Shtylyov > Cc: sta...@vger.kernel.org > > --- > The patch is against the 'master' branch of Bjorn Helgaas' 'pci.git' repo... > It has only been tested with the R-Car PCIe driver... > > drivers/pci/controller/dwc/pcie-designware-host.c |3 + > drivers/pci/controller/pci-aardvark.c |2 - For the Aardvark chunk: Reviewed-by: Thomas Petazzoni Thanks! Thomas Petazzoni -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] sh: mm: Fix unprotected access to struct device

2018-04-17 Thread Thomas Petazzoni
done two commits here, one to fix: dma_alloc_coherent(>dev, memsize, _handle, GFP_KERNEL); and one to switch to the WARN_ON + if(dev) model. But I don't really care either way, so: Reviewed-by: Thomas Petazzoni <thomas.petazz...@bootlin.com> Note that even with the if (dev) check, you

Re: [PATCH 1/2] net: sh_eth: add support for SH7786

2017-12-08 Thread Thomas Petazzoni
G_FAST_SH4 layout ? Note that my patch makes Ethernet work in practice on SH7784, I have root over NFS working as we speak. This certainly doesn't mean that the patch is entirely correct, but it definitely means that the SH_ETH_REG_FAST_SH4 is close enough to what the SH7786 is using :-) Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH v2] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-08 Thread Thomas Petazzoni
t a v3 that takes into account this comment. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[PATCH v3] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-08 Thread Thomas Petazzoni
the MAC doesn't support it. In order to avoid this, we use the recently introduced phy_set_max_speed() to tell the PHY to not advertise speed higher than 100 MBit/s. Tested on a SH7786 platform, with a Gigabit PHY. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Changes

Re: [PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-05 Thread Thomas Petazzoni
dev->dev); pm_runtime_put_sync(>pdev->dev); struct device *dev = >pdev->dev; Best regards, Thomas Petazzoni -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

[PATCH v2] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-05 Thread Thomas Petazzoni
the MAC doesn't support it. In order to avoid this, we use the recently introduced phy_set_max_speed() to tell the PHY to not advertise speed higher than 100 MBit/s. Tested on a SH7786 platform, with a Gigabit PHY. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Changes

Re: [PATCH 1/2] net: sh_eth: add support for SH7786

2017-12-04 Thread Thomas Petazzoni
Hello, On Mon, 4 Dec 2017 19:56:35 +0300, Sergei Shtylyov wrote: > On 12/04/2017 05:17 PM, Thomas Petazzoni wrote: > > > This commit adds the sh_eth_cpu_data structure that describes the > > SH7786 variant of the IP. > > The manual seems to be unavailable, so I hav

[PATCH 0/2] net: sh_eth: add support for SH7786 and big-endian

2017-12-04 Thread Thomas Petazzoni
, my change is based on the assumption that the DMA descriptors are in the native endianness of the CPU. Thanks, Thomas Thomas Petazzoni (2): net: sh_eth: add support for SH7786 net: sh_eth: make work on big endian systems drivers/net/ethernet/renesas/sh_eth.c | 89

[PATCH 1/2] net: sh_eth: add support for SH7786

2017-12-04 Thread Thomas Petazzoni
This commit adds the sh_eth_cpu_data structure that describes the SH7786 variant of the IP. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- drivers/net/ethernet/renesas/sh_eth.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drive

[PATCH 2/2] net: sh_eth: make work on big endian systems

2017-12-04 Thread Thomas Petazzoni
running big-endian. Therefore, all the endianness conversion needs to be removed for the sh_eth driver to work. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Note: I see that Sergei Shtylyov has done some work around endianness on this driver back in 2015. I am no

[PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

2017-12-04 Thread Thomas Petazzoni
ven though the MAC doesn't support it. In order to avoid this, we mark phydev->supported if we're running a non-Gigabit capable hardware. Tested on a SH7786 platform, with a Gigabit PHY. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- drivers/net/ethernet/renesas/

[PATCH 2/2] net: sh_eth: don't use NULL as "struct device" for the DMA mapping API

2017-12-04 Thread Thomas Petazzoni
Using NULL as argument for the DMA mapping API is bogus, as the DMA mapping API may use information from the "struct device" to perform the DMA mapping operation. Therefore, pass the appropriate "struct device". Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-elec

[PATCH 1/2] net: sh_eth: use correct "struct device" when calling DMA mapping functions

2017-12-04 Thread Thomas Petazzoni
uct device" representing the physical device on its bus. This commit fixes that by adjusting all calls to the DMA mapping API. Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- drivers/net/ethernet/renesas/sh_eth.c | 19 ++- 1 file changed, 1

[PATCH 0/2] net: sh_eth: DMA mapping API fixes

2017-12-04 Thread Thomas Petazzoni
Hello, Here are two patches that fix how the sh_eth driver is using the DMA mapping API: a bogus struct device is used in some places, or a NULL struct device is used. Best regards, Thomas Thomas Petazzoni (2): net: sh_eth: use correct "struct device" when calling DMA mapping

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2016-11-28 Thread Thomas Petazzoni
> Signed-off-by: Johan Hovold <jo...@kernel.org> > --- > drivers/net/ethernet/marvell/mvneta.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Emb