Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-14 Thread Daniel Lezcano
On 10/09/2018 22:22, Sergei Shtylyov wrote: > The driver seems to abuse *unsigned long* not only for the (32-bit) > register values but also for the 'sh_cmt_channel::total_cycles' which > needs to always be 64-bit -- as a result, the clocksource's mask is > needlessly clamped down to 32-bits on

Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-14 Thread Geert Uytterhoeven
On Mon, Sep 10, 2018 at 10:23 PM Sergei Shtylyov wrote: > The driver seems to abuse *unsigned long* not only for the (32-bit) > register values but also for the 'sh_cmt_channel::total_cycles' which > needs to always be 64-bit -- as a result, the clocksource's mask is > needlessly clamped down to

Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-13 Thread Sergei Shtylyov
Hello! On 09/13/2018 04:25 PM, Daniel Lezcano wrote: >> The driver seems to abuse *unsigned long* not only for the (32-bit) >> register values but also for the 'sh_cmt_channel::total_cycles' which >> needs to always be 64-bit -- as a result, the clocksource's mask is >> needlessly clamped down

Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-13 Thread Daniel Lezcano
On 10/09/2018 22:22, Sergei Shtylyov wrote: > The driver seems to abuse *unsigned long* not only for the (32-bit) > register values but also for the 'sh_cmt_channel::total_cycles' which > needs to always be 64-bit -- as a result, the clocksource's mask is > needlessly clamped down to 32-bits on

Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-12 Thread Simon Horman
On Mon, Sep 10, 2018 at 11:34:49PM +0300, Sergei Shtylyov wrote: > On 09/10/2018 11:22 PM, Sergei Shtylyov wrote: > > > The driver seems to abuse *unsigned long* not only for the (32-bit) > > register values but also for the 'sh_cmt_channel::total_cycles' which > > needs to always be 64-bit -- as

Re: [PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-10 Thread Sergei Shtylyov
On 09/10/2018 11:22 PM, Sergei Shtylyov wrote: > The driver seems to abuse *unsigned long* not only for the (32-bit) > register values but also for the 'sh_cmt_channel::total_cycles' which > needs to always be 64-bit -- as a result, the clocksource's mask is > needlessly clamped down to 32-bits

[PATCH] clocksource: sh_cmt: fix clocksource width for 32-bit machines

2018-09-10 Thread Sergei Shtylyov
The driver seems to abuse *unsigned long* not only for the (32-bit) register values but also for the 'sh_cmt_channel::total_cycles' which needs to always be 64-bit -- as a result, the clocksource's mask is needlessly clamped down to 32-bits on the 32-bit machines... Reported-by: Geert