Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-05-06 Thread Kieran Bingham
Hi Sakari, >> Did it get lost? >> It looks like the cleanup series it was based on made it through... > > What I think happened was that I had applied it to the correct branch BUT I > already had sent a pull request on it. My apologies. No worries - thanks for checking! > >> >> Mauro,

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-05-05 Thread Sakari Ailus
Hi Kieran / Mauro, On Fri, May 05, 2017 at 06:33:22PM +0100, Kieran Bingham wrote: > Hi Sakari, > > On 04/01/17 08:57, Sakari Ailus wrote: > > Hi Kieran, > > > > Thanks for the patch! > > > > On Tue, Jan 03, 2017 at 05:05:58PM +, Kieran Bingham wrote: > >> On 03/01/17 13:36, Laurent

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-05-05 Thread Kieran Bingham
Hi Sakari, On 04/01/17 08:57, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patch! > > On Tue, Jan 03, 2017 at 05:05:58PM +, Kieran Bingham wrote: >> On 03/01/17 13:36, Laurent Pinchart wrote: >>> Hi Kieran, >>> >>> Thank you for the patch. >>> >>> On Tuesday 03 Jan 2017 13:12:11

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-04 Thread Sakari Ailus
Hi Kieran, Thanks for the patch! On Tue, Jan 03, 2017 at 05:05:58PM +, Kieran Bingham wrote: > On 03/01/17 13:36, Laurent Pinchart wrote: > > Hi Kieran, > > > > Thank you for the patch. > > > > On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote: > >> Drivers must not perform unbalanced

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-03 Thread Kieran Bingham
On 03/01/17 13:36, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote: >> Drivers must not perform unbalanced calls to stop the entity pipeline, >> however if they do they will fault in the core media code, as the >>

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-03 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote: > Drivers must not perform unbalanced calls to stop the entity pipeline, > however if they do they will fault in the core media code, as the > entity->pipe will be set as NULL. We handle this gracefully in

[PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-03 Thread Kieran Bingham
Drivers must not perform unbalanced calls to stop the entity pipeline, however if they do they will fault in the core media code, as the entity->pipe will be set as NULL. We handle this gracefully in the core with a WARN for the developer. Replace the erroneous check on zero streaming counts,