Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Mon, Jun 12, 2017 at 1:32 PM, Niklas Söderlund wrote: > On 2017-05-18 10:52:25 +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund >> wrote: >> > On 2017-05-16 13:36:21 +0200, Geert

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Geert, On 2017-05-18 10:52:25 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund > wrote: > > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote: > >> On Tue, May 16, 2017 at 1:01 PM, Simon Horman

Re: [PATCH] ravb: add wake-on-lan support via magic packet

On Tue, May 16, 2017 at 02:16:04PM +0200, Niklas Söderlund wrote: > Hi, > > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Tue, May 16, 2017 at 1:01 PM, Simon Horman wrote: > > > On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Tue, May 16, 2017 at 2:16 PM, Niklas Söderlund wrote: > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 1:01 PM, Simon Horman wrote: >> > Is there some way for - e.g. the driver - to not enable

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Simon, On Tue, May 16, 2017 at 1:01 PM, Simon Horman wrote: > On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote: >> On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund >> wrote: >> >> > Whit all this being said I still like

Re: [PATCH] ravb: add wake-on-lan support via magic packet

On Tue, May 16, 2017 at 11:07:34AM +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund > wrote: > >> > Whit all this being said I still like to withdraw this patch as I found > >> > another fault with it,

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Tue, May 16, 2017 at 11:02 AM, Niklas Söderlund wrote: >> > Whit all this being said I still like to withdraw this patch as I found >> > another fault with it, ravb_wol_restore() will unconditionally be called >> > while ravb_wol_setup() will only be

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Geert, Thanks for your feedback. On 2017-05-16 09:48:51 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, May 12, 2017 at 11:12 PM, Niklas Söderlund > wrote: > > On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote: > >> On Fri, May 12, 2017 at 4:32

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Fri, May 12, 2017 at 11:12 PM, Niklas Söderlund wrote: > On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund >> wrote: >> > On 2017-05-12 14:58:53 +0200, Niklas

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Geert, On 2017-05-12 16:43:55 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund > wrote: > > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: > >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Fri, May 12, 2017 at 4:32 PM, Niklas Söderlund wrote: > On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: >> On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund >> >

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Geert, On 2017-05-12 14:58:53 +0200, Niklas Söderlund wrote: > Hi Geert, > > Thanks for testing. > > On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund > > wrote: > > > WoL

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Fri, May 12, 2017 at 2:58 PM, Niklas Söderlund wrote: > On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: >> On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund >> wrote: >> > WoL is enabled in the suspend

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Geert, Thanks for testing. On 2017-05-12 14:47:53 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund > wrote: > > WoL is enabled in the suspend callback by setting MagicPacket detection > > and

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hi Niklas, On Fri, May 12, 2017 at 12:27 AM, Niklas Söderlund wrote: > WoL is enabled in the suspend callback by setting MagicPacket detection > and disabling all interrupts expect MagicPacket. In the resume path the > driver needs to reset the hardware to

Re: [PATCH] ravb: add wake-on-lan support via magic packet

Hello! On 05/12/2017 01:27 AM, Niklas Söderlund wrote: WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the Except. driver needs to reset the hardware to rearm the WoL logic, this prevents the