Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size

2018-12-03 Thread Marek Vasut
On 12/03/2018 10:36 AM, Bartosz Golaszewski wrote: > niedz., 2 gru 2018 o 20:36 Marek Vasut napisał(a): >> >> The bank_size = fls(...) code was duplicated in the driver 5 times, >> pull it into separate function. >> > > Shouldn't it be bank_shift in the commit message? It should, fixed -- Best

Re: [PATCH 01/14] gpio: pca953x: Deduplicate the bank_size

2018-12-03 Thread Bartosz Golaszewski
niedz., 2 gru 2018 o 20:36 Marek Vasut napisał(a): > > The bank_size = fls(...) code was duplicated in the driver 5 times, > pull it into separate function. > Shouldn't it be bank_shift in the commit message? Bart > Signed-off-by: Marek Vasut > Cc: Linus Walleij > Cc: Bartosz Golaszewski > -

[PATCH 01/14] gpio: pca953x: Deduplicate the bank_size

2018-12-02 Thread Marek Vasut
The bank_size = fls(...) code was duplicated in the driver 5 times, pull it into separate function. Signed-off-by: Marek Vasut Cc: Linus Walleij Cc: Bartosz Golaszewski --- drivers/gpio/gpio-pca953x.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drive