Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-25 Thread Rafael J. Wysocki
On Saturday, December 23, 2017 4:17:58 PM CET Ulf Hansson wrote: > [...] > > How many drivers actually do call device_set_wakeup_enable() during > suspend? > >>> > >>> There are some ethernet/wifi drivers, although it hard to say how many > >>> without a more thorough investigation. >

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-23 Thread Ulf Hansson
[...] How many drivers actually do call device_set_wakeup_enable() during suspend? >>> >>> There are some ethernet/wifi drivers, although it hard to say how many >>> without a more thorough investigation. >>> >>> Besides those I found these more obvious ones: >>>

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-23 Thread Rafael J. Wysocki
On Sat, Dec 23, 2017 at 1:50 PM, Rafael J. Wysocki wrote: > On Sat, Dec 23, 2017 at 1:03 PM, Ulf Hansson wrote: >> On 22 December 2017 at 20:12, Rafael J. Wysocki wrote: >>> On Thursday, December 21, 2017 11:13:57 AM CET Ulf Hansson

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-23 Thread Rafael J. Wysocki
On Sat, Dec 23, 2017 at 1:03 PM, Ulf Hansson wrote: > On 22 December 2017 at 20:12, Rafael J. Wysocki wrote: >> On Thursday, December 21, 2017 11:13:57 AM CET Ulf Hansson wrote: >>> On 21 December 2017 at 02:43, Rafael J. Wysocki

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-23 Thread Ulf Hansson
On 22 December 2017 at 20:12, Rafael J. Wysocki wrote: > On Thursday, December 21, 2017 11:13:57 AM CET Ulf Hansson wrote: >> On 21 December 2017 at 02:43, Rafael J. Wysocki wrote: >> > On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-22 Thread Rafael J. Wysocki
On Thursday, December 21, 2017 11:13:57 AM CET Ulf Hansson wrote: > On 21 December 2017 at 02:43, Rafael J. Wysocki wrote: > > On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson wrote: > >> The PM core in the device_prepare() phase, resets the wakeup_path

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-21 Thread Ulf Hansson
On 21 December 2017 at 02:43, Rafael J. Wysocki wrote: > On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson wrote: >> The PM core in the device_prepare() phase, resets the wakeup_path status >> flag to the value of device_may_wakeup(). This means if a

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-20 Thread Rafael J. Wysocki
On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson wrote: > The PM core in the device_prepare() phase, resets the wakeup_path status > flag to the value of device_may_wakeup(). This means if a ->prepare() or a > ->suspend() callback for the device would update the device's

[PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

2017-12-15 Thread Ulf Hansson
The PM core in the device_prepare() phase, resets the wakeup_path status flag to the value of device_may_wakeup(). This means if a ->prepare() or a ->suspend() callback for the device would update the device's wakeup setting, this doesn't become reflected in the wakeup_path status flag. In