RE: [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-12 Thread Chris Brandt
Hi Jacopo, On Thursday, January 12, 2017, jacopo mondi wrote: > Oh! That's weird I don't have that statement in my manual (public version > R01UH0403EJ0060 Rev.0.60) If you go to www.renesas.com and search for "RZ/A1H User Manual", you will see that a new version 3.0 manual was recently posted. T

Re: [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-12 Thread jacopo mondi
Hi Chris, On 12/01/2017 15:39, Chris Brandt wrote: Hi Jacopo, On Thursday, January 12, 2017, jacopo mondi wrote: To read the pin direction I would need to add one more register to the "reg" property range provided in the DTS. This is of course doable, but I would have two questions here: - why

RE: [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-12 Thread Chris Brandt
Hi Jacopo, On Thursday, January 12, 2017, jacopo mondi wrote: > To read the pin direction I would need to add one more register to the > "reg" property range provided in the DTS. > This is of course doable, but I would have two questions here: > - why did you chose to use PMSR register instead of

Re: [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-12 Thread jacopo mondi
Hi Linus, thanks for review On 11/01/2017 15:55, Linus Walleij wrote: On Mon, Jan 9, 2017 at 8:31 PM, Jacopo Mondi wrote: +static void rz_gpio_free(struct gpio_chip *chip, unsigned offset) +{ + pinctrl_free_gpio(chip->base + offset); + + /* Set the GPIO as an input to ensur

Re: [PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-11 Thread Linus Walleij
On Mon, Jan 9, 2017 at 8:31 PM, Jacopo Mondi wrote: > From: Magnus Damm > > This commit combines Magnus' original driver and minor fixes to > forward-port it to a more recent kernel version (v4.10) > > Signed-off-by: Jacopo Mondi > > -

[PATCH 2/3] gpio: gpio-rz: GPIO driver for Renesas RZ series

2017-01-09 Thread Jacopo Mondi
From: Magnus Damm This commit combines Magnus' original driver and minor fixes to forward-port it to a more recent kernel version (v4.10) Signed-off-by: Jacopo Mondi --- gpio: Renesas RZ GPIO driver V3 This patch adds a GPIO driver f