Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-11 Thread Sergei Shtylyov
On 09/11/2016 04:06 PM, Julia Lawall wrote: For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. Really? 2. Address never taken Really? 3. Not passed to a top-level

[PATCH 23/26] sh_eth: constify local structures

2016-09-11 Thread Julia Lawall
For structure types defined in the same file or local header files, find top-level static structure declarations that have the following properties: 1. Never reassigned. 2. Address never taken 3. Not passed to a top-level macro call 4. No pointer or array-typed field passed to a function or stored