Re: [PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-10 Thread Simon Horman
On Fri, Sep 09, 2016 at 06:57:54PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Sep 9, 2016 at 5:26 PM, Simon Horman wrote: > >> > + /* GP6_16-23 -> bits 31-24 of pocctrl > >> > +* GP6_06-> bit 23of pocctrl > >> > +* GP6_00-05 ->

Re: [PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-09 Thread Geert Uytterhoeven
Hi Simon, On Fri, Sep 9, 2016 at 5:26 PM, Simon Horman wrote: >> > + /* GP6_16-23 -> bits 31-24 of pocctrl >> > +* GP6_06-> bit 23of pocctrl >> > +* GP6_00-05 -> bits 22-17 of pocctrl >> > +* GP6_07-> bit 16of pocctrl >> > +

Re: [PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-09 Thread Simon Horman
On Fri, Sep 09, 2016 at 10:08:03AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Sep 8, 2016 at 1:36 PM, Simon Horman > wrote: > > All the SHDIs can operate with either 3.3V or 1.8V signals, depending > > on negotiation with the card. > > > > Based on work

Re: [PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-09 Thread Wolfram Sang
> > +static int r8a7794_pin_to_pocctrl(struct sh_pfc *pfc, unsigned int pin, > > u32 *pocctrl) > > +{ > > + if (pin < RCAR_GP_PIN(6, 0) || pin > RCAR_GP_PIN(6, 23)) > > + return -EINVAL; > > + > > + *pocctrl = 0xe606006c; > > + > > + /* GP6_16-23 -> bits 31-24 of

Re: [PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-09 Thread Geert Uytterhoeven
Hi Simon, On Thu, Sep 8, 2016 at 1:36 PM, Simon Horman wrote: > All the SHDIs can operate with either 3.3V or 1.8V signals, depending > on negotiation with the card. > > Based on work by Wolfram Sang for the r8a7790. > > Cc: Wolfram Sang

[PATCH 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-08 Thread Simon Horman
All the SHDIs can operate with either 3.3V or 1.8V signals, depending on negotiation with the card. Based on work by Wolfram Sang for the r8a7790. Cc: Wolfram Sang Signed-off-by: Simon Horman ---