Re: [PATCH 4/4] serial: sh-sci: Stop RX FIFO timer during port shutdown

2018-08-03 Thread Geert Uytterhoeven
On Mon, Jul 2, 2018 at 9:01 PM Rob Landley wrote: > On 07/02/2018 04:50 AM, Geert Uytterhoeven wrote: > > On Sun, Jul 1, 2018 at 7:27 PM Rob Landley wrote: > >> On 06/29/2018 09:25 AM, Geert Uytterhoeven wrote: > >>> The RX FIFO timer may be armed when the port is shut down, hence the > >>>

Re: [PATCH 4/4] serial: sh-sci: Stop RX FIFO timer during port shutdown

2018-07-02 Thread Rob Landley
On 07/02/2018 04:50 AM, Geert Uytterhoeven wrote: > Hi Rob, > > On Sun, Jul 1, 2018 at 7:27 PM Rob Landley wrote: >> On 06/29/2018 09:25 AM, Geert Uytterhoeven wrote: >>> The RX FIFO timer may be armed when the port is shut down, hence the >>> timer function may still be called afterwards. >>>

Re: [PATCH 4/4] serial: sh-sci: Stop RX FIFO timer during port shutdown

2018-07-02 Thread Geert Uytterhoeven
Hi Rob, On Sun, Jul 1, 2018 at 7:27 PM Rob Landley wrote: > On 06/29/2018 09:25 AM, Geert Uytterhoeven wrote: > > The RX FIFO timer may be armed when the port is shut down, hence the > > timer function may still be called afterwards. > > > > Fix this race condition by deleting the timer during

Re: [PATCH 4/4] serial: sh-sci: Stop RX FIFO timer during port shutdown

2018-07-01 Thread Rob Landley
On 06/29/2018 09:25 AM, Geert Uytterhoeven wrote: > The RX FIFO timer may be armed when the port is shut down, hence the > timer function may still be called afterwards. > > Fix this race condition by deleting the timer during port shutdown. Will any of this make the qemu-system-sh4 serial

[PATCH 4/4] serial: sh-sci: Stop RX FIFO timer during port shutdown

2018-06-29 Thread Geert Uytterhoeven
The RX FIFO timer may be armed when the port is shut down, hence the timer function may still be called afterwards. Fix this race condition by deleting the timer during port shutdown. Fixes: 039403765e5da3c6 ("serial: sh-sci: SCIFA/B RX FIFO software timeout") Signed-off-by: Geert Uytterhoeven