Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hi Andrew, Niklas, On Sun, Jul 30, 2017 at 9:51 PM, Niklas Söderlund wrote: > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: >> > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) >> > >> > priv->chip_id = chip_id; >> > >> > + /*

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hi Sergei, Thanks for your feedback! On 2017-07-31 22:47:12 +0300, Sergei Shtylyov wrote: > Hello! > > On 07/30/2017 05:06 PM, Niklas Söderlund wrote: > > > WoL is enabled in the suspend callback by setting MagicPacket detection > > and disabling all interrupts expect MagicPacket. In the

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hello! On 07/30/2017 05:06 PM, Niklas Söderlund wrote: WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hi Andrew, On 2017-07-30 22:07:31 +0200, Andrew Lunn wrote: > On Sun, Jul 30, 2017 at 09:51:54PM +0200, Niklas Söderlund wrote: > > Hi Andrew, > > > > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > > > Hi Niklas > > > > > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

On Sun, Jul 30, 2017 at 09:51:54PM +0200, Niklas Söderlund wrote: > Hi Andrew, > > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > > Hi Niklas > > > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > > > > > priv->chip_id = chip_id; > > > > > > + /* Get

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hi Andrew, On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > Hi Niklas > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > > > priv->chip_id = chip_id; > > > > + /* Get clock, if not found that's OK but Wake-On-Lan is unavailable */ > > + priv->clk =

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hi Niklas > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > priv->chip_id = chip_id; > > + /* Get clock, if not found that's OK but Wake-On-Lan is unavailable */ > + priv->clk = devm_clk_get(>dev, NULL); > + if (IS_ERR(priv->clk)) > +