RE: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Yoshihiro Shimoda
Hi, > From: Mathias Nyman > Sent: Wednesday, June 01, 2016 8:42 PM > > >>> isn't the following enough? > >>> > >>> @@ -4886,7 +4886,7 @@ int xhci_gen_setup(struct usb_hcd *hcd, > >>> xhci_get_quirks_t get_quirks) > >>> xhci->hcc_params2 = readl(>cap_regs->hcc_params2); > >>>

Re: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Mathias Nyman
isn't the following enough? @@ -4886,7 +4886,7 @@ int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks) xhci->hcc_params2 = readl(>cap_regs->hcc_params2); xhci_print_registers(xhci); - xhci->quirks = quirks; + xhci->quirks |= quirks;

RE: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> From: Felipe Balbi >> Sent: Wednesday, June 01, 2016 4:01 PM >> >> Yoshihiro Shimoda writes: >> >> > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. >> > This regression is

RE: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Yoshihiro Shimoda
Hi Felipe, > From: Felipe Balbi > Sent: Wednesday, June 01, 2016 4:01 PM > > Yoshihiro Shimoda writes: > > > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. > > This regression is caused by the following commit: > > > > commit

Re: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Felipe Balbi
Yoshihiro Shimoda writes: > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. > This regression is caused by the following commit: > > commit b1c127ae990bccf0187d741c1695a61e54de1943 > Author: Felipe Balbi > Date: Fri

[PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-06-01 Thread Yoshihiro Shimoda
I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. This regression is caused by the following commit: commit b1c127ae990bccf0187d741c1695a61e54de1943 Author: Felipe Balbi Date: Fri Apr 22 13:17:16 2016 +0300 usb: host: xhci: plat: make use of new