Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-23 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Aug 17, 2016 at 9:08 PM, Wolfram Sang wrote: >> [] (__mmc_start_request) from [] >> (mmc_start_request+0x104/0x118) > > This function calls card_busy only for SDIO cards. I assume you don't > have one inserted? Maybe the "broken-cd" property doesn't

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-18 Thread Wolfram Sang
> I'll try to remove it. Note that sh73a0-kzm9g.dts also uses broken-cd, > without ill effects. This one does have a seperate card-detect-irq (which is not populated for sdhi2) while the other one only has one, generic irq. That's at least a difference. We could try to see if there are

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-17 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Aug 17, 2016 at 9:08 PM, Wolfram Sang wrote: >> [] (__mmc_start_request) from [] >> (mmc_start_request+0x104/0x118) > > This function calls card_busy only for SDIO cards. I assume you don't > have one inserted? Maybe the "broken-cd" property doesn't

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-17 Thread Wolfram Sang
> [] (__mmc_start_request) from [] > (mmc_start_request+0x104/0x118) This function calls card_busy only for SDIO cards. I assume you don't have one inserted? Maybe the "broken-cd" property doesn't work correctly and causes side-effects? This would explain why it only affects SDHI1 and not

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-16 Thread Geert Uytterhoeven
Hi Wolfram, On Tue, Aug 16, 2016 at 9:55 PM, Wolfram Sang wrote: >> The first SDHI channel (ee10.sd) doesn't seem to be affected >> by the problem. > > Hmm, I sadly don't have any docs about 73a4 and/or its SDHI variants. > I'll ask around. Forgot to add: I don't see the

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-16 Thread Wolfram Sang
> The first SDHI channel (ee10.sd) doesn't seem to be affected > by the problem. Hmm, I sadly don't have any docs about 73a4 and/or its SDHI variants. I'll ask around. signature.asc Description: PGP signature

Re: [PATCH v2 3/9] mmc: tmio: Add UHS-I mode support

2016-08-16 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Apr 1, 2016 at 5:44 PM, Wolfram Sang wrote: > From: Wolfram Sang > > Based on work by Shinobu Uehara and Ben Dooks. This adds the voltage > switch operation needed for all UHS-I modes, but not the tuning needed > for