Re: [PATCH v3 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-08-29 Thread Wolfram Sang
Hi Niklas, > I tested it on M3-W ES1.0 and it H3 ES2.0 and it works as I expect it to > do, but forcing a retune due to SCC error is beyond my skill-set. I > checked the documentation and can't find anything contradicting > Shimoda-sans information from the HW team. So to the best of my >

Re: [PATCH v3 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-08-29 Thread Niklas Söderlund
Hi Wolfram, Thanks for your feedback, On 2018-08-29 09:16:04 +0200, Wolfram Sang wrote: > > > + /* > > +* Skip checking SCC errors when running on 4 taps in HS400 mode as > > +* any retuning would still result in the same 4 taps being used. > > +*/ > > Did you verify this? I

Re: [PATCH v3 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-08-29 Thread Wolfram Sang
> + /* > + * Skip checking SCC errors when running on 4 taps in HS400 mode as > + * any retuning would still result in the same 4 taps being used. > + */ Did you verify this? I didn't have the time to do so :( signature.asc Description: PGP signature

Re: [PATCH v3 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-08-28 Thread Ulf Hansson
On 27 August 2018 at 17:13, Niklas Söderlund wrote: > From: Masaharu Hayakawa > > Checking for SCC error during retuning is unnecessary. > > Signed-off-by: Masaharu Hayakawa > [Niklas: fix small style issue] > Signed-off-by: Niklas Söderlund > > --- > > * Changes since v2 > - Add comment to

[PATCH v3 1/2] mmc: renesas_sdhi: skip SCC error check when retuning

2018-08-27 Thread Niklas Söderlund
From: Masaharu Hayakawa Checking for SCC error during retuning is unnecessary. Signed-off-by: Masaharu Hayakawa [Niklas: fix small style issue] Signed-off-by: Niklas Söderlund --- * Changes since v2 - Add comment to describe why checking SCC errors when using 4 taps is not needed. *