RE: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Chris Brandt
Hello Uffe, On Friday, January 20, 2017, Ulf Hansson wrote: > > The reality is that the chip guys cut up the standard SDHI IP to add a > > 'cool new feature', but all I want to do is put it back the way it was. > > > > NOTE: The design guys like to reuse IP blocks from previous designs > > that

Re: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Ulf Hansson
On 20 January 2017 at 17:05, Chris Brandt wrote: > Hello Ulf, > > Friday, January 20, 2017, Ulf Hansson wrote: >> > +- clocks: Most controllers only have 1 clock source per channel. >> However, some >> > + have a second clock dedicated to card detection. If 2

RE: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Chris Brandt
Hello Ulf, Friday, January 20, 2017, Ulf Hansson wrote: > > +- clocks: Most controllers only have 1 clock source per channel. > However, some > > + have a second clock dedicated to card detection. If 2 clocks > are > > + specified, you must name them as "core" and "cd". If the >

Re: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Ulf Hansson
On 18 January 2017 at 18:25, Chris Brandt wrote: > In the case of a single clock source, you don't need names. However, > if the controller has 2 clock sources, you need to name them correctly > so the driver can find the 2nd one. > > Signed-off-by: Chris Brandt

Re: [PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-19 Thread Wolfram Sang
On Wed, Jan 18, 2017 at 12:25:01PM -0500, Chris Brandt wrote: > In the case of a single clock source, you don't need names. However, > if the controller has 2 clock sources, you need to name them correctly > so the driver can find the 2nd one. > > Signed-off-by: Chris Brandt

[PATCH v3 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-18 Thread Chris Brandt
In the case of a single clock source, you don't need names. However, if the controller has 2 clock sources, you need to name them correctly so the driver can find the 2nd one. Signed-off-by: Chris Brandt --- v2: * fix spelling and change wording * changed clock name