Re: [PATCH v4 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Wolfram Sang
> It sounds like your suggestion is to just put the HW description in > the DT bindings, but move the dirty details into the driver. > > Keep in DT: > > +- clocks: Most controllers only have 1 clock source per channel. However, on > + some variations of this controller, the internal card

[PATCH v4 2/3] mmc: sh_mobile_sdhi: explain clock bindings

2017-01-20 Thread Chris Brandt
In the case of a single clock source, you don't need names. However, if the controller has 2 clock sources, you need to name them correctly so the driver can find the 2nd one. The 2nd clock is for the internal card detect logic and must be enabled/disabled along with the main core clock.