On Fri, Apr 28, 2017 at 11:16 AM, Linus Walleij
wrote:
> On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi
> wrote:
> But why.
>
> I have these two static inlines just below your new macros:
+1.
> We generally prefer static inlines over macros
Hi Linus,
On Fri, Apr 28, 2017 at 10:16:22AM +0200, Linus Walleij wrote:
> On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi
> wrote:
>
> > Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to
> > unpack generic properties and their arguments
> >
> >
On Fri, Apr 28, 2017 at 10:16 AM, Linus Walleij
wrote:
> On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi
>> +#define PIN_CONF_UNPACK_PARAM(c) ((c) & 0xffUL)
>> +#define PIN_CONF_UNPACK_ARGS(c) ((c) >> 8)
>
> But why.
>
> I have these two static inlines just below your new
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi
wrote:
> Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to
> unpack generic properties and their arguments
>
> Signed-off-by: Jacopo Mondi
(...)
/*
* Helpful configuration
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi
wrote:
> Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to
> unpack generic properties and their arguments
>
> Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Add PIN_CONF_UNPACK_PARAM and PIN_CONF_UNPACK_ARGS macros useful to
unpack generic properties and their arguments
Signed-off-by: Jacopo Mondi
---
include/linux/pinctrl/pinconf-generic.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git