Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-05-11 Thread Linus Walleij
On Fri, May 5, 2017 at 2:45 PM, Chris Brandt wrote: > On Friday, May 05, 2017, Linus Walleij wrote: >> > This is the part of the whole "DT is for hardware description only" that >> doesn't really make sense to me. >> >> OK yeah we do hardware description AND

RE: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-05-05 Thread Chris Brandt
On Friday, May 05, 2017, Linus Walleij wrote: > > This is the part of the whole "DT is for hardware description only" that > doesn't really make sense to me. > > OK yeah we do hardware description AND configuration. > > And we never do interpreted languages. > > And then there is a bunch of

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-05-05 Thread Geert Uytterhoeven
Hi Linus, On Fri, May 5, 2017 at 2:06 PM, Linus Walleij wrote: > On Fri, Apr 28, 2017 at 4:48 PM, Chris Brandt > wrote: > > I think this was written by me, not Geert... > >>> DT describes hardware, not software limitations. Na, I did write

RE: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-28 Thread Chris Brandt
Hi Geert, On Friday, April 28, 2017, Geert Uytterhoeven wrote: > >> Shouldn't the interrupt (connected to P1_15) be described? > > > > That interrupt pin from the PHY is not used. It did not need to be > connected. > > But it is connected, according to the schematics. P1_15 can be configured

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-28 Thread Linus Walleij
On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi (...) > + pins_bidir { > + pinmux =

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-28 Thread Geert Uytterhoeven
Hi Chris, On Thu, Apr 27, 2017 at 12:48 PM, Chris Brandt wrote: > On Thursday, April 27, 2017, Geert Uytterhoeven wrote: >> > + { >> > + pinctrl-names = "default"; >> > + pinctrl-0 = <_pins>; >> > + >> > + status = "okay"; >> > + >> > +

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Simon Horman
On Thu, Apr 27, 2017 at 10:48:45AM +, Chris Brandt wrote: > Hi Geert, > > On Thursday, April 27, 2017, Geert Uytterhoeven wrote: > > > + { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <_pins>; > > > + > > > + status = "okay"; > > > + > > > +

RE: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Chris Brandt
Hi Geert, On Thursday, April 27, 2017, Geert Uytterhoeven wrote: > > + { > > + pinctrl-names = "default"; > > + pinctrl-0 = <_pins>; > > + > > + status = "okay"; > > + > > + renesas,no-ether-link; > > + phy-handle = <>; > > + phy0: ethernet-phy@0 { > > +

Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Geert Uytterhoeven
Hi Jacopo, On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven > ---

[PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group

2017-04-27 Thread Jacopo Mondi
Add pin configuration subnode for ETHER ethernet controller. Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r7s72100-genmai.dts | 41 +++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts