RE: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-16 Thread Chris Brandt
Hi Geert, On Friday, November 16, 2018, Geert Uytterhoeven wrote: > > We can have Geert give his opinion on the topic since it was his > > suggestion to begin with. > > > > > > > I'm sorry this is more work, and again, it might be post-poned imo, > > > provided you drop this change you have

Re: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-16 Thread Geert Uytterhoeven
Hi Chris, On Thu, Nov 15, 2018 at 5:50 PM Chris Brandt wrote: > On Thursday, November 15, 2018 1, jacopo mondi wrote: > > > v5: > > > * Specify number of ports using of_device_id.data and save as priv- > > >npins > > > * Use priv->npins everywhere instead of hard coded RZA2_NPINS > > > *

RE: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-15 Thread Chris Brandt
Hi Jacopo, On Thursday, November 15, 2018 1, jacopo mondi wrote: > > v5: > > * Specify number of ports using of_device_id.data and save as priv- > >npins > > * Use priv->npins everywhere instead of hard coded RZA2_NPINS > > * Check gpio-ranges to make sure args matches SOC > > Sorry about

Re: [PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-15 Thread jacopo mondi
Hi Chris, On Thu, Nov 15, 2018 at 09:00:44AM -0500, Chris Brandt wrote: > Adds support for the pin and gpio controller found in R7S9210 (RZ/A2) SoCs. > > Signed-off-by: Chris Brandt > Reviewed-by: Jacopo Mondi > --- > v5: > * Specify number of ports using of_device_id.data and save as

[PATCH v6 1/2] pinctrl: Add RZ/A2 pin and gpio controller

2018-11-15 Thread Chris Brandt
Adds support for the pin and gpio controller found in R7S9210 (RZ/A2) SoCs. Signed-off-by: Chris Brandt Reviewed-by: Jacopo Mondi --- v5: * Specify number of ports using of_device_id.data and save as priv->npins * Use priv->npins everywhere instead of hard coded RZA2_NPINS * Check