RE: [PATCH v6 1/3] watchdog: renesas_wdt: Add suspend/resume support

2018-03-01 Thread Fabrizio Castro
Hi Wolfram, thank you for your feedback! > Subject: Re: [PATCH v6 1/3] watchdog: renesas_wdt: Add suspend/resume support > > > > +unsigned int timeleft; > > What about using > u16 time_left; > > ... > > > +static void rwdt_set_timeleft(struct rwdt

Re: [PATCH v6 1/3] watchdog: renesas_wdt: Add suspend/resume support

2018-03-01 Thread Wolfram Sang
> + unsigned int timeleft; What about using u16 time_left; ... > +static void rwdt_set_timeleft(struct rwdt_priv *priv, unsigned int timeleft) > +{ > + rwdt_write(priv, 65536 - MUL_BY_CLKS_PER_SEC(priv, timeleft), RWTCNT); > +} > + ... skipping this ... > static int

[PATCH v6 1/3] watchdog: renesas_wdt: Add suspend/resume support

2018-03-01 Thread Fabrizio Castro
On R-Car Gen2 and RZ/G1 the watchdog IP clock needs to be always ON, on R-Car Gen3 we power the IP down during suspend. This commit adds suspend/resume support, so that the watchdog counting "pauses" during suspend on all of the SoCs compatible with this driver and on those we are now adding