Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-08 Thread Laurent Pinchart
Hi Niklas, On Friday, 8 December 2017 15:09:21 EET Niklas Söderlund wrote: > On 2017-12-08 09:54:31 +0200, Laurent Pinchart wrote: > > On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: > >> If the video device was registered by the complete() callback it should > >> be unregistered

Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your comments. On 2017-12-08 09:54:31 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: > > If the video device was registered by the complete() callback it should > > be

Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-08 Thread Laurent Pinchart
Hi Hans, On Friday, 8 December 2017 10:46:34 EET Hans Verkuil wrote: > On 12/08/2017 08:54 AM, Laurent Pinchart wrote: > > On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: > >> If the video device was registered by the complete() callback it should > >> be unregistered when the

Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-08 Thread Hans Verkuil
On 12/08/2017 08:54 AM, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: >> If the video device was registered by the complete() callback it should >> be unregistered when the driver is removed. > > The

Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-07 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: > If the video device was registered by the complete() callback it should > be unregistered when the driver is removed. The .remove() operation indicates device removal, not driver removal (or,

[PATCH v9 03/28] rcar-vin: unregister video device on driver removal

2017-12-07 Thread Niklas Söderlund
If the video device was registered by the complete() callback it should be unregistered when the driver is removed. Protect from printing an uninitialized video device node name by adding a check in rvin_v4l2_unregister() to identify that the video device is registered. Signed-off-by: Niklas