Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2018-03-02 Thread Laurent Pinchart
Hi Niklas, On Friday, 19 January 2018 02:46:03 EET Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your comments. > > Apart from the issue with the input API Hans pointed which indicates I > need to keep that around until it's fixed in the framework I agree with > all your comments but

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2018-01-18 Thread Niklas Söderlund
Hi Laurent, Thanks for your comments. Apart from the issue with the input API Hans pointed which indicates I need to keep that around until it's fixed in the framework I agree with all your comments but one. On 2017-12-08 12:14:05 +0200, Laurent Pinchart wrote: > > @@ -628,7 +628,8 @@

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2017-12-08 Thread Laurent Pinchart
Hi Hans, On Friday, 8 December 2017 12:24:26 EET Hans Verkuil wrote: > Hi Laurent, > > >> +static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = { > >> + .vidioc_querycap= rvin_querycap, > >> + .vidioc_try_fmt_vid_cap = rvin_mc_try_fmt_vid_cap, > >> +

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2017-12-08 Thread Hans Verkuil
Hi Laurent, >> +static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = { >> +.vidioc_querycap= rvin_querycap, >> +.vidioc_try_fmt_vid_cap = rvin_mc_try_fmt_vid_cap, >> +.vidioc_g_fmt_vid_cap = rvin_g_fmt_vid_cap, >> +.vidioc_s_fmt_vid_cap

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2017-12-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 8 December 2017 03:08:33 EET Niklas Söderlund wrote: > When the driver runs in media controller mode it should not directly > control the subdevice instead userspace will be responsible for > configuring the pipeline. To be able to run in this mode

[PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2017-12-07 Thread Niklas Söderlund
When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the