Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hi Kieran, On Wednesday 14 Dec 2016 19:56:51 Kieran Bingham wrote: > Hello Me. > > Ok, so a bit of investigation into *why* we have an unbalanced > media_pipeline stop call. > > After a suspend/resume cycle, the function vsp1_pm_runtime_resume() is > called by the PM framework. > > The

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hello Me. Ok, so a bit of investigation into *why* we have an unbalanced media_pipeline stop call. After a suspend/resume cycle, the function vsp1_pm_runtime_resume() is called by the PM framework. The hardware is unable to reset successfully and the reset call returns -ETIMEDOUT which gets

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hi Sakari, On 14/12/16 12:43, Sakari Ailus wrote: > Hi Kieran, > > On Wed, Dec 14, 2016 at 12:27:37PM +, Kieran Bingham wrote: >> Hi Sakari, >> >> On 14/12/16 07:28, Sakari Ailus wrote: >>> Hi Kieran, >>> >>> On Tue, Dec 13, 2016 at 05:59:44PM +, Kieran Bingham wrote:

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hi Kieran, On Wed, Dec 14, 2016 at 12:27:37PM +, Kieran Bingham wrote: > Hi Sakari, > > On 14/12/16 07:28, Sakari Ailus wrote: > > Hi Kieran, > > > > On Tue, Dec 13, 2016 at 05:59:44PM +, Kieran Bingham wrote: > >> media_entity_pipeline_stop() can be called through error paths with a >

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hi Sakari, On 14/12/16 07:28, Sakari Ailus wrote: > Hi Kieran, > > On Tue, Dec 13, 2016 at 05:59:44PM +, Kieran Bingham wrote: >> media_entity_pipeline_stop() can be called through error paths with a >> NULL entity pipe object. In this instance, stopping is a no-op, so >> simply return

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

Hi Kieran, On Tue, Dec 13, 2016 at 05:59:44PM +, Kieran Bingham wrote: > media_entity_pipeline_stop() can be called through error paths with a > NULL entity pipe object. In this instance, stopping is a no-op, so > simply return without any action The approach of returning silently is wrong;

[PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

media_entity_pipeline_stop() can be called through error paths with a NULL entity pipe object. In this instance, stopping is a no-op, so simply return without any action Signed-off-by: Kieran Bingham --- I've marked this patch as RFC, although if deemed