> > On 06/03/2016 07:03 PM, Ulrich Hecht wrote:
> >
> >> Thanks; I missed that every register is described twice.
> >>
> >> Nevertheless, names often vary more or less subtly between your patch
> >> and the specs, making it very hard to review. Some have letters
> >> added, some have letters remove
From: Oliver Hartkopp
Date: Fri, 3 Jun 2016 19:15:29 +0200
> On 06/03/2016 07:03 PM, Ulrich Hecht wrote:
>
>> Thanks; I missed that every register is described twice.
>>
>> Nevertheless, names often vary more or less subtly between your patch
>> and the specs, making it very hard to review. Some
On 06/03/2016 07:03 PM, Ulrich Hecht wrote:
Thanks; I missed that every register is described twice.
Nevertheless, names often vary more or less subtly between your patch
and the specs, making it very hard to review. Some have letters added,
some have letters removed, and some are just plain co
On Fri, Jun 3, 2016 at 8:42 AM, Ramesh Shanmugasundaram
wrote:
> Hi Uli,
>
> Thanks for the review
>
>> Thank you for your patch.
>>
>> On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram
>> wrote:
>> [...]
>> > diff --git a/drivers/net/can/rcar/rcar_canfd.c
>> > b/drivers/net/can/rcar/rcar_
Hi Uli,
Thanks for the review
> Thank you for your patch.
>
> On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram
> wrote:
> [...]
> > diff --git a/drivers/net/can/rcar/rcar_canfd.c
> > b/drivers/net/can/rcar/rcar_canfd.c
> > new file mode 100644
> > index 000..e198732
> > --- /dev/nul
Thank you for your patch.
On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram
wrote:
[...]
> diff --git a/drivers/net/can/rcar/rcar_canfd.c
> b/drivers/net/can/rcar/rcar_canfd.c
> new file mode 100644
> index 000..e198732
> --- /dev/null
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -0
