Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Chris, On Thursday 04 May 2017 12:23:32 Chris Brandt wrote: > On Wednesday, May 03, 2017, jmondi wrote: > > I have a proposal here, as the original driver only supported "image > > fetch mode" (ie. It accepts data in YUYV with components ordering > > arbitrary swapped) as a first step we may

RE: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, On Wednesday, May 03, 2017, jmondi wrote: > I have a proposal here, as the original driver only supported "image fetch > mode" (ie. It accepts data in YUYV with components ordering arbitrary > swapped) as a first step we may want to replicate this, ignoring data > synch fetch mode

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, On Wednesday 03 May 2017 18:14:03 jmondi wrote: > On Wed, May 03, 2017 at 06:06:19PM +0300, Laurent Pinchart wrote: > > On Wednesday 03 May 2017 11:52:36 jmondi wrote: > >> On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > >>> Hi Jacopo, > >>> > >>> Thank you for the

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Laurent, On Wed, May 03, 2017 at 06:06:19PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Wednesday 03 May 2017 11:52:36 jmondi wrote: > > On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > > > Hi Jacopo, > > > > > > Thank you for the patch. > > > > [snip] > > > > >> +/**

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, On Wednesday 03 May 2017 11:52:36 jmondi wrote: > On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > [snip] > > >> +/** > >> + * Collect formats supported by CEU and sensor subdevice > >> + */ > >> +static int

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Laurent, On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. [snip] > > +/** > > + * Collect formats supported by CEU and sensor subdevice > > + */ > > +static int sh_ceu_init_active_formats(struct sh_ceu_dev *pcdev) > > +{ > > +

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, On Tuesday 02 May 2017 11:48:42 jmondi wrote: > On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > [snip] > > > > + pcdev = devm_kzalloc(>dev, sizeof(*pcdev), GFP_KERNEL); > > > > devm_kzalloc() is harmful here. You're embedding a struct

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, On Monday 01 May 2017 16:37:54 jmondi wrote: > On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > This is a partial review, as some of the comments will result in large > > changes that would make review of some

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Laurent, On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > [snip] > > + pcdev = devm_kzalloc(>dev, sizeof(*pcdev), GFP_KERNEL); > > devm_kzalloc() is harmful here. You're embedding a struct video_device instead > struct sh_ceu_dev, and the video device can

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Laurent, thanks for the extensive review On Thu, Apr 27, 2017 at 02:47:14PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > This is a partial review, as some of the comments will result in large changes > that would make review of some of the current code

Re: [RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Hi Jacopo, Thank you for the patch. This is a partial review, as some of the comments will result in large changes that would make review of some of the current code pointless. There is however enough comments to keep you busy for a bit :-) By the way, you might want to keep your development

[RFC v2 1/2] media: platform: Add SH CEU camera interface driver

Add driver for SH Mobile CEU driver, based on drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c The original driver was based on soc-camera framework. Signed-off-by: Jacopo Mondi --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile