RE: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-22 Thread Phil Edworthy
Hi Lorenzo, On 21 August 2018 16:32, Lorenzo Pieralisi wrote: > On Tue, Aug 21, 2018 at 08:58:38AM +, Phil Edworthy wrote: > > On 20 August 2018 15:48 Lorenzo Pieralisi wrote: > > > On Mon, Aug 20, 2018 at 01:44:48PM +, Phil Edworthy wrote: > > > > > > [...] > > > > > > > However, both

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-21 Thread Lorenzo Pieralisi
On Tue, Aug 21, 2018 at 08:58:38AM +, Phil Edworthy wrote: > Hi Lorenzo, > > On 20 August 2018 15:48 Lorenzo Pieralisi wrote: > > On Mon, Aug 20, 2018 at 01:44:48PM +, Phil Edworthy wrote: > > > > [...] > > > > > However, both before and after this patch, the RP does not transition > >

RE: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-21 Thread Phil Edworthy
Hi Lorenzo, On 20 August 2018 15:48 Lorenzo Pieralisi wrote: > On Mon, Aug 20, 2018 at 01:44:48PM +, Phil Edworthy wrote: > > [...] > > > However, both before and after this patch, the RP does not transition > > L1 when the endpoints change to L1. > > This patch only transitions the RP to

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-20 Thread Lorenzo Pieralisi
On Mon, Aug 20, 2018 at 01:44:48PM +, Phil Edworthy wrote: [...] > However, both before and after this patch, the RP does not transition L1 > when the endpoints change to L1. > This patch only transitions the RP to L1 during accessing a card's > config registers, if the RP is not in L1 link

RE: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-20 Thread Phil Edworthy
Hello, Sorry for the delay. On 08 August 2018 14:30, Marek Vasut wrote: > On 07/25/2018 11:08 PM, Marek Vasut wrote: > > On 06/13/2018 07:25 PM, Bjorn Helgaas wrote: > >> On Wed, Jun 13, 2018 at 04:52:52PM +0100, Lorenzo Pieralisi wrote: > >>> On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-14 Thread Lorenzo Pieralisi
On Wed, Jun 13, 2018 at 12:25:59PM -0500, Bjorn Helgaas wrote: > Putting this workaround in the config accessor makes sense to me > because in this situation the endpoint thinks it's in L1 and it won't > receive TLPs for config accesses. Apparently forcing the RP to L1 > completes the L1

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-08-08 Thread Marek Vasut
On 07/25/2018 11:08 PM, Marek Vasut wrote: > On 06/13/2018 07:25 PM, Bjorn Helgaas wrote: >> On Wed, Jun 13, 2018 at 04:52:52PM +0100, Lorenzo Pieralisi wrote: >>> On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn Helgaas wrote: On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: >

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-07-25 Thread Marek Vasut
On 06/13/2018 07:25 PM, Bjorn Helgaas wrote: > On Wed, Jun 13, 2018 at 04:52:52PM +0100, Lorenzo Pieralisi wrote: >> On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn Helgaas wrote: >>> On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: On 06/11/2018 03:59 PM, Bjorn Helgaas wrote:

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-14 Thread Lorenzo Pieralisi
On Wed, Jun 13, 2018 at 12:25:59PM -0500, Bjorn Helgaas wrote: > On Wed, Jun 13, 2018 at 04:52:52PM +0100, Lorenzo Pieralisi wrote: > > On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn Helgaas wrote: > > > On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: > > > > On 06/11/2018 03:59 PM,

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-13 Thread Bjorn Helgaas
On Wed, Jun 13, 2018 at 04:52:52PM +0100, Lorenzo Pieralisi wrote: > On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn Helgaas wrote: > > On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: > > > On 06/11/2018 03:59 PM, Bjorn Helgaas wrote: > > > > On Sun, Jun 10, 2018 at 03:57:10PM +0200,

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-13 Thread Lorenzo Pieralisi
On Wed, Jun 13, 2018 at 08:53:08AM -0500, Bjorn Helgaas wrote: > On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: > > On 06/11/2018 03:59 PM, Bjorn Helgaas wrote: > > > On Sun, Jun 10, 2018 at 03:57:10PM +0200, Marek Vasut wrote: > > >> On 11/17/2017 06:49 PM, Lorenzo Pieralisi wrote:

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-13 Thread Bjorn Helgaas
On Wed, Jun 13, 2018 at 01:54:51AM +0200, Marek Vasut wrote: > On 06/11/2018 03:59 PM, Bjorn Helgaas wrote: > > On Sun, Jun 10, 2018 at 03:57:10PM +0200, Marek Vasut wrote: > >> On 11/17/2017 06:49 PM, Lorenzo Pieralisi wrote: > >>> On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: >

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-12 Thread Marek Vasut
On 06/11/2018 03:59 PM, Bjorn Helgaas wrote: > On Sun, Jun 10, 2018 at 03:57:10PM +0200, Marek Vasut wrote: >> On 11/17/2017 06:49 PM, Lorenzo Pieralisi wrote: >>> On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: From: Phil Edworthy Most PCIe host controllers support

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-11 Thread Bjorn Helgaas
On Sun, Jun 10, 2018 at 03:57:10PM +0200, Marek Vasut wrote: > On 11/17/2017 06:49 PM, Lorenzo Pieralisi wrote: > > On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: > >> From: Phil Edworthy > >> > >> Most PCIe host controllers support L0s and L1 power states via ASPM. > >> The R-Car

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2018-06-10 Thread Marek Vasut
On 11/17/2017 06:49 PM, Lorenzo Pieralisi wrote: > Hi Marek, Hi, > On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: >> From: Phil Edworthy >> >> Most PCIe host controllers support L0s and L1 power states via ASPM. >> The R-Car hardware only supports L0s, so when the system suspends

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2017-11-17 Thread Lorenzo Pieralisi
Hi Marek, On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: > From: Phil Edworthy > > Most PCIe host controllers support L0s and L1 power states via ASPM. > The R-Car hardware only supports L0s, so when the system suspends and > resumes we have to manually

Re: [PATCH V2 4/5] PCI: rcar: Support runtime PM, link state L1 handling

2017-11-12 Thread Simon Horman
On Fri, Nov 10, 2017 at 10:58:42PM +0100, Marek Vasut wrote: > From: Phil Edworthy > > Most PCIe host controllers support L0s and L1 power states via ASPM. > The R-Car hardware only supports L0s, so when the system suspends and > resumes we have to manually handle L1.